Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220321042142.69239-1-frank@zago.net> <20220321042142.69239-3-frank@zago.net>
In-Reply-To: <20220321042142.69239-3-frank@zago.net>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Mon, 28 Mar 2022 17:05:57 +0200
Message-ID: <CACRpkdaOHHkJnvB=RQ8dLXGxT_h5mGgy5Np87QVMcPzegNi2oQ@mail.gmail.com>
Subject: Re: [PATCH v4 2/3] gpio: ch341: add MFD cell driver for the CH341
To:     frank zago <frank@zago.net>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Wolfram Sang <wsa@kernel.org>, Johan Hovold <johan@kernel.org>,
        linux-usb@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
        linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Frank,

thanks for your patch!

I see you already got a bunch of homework from Andy, I will do a more
thorough review on the next iteration, just a few things:

On Mon, Mar 21, 2022 at 5:21 AM frank zago <frank@zago.net> wrote:

> The GPIO interface offers 16 GPIOs. 6 are read/write, and 10 are
> read-only.
>
> Signed-off-by: frank zago <frank@zago.net>
(...)
> +config GPIO_CH341
> +       tristate "CH341 USB adapter in GPIO/I2C/SPI mode"
> +       depends on MFD_CH341

I would add
default MFD_CD341

This way it gets selected automatically if the MFD module gets
selected. (I suspect you should do the same with the I2C module).

> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/mfd/core.h>
> +#include <linux/gpio.h>

Use <linux/gpio/driver.h>

Yours,
Linus Walleij