Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp5509625pxb; Mon, 28 Mar 2022 13:30:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8u+e5odFuNqJYTqTvDif6qJV78DaeS9b5Xr1jKRmfh3PxZfPALTkm6qqZD3JXzYJ5USlv X-Received: by 2002:a67:8c3:0:b0:325:5995:7a0e with SMTP id 186-20020a6708c3000000b0032559957a0emr12942615vsi.56.1648499408470; Mon, 28 Mar 2022 13:30:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648499408; cv=none; d=google.com; s=arc-20160816; b=QN2844fO6EcdG7UjSV0uxOnl4WgDlFc2LqDw0yIZEDvAbewpWmprfNUflVoi+7cjOj I+R7PFVU3YDboB775qpaag4BZuNGvKRpgzZR+4ELp7bQbHTA8wLyZLVegHqm6liyMSgO 7RSEQ4oe1uXlSG5/zNnkI0qg9k6UM+8UypDEkl3qaR26urKYdULY4NbqhGve8t/ty5CF e2UvjtW9o7IX8u3Uo3n6SgeG8A87zCGAHryxSopMVZN6ZtEc4Auh6eFPIwHsohEpEOYT 15z4vjHnANp7XwFyQsoxii5iFQOQSi6Dna0T9T7tsSry7+kWsNfZP7F7/61dyIrjnr1i GZ2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=lFPVATAPP8SMQnO5b+dcn4/0YVMSr84BOSW0pJSfP8E=; b=jnyEGcYI+0Rax6CJ+HedKN+sT5YVlh86Ef70d/Q/eCaT5EXy+XHU3zZBSObyEYwCYv AS+OfbDg+DiFFr6aX/7PPeNSuBuUDqPmLmefcz3ckdWMu20rNecrE7kAZerSKi1/OgTS 862W2VCS6VIPr/kT8JBIDCDy9OiBXbfW1FAYqc6aP920L55JqqQOeLnskdz3cxrA2ZAT rNlpnkUbD4yfN/NKhjNewbc6OIZzh23saYz7Dujujg6jdszOGgMynlpMq0KLgerpRVD6 LgkFshZbtYuG+PgMOMz8FKbUhEGQfEP1iCNqLIz62qio/cdK2RExBsrPNTaNguLpboAS c6mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=irGRDrAj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 5-20020a671005000000b00324c5c3c09esi2932233vsq.736.2022.03.28.13.29.53; Mon, 28 Mar 2022 13:30:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=irGRDrAj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241758AbiC1LrA (ORCPT + 99 others); Mon, 28 Mar 2022 07:47:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245056AbiC1Lik (ORCPT ); Mon, 28 Mar 2022 07:38:40 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BE77A3; Mon, 28 Mar 2022 04:36:11 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id t13so10794352pgn.8; Mon, 28 Mar 2022 04:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lFPVATAPP8SMQnO5b+dcn4/0YVMSr84BOSW0pJSfP8E=; b=irGRDrAjp4zX6St2s5LcSWL8OmrwDBpc7vD4dqEDZ8J+XVvrel1X5rmUE0vWO3CgEF 0ReKZpfJEF/YIZ78vx1yb87ss3EX6UCjnhHHMVRVkNioNZB6o4nnCvL6OE15DbXsTYEq e9PDXV0wk0zWeNcEmiXE54xDbNW9cSFLfU92XVJxB8VpwHWtdwwzTxuRG9OTub6daSQi i/9hvxED6silsojaj8EO9OQJBOusbPWphxRHwmRg3xY9+QhgFBQN12aMemQiefnY5nBh 5UbSpdfVb1wY3oRDnpP5gP/YT5PVDXwPM/Ns9SeVH3B1ntuGqCEBm90jQtlTQg86+ys1 X69A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lFPVATAPP8SMQnO5b+dcn4/0YVMSr84BOSW0pJSfP8E=; b=z9qiZyiRGrjn525jwFwq3ptc3TRTOKYScFaHaybOYaZdEbDy2xsACjsmTO5/yvQO/q aDJmITl0W1K2eFdFgorIeAoohQa8ffV54tkZsNwoJtY5qMoz/nRumsxQXFezW5azzfr+ H/YJrKkfgwcb1hXdhiPBecRuQJx/3k3tn+YIUkAakPE71RWsFcxlJMnfRIYCtszEsuLx 2uaWJGdsqhIgD0F7uAagfeH/71YzEe3w2eCNKkUWlwiZXLVDBMN8H1CnzJzwlpcWL910 j5tWvjxp5ZDLydObkPFC4abkmYO60HJro7MKk5JxNZPZhFSOfcozJBrDK9vZpwWGmp19 1Ubw== X-Gm-Message-State: AOAM530/Zh/4S0NY6+dB/lAjUVNZg3HB8tfYr9FPYWzJvuwl51o6lx6q aO1VFphr1rm7KGXTdUmIVs8= X-Received: by 2002:a65:6a08:0:b0:382:1af5:a4cb with SMTP id m8-20020a656a08000000b003821af5a4cbmr9823627pgu.398.1648467371142; Mon, 28 Mar 2022 04:36:11 -0700 (PDT) Received: from ubuntu.huawei.com ([119.3.119.18]) by smtp.googlemail.com with ESMTPSA id nl17-20020a17090b385100b001c70883f6ccsm23359509pjb.36.2022.03.28.04.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 04:36:10 -0700 (PDT) From: Xiaomeng Tong To: sj@kernel.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, xiam0nd.tong@gmail.com Subject: Re: [PATCH] damon: vaddr-test: fix a missing check on list iterator Date: Mon, 28 Mar 2022 19:36:04 +0800 Message-Id: <20220328113604.31373-1-xiam0nd.tong@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220328075104.31125-1-sj@kernel.org> References: <20220328075104.31125-1-sj@kernel.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Mar 2022 07:51:04 +0000, SJ wrote: > On Sun, 27 Mar 2022 16:03:45 +0800 Xiaomeng Tong wrote: > > > The bug is here: > > KUNIT_EXPECT_EQ(test, r->ar.start, start + i * expected_width); > > KUNIT_EXPECT_EQ(test, r->ar.end, end); > > > > For the damon_for_each_region(), just like list_for_each_entry(), > > the list iterator 'drm_crtc' will point to a bogus position > > containing HEAD if the list is empty or no element is found. > > This case must be checked before any use of the iterator, > > otherwise it will lead to a invalid memory access. > > We ensure 'damon_va_evenly_split_region()' successes before executing the loop, > so the issue cannot occur. That said, I think this patch makes code better to > read. Could you please resend this patch after fixing the commit message? Yes, you should be right. I have resend this patch with the commit message changed. Please check it, thank you. -- Xiaomeng Tong