Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Mar 2022 22:43:22 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Andy Gross <agross@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] arm64: dts: qcom: sm8250: move wcd938x node out of
 soc node
Message-ID: <YkHssmiGup+LdIBC@matsya>
References: <20220328143035.519909-1-vkoul@kernel.org>
 <20220328143035.519909-6-vkoul@kernel.org>
 <0b43c297-d0d6-f38f-9609-47fca856aa6d@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0b43c297-d0d6-f38f-9609-47fca856aa6d@linaro.org>
Precedence: bulk

On 28-03-22, 17:21, Krzysztof Kozlowski wrote:
> On 28/03/2022 16:30, Vinod Koul wrote:
> > The soc node expects all the nodes to have unit addresses. The wcd codec
> > node does not have that which causes warnings:
> > 
> > arch/arm64/boot/dts/qcom/sm8250-mtp.dts:631.17-648.4:
> > Warning (simple_bus_reg): /soc@0/codec: missing or empty reg/ranges property
> > 
> > Move wcd node out of soc to fix this
> > 
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 40 ++++++++++++-------------
> >  1 file changed, 19 insertions(+), 21 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
> > index fb99cc2827c7..3876a94b49a9 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
> > @@ -156,6 +156,25 @@ vreg_s6c_0p88: smpc6-regulator {
> >  		regulator-always-on;
> >  		vin-supply = <&vph_pwr>;
> >  	};
> > +
> > +	wcd938x: codec {
> 
> This probably should be under "sound" node. Anyway having it under soc
> seemed incorrect.

yeah it might make sense to be under sound. I think this is a slimbus
codec (right Srini..?) and this should be under slim node..

> 
> I actually wonder where this wcd9380 sits? What type of bus?
> 
> 
> > +		compatible = "qcom,wcd9380-codec";
> > +		#sound-dai-cells = <1>;
> > +		reset-gpios = <&tlmm 32 0>;
> > +		vdd-buck-supply = <&vreg_s4a_1p8>;
> > +		vdd-rxtx-supply = <&vreg_s4a_1p8>;
> > +		vdd-io-supply = <&vreg_s4a_1p8>;
> > +		vdd-mic-bias-supply = <&vreg_bob>;
> > +		qcom,micbias1-microvolt = <1800000>;
> > +		qcom,micbias2-microvolt = <1800000>;
> > +		qcom,micbias3-microvolt = <1800000>;
> > +		qcom,micbias4-microvolt = <1800000>;
> > +		qcom,mbhc-buttons-vthreshold-microvolt = <75000 150000 237000 500000 500000 500000 500000 500000>;
> > +		qcom,mbhc-headset-vthreshold-microvolt = <1700000>;
> > +		qcom,mbhc-headphone-vthreshold-microvolt = <50000>;
> > +		qcom,rx-device = <&wcd_rx>;
> > +		qcom,tx-device = <&wcd_tx>;
> > +	};
> >  };
> >  
> >  &adsp {
> > @@ -627,27 +646,6 @@ &slpi {
> >  	firmware-name = "qcom/sm8250/slpi.mbn";
> >  };
> >  
> > -&soc {
> > -	wcd938x: codec {
> > -		compatible = "qcom,wcd9380-codec";
> > -		#sound-dai-cells = <1>;
> > -		reset-gpios = <&tlmm 32 0>;
> > -		vdd-buck-supply = <&vreg_s4a_1p8>;
> > -		vdd-rxtx-supply = <&vreg_s4a_1p8>;
> > -		vdd-io-supply = <&vreg_s4a_1p8>;
> > -		vdd-mic-bias-supply = <&vreg_bob>;
> > -		qcom,micbias1-microvolt = <1800000>;
> > -		qcom,micbias2-microvolt = <1800000>;
> > -		qcom,micbias3-microvolt = <1800000>;
> > -		qcom,micbias4-microvolt = <1800000>;
> > -		qcom,mbhc-buttons-vthreshold-microvolt = <75000 150000 237000 500000 500000 500000 500000 500000>;
> > -		qcom,mbhc-headset-vthreshold-microvolt = <1700000>;
> > -		qcom,mbhc-headphone-vthreshold-microvolt = <50000>;
> > -		qcom,rx-device = <&wcd_rx>;
> > -		qcom,tx-device = <&wcd_tx>;
> > -	};
> > -};
> > -
> >  &sound {
> >  	compatible = "qcom,sm8250-sndcard";
> >  	model = "SM8250-MTP-WCD9380-WSA8810-VA-DMIC";
> 
> 
> Best regards,
> Krzysztof

-- 
~Vinod