Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp5586799pxb; Mon, 28 Mar 2022 14:35:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFN8GG5a1Gw7N8+aalDRviAws3bIswAMiuow2RUq0DFmsCW9QIhhx4pQOUx0qLgVbffctA X-Received: by 2002:a9f:3b2e:0:b0:347:33ae:e5e4 with SMTP id i46-20020a9f3b2e000000b0034733aee5e4mr13065316uah.49.1648503357871; Mon, 28 Mar 2022 14:35:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648503357; cv=none; d=google.com; s=arc-20160816; b=LUZlb2xZwbzmI/M1xv3Loek1IyDTBb8LAeCFIwvQX4DsGehv19HLPq1DId+O0udstD eu+Nfm9vO93YVZPzMXX/heDi1uu+2J/X4a/HlLKCghJ9qNdqnKgfvCXBj02UWd+ujXvx p/DXvmaSKORpQncrFB0f7LvU6ybHDWqhMd5lSjlOUpqPvyV22cQ1UkO4UoTXaGk4hB6P 2RjWnzKD0SphvSlICFdwi4S341PN2G9n2E3tn34OMlZ8+64TdUAp3hpOvpJJnfJCp5Pw S81rHx43FU9HlbxO9sVoY4ucDfDit5ypthXOM83DDai0pNYHFiUU8JxbnGUQ4MbMfDZ/ 78AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=2w1iGRFlUFzYZQb25gtkfr250s/8iB4YGZGpN06/dWE=; b=mAT5WbosIX7zjEo8ICm4tayfQMG8HMmhuhm/Ho+jIz+jx3fkXJJwVkr3UUWavVr7WE x34zfDCSR5tpBJH7fyBXBIr2YLL7qYz5BIz+VjSUdrBIpjFcAHAa8tiLehgfquINeCki YAji265oF+b0ay++sVlvLtZLiPCfAQd6uGqLvK0meVa57KpLdQ4r1bJKd7QO+wGPP7BB XegPRh607Q/C1m00rQFrUdisXxUt1N/QTjoyTp88HJBXL5nvnfhiQ32cPyfVklOADYow j0fOzrf5rAaBWUzNz5+NxR6msF6RsBDHZzPJuwh/m4regmKX/KTK/Ug422tC6+MSGFyR P/Cw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id i26-20020a056122129a00b0033fc368f3f4si3033954vkp.133.2022.03.28.14.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 14:35:57 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 988B57A98E; Mon, 28 Mar 2022 14:14:00 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240903AbiC1TSa (ORCPT + 99 others); Mon, 28 Mar 2022 15:18:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343598AbiC1TSI (ORCPT ); Mon, 28 Mar 2022 15:18:08 -0400 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01B9D6662F; Mon, 28 Mar 2022 12:16:26 -0700 (PDT) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (envelope-from ) id 1nYuqk-000YoB-Mr; Mon, 28 Mar 2022 21:16:22 +0200 Received: from p57bd9b9a.dip0.t-ipconnect.de ([87.189.155.154] helo=[192.168.178.81]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (envelope-from ) id 1nYuqk-003a6u-G9; Mon, 28 Mar 2022 21:16:22 +0200 Message-ID: Date: Mon, 28 Mar 2022 21:16:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/2] ia64: topology: Fix an error handling path in cache_add_dev() Content-Language: en-US To: Christophe JAILLET , Tony Luck , Zhang Yanmin Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-ia64@vger.kernel.org, Andrew Morton References: <452b20c160a20754022407acefd2abb170f43d14.1648494330.git.christophe.jaillet@wanadoo.fr> From: John Paul Adrian Glaubitz In-Reply-To: <452b20c160a20754022407acefd2abb170f43d14.1648494330.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.189.155.154 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe! On 3/28/22 21:07, Christophe JAILLET wrote: > If kobject_init_and_add()fails, kobject_put() needs to be called. > Add the missing call which is already there a few lines below in another > error handling path. > > Fixes: f19180056ea0 ("[IA64] Export cpu cache info by sysfs") > Signed-off-by: Christophe JAILLET Thanks for your patches. There is currently no maintainer for ia64, so the patches would have to go through Andrew Morton's tree. However, I can test the patches and verify they don't break anything. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913