Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <77377a51-f9d6-0ed6-afc2-387e4e7df3a0@fb.com>
Date:   Mon, 28 Mar 2022 08:30:19 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH] bpf: replace usage of found with dedicated list iterator
 variable
Content-Language: en-US
To:     Jakob Koschel <jakobkoschel@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>
Cc:     Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, netdev@vger.kernel.org,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
References: <20220327215010.2193515-1-jakobkoschel@gmail.com>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <20220327215010.2193515-1-jakobkoschel@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVVrREJEdGRHemMrY0wwQkxUNHVxdS9tS09UUnRPeHFmR3ErK2RUaHdrcjlT?=
 =?utf-8?B?VWxHMVAwQmpOZnN0bmxjK1lhTXRuK3kvZTgwcTh4MVVEeStQRVNSRWdaTzFL?=
 =?utf-8?B?amk4VEllZW5lTkJ6MWhXRW9yOVk4RGJLREpOTTVacFQzVjE2ZnBPdjZqZWg3?=
 =?utf-8?B?VExPS3k0QTlrb2l6T2NHRGpucUFrQVhvSDBGYW11cTFHV3RXVXloZzF3RWJ6?=
 =?utf-8?B?TzdQbVZMVEZEdkovVFJXeWphdk5jaW5ZdnVoWWJuRFFLN3dWL29INndIbmFU?=
 =?utf-8?B?OUVqdWZQMk1vR1RsNEdLRnM0SkpudHJBYWU2Q3kyT2M1SGU4ZDhNUmUvWXJK?=
 =?utf-8?B?TVdRbzlRWFRzS3R5cHhFVnExU2EvU3pwSy9Ebk8vVkw1dE9tWmhkT0ZIN0xZ?=
 =?utf-8?B?S2lUc3JJWTVwVFh5RW9PMUpRK1E0ZU1OY3RiY3lDMXlzOVRDNURmTVlNOGo3?=
 =?utf-8?B?VnlRd2dmMVkvNWhNNzR3SkFDSjR2MDJ2SXJERnNWbG9GVXl6QWpwYWM4TG54?=
 =?utf-8?B?ZDhrK2pGMGtGM3BXYm5XNE9OWEJEK3ZnZW03RUNvMHZyZlBZYjl2cUlxNkFL?=
 =?utf-8?B?RFYvY3RNUlVuam5lTGROK05ISkxmblVSTkt5VVg2ZVpaa1ZCVjk4clpqL3Q5?=
 =?utf-8?B?TUxaZlhyTlM5Q1lxTjFCOGxtcXBSNU40ay9EU3Bjb0F5VE9iTUdSRTFhVzZK?=
 =?utf-8?B?clRDYzlCVHFGZTR5TWVsR3ZNaVI0M0tDekdpL1YvYXlrK3dHRFkzK21lMFcw?=
 =?utf-8?B?bHl2TWk4elJFeWtGZFpEVzdBdm1QM08zVDJXT3ZCb2FNcTNpcVgrTlg0Ym85?=
 =?utf-8?B?c3VxL2N3cmNIZWw0dnMxS0EyM2JLZHQ3MkdYY2tLbkVnNE9DR2Mwc08rYXhK?=
 =?utf-8?B?dzIxRG5uNDJ1M091WWNqMjVNOGpXTGRJY2M4a1Rla2FEbERTZXNGWDhYVGo4?=
 =?utf-8?B?cnF3N3NWNmxnSlhzNlZ4SWh5WndMeGxDWU82TFVIc1lva2VrT1hoU3JRb0R0?=
 =?utf-8?B?RUtjTWc0aU5sS2FGQnp2c1dzZEdzZUQreXcxS0NCOFZuSVJMeXcxSDhVS210?=
 =?utf-8?B?SHh0bWxWR1YwVnZ4S2FjNnZUS1dMYlhKd3VtQ0p3OXplek9wWks3N3o2S3pm?=
 =?utf-8?B?M1M0TGhHOUxFbDExMFhMam1Lb2RBcTBlNnlyS1JFNnR3ZlUwT2pGVWl0Tkp0?=
 =?utf-8?B?VC9SU3NiY1RMOUFleGdDdzFFY2xmTElESmZrbUM5bXIzTUcwajRRS3Axb0JO?=
 =?utf-8?B?cFJVdXF6Y0lCYlY2d004Y0svQUYyaW51TW5scDZtTngwczVjb1gvQzRNWWRI?=
 =?utf-8?B?RHVoRkY1a01TMlFqZlZTYXlYbGc2Q3RhcFFzcGlCUHFxMm1BZ3ppZ1RSMzlu?=
 =?utf-8?B?dGxxdFE1eG9rcStldlVQMzNNUGJjNFluTTRhWTVPKzgzYnBHd3E1UnBnVkcy?=
 =?utf-8?B?bXl1R2kwQ1lOb2xhZFpRZXE4RHVjUVdIeDcvWXJDK01mdVBrZW9BbVpQSjA0?=
 =?utf-8?B?MjlNVmhGakU2WFMvaEV0MW53TGFiMU01ald3NWdtVGpLSDNpUFVsVG5odG9l?=
 =?utf-8?B?aGlhU08xdGg3QzhuNmF0THEvOGdqSmdqTjdQenhqL3NkdFUvbnU4Z1N6c3VN?=
 =?utf-8?B?eS9YeWoyM1QyY0FBMzkybkRlUGk5Z3NXdU9MMkl1bFd4YWV5UytNc01ZWTFi?=
 =?utf-8?B?WTVsVWlabi90cnUwNTdCQnM5K1dHWWhzb2VjZEF0TU5jMGw3NVU4Unh0ZWlk?=
 =?utf-8?B?aEJaY0Yvd01KeWpXbjl0VjJ2a3d3Nk9KbDdoMlNTTEMzbUcvQ2Zwa1JGMExU?=
 =?utf-8?B?MDhxaVovRjF3MkhwOUpPYzZlaTh1c2VLYWpweTVGWDFqZjV1LzBnK3kyM1JW?=
 =?utf-8?B?R0h5V3BnVDVmZU5ZUkFwc0YvZFJWWkNMS256YlNMRVZEam5UQkdnM1JDOWlR?=
 =?utf-8?B?aHlDdUtsTUZ0bmpjdXhvclpZZm9UcGFpdERUTnVneHQvSGRFc0Fic0JMN0Mw?=
 =?utf-8?B?N21wRXNxUUc5WVRFcFhBNXJzVE1Gek9GaUNZWjQ2bEx2UVN0eHJLZ0Y5NmhY?=
 =?utf-8?B?UFl4WDNZVWtMeVJ5NlFEek9hdjVUejVrYXNrWWVTTzZnbFNwT2p3V0lxZzJ1?=
 =?utf-8?B?cThZQktLV3cyazN6RWlwZEZ5amkzMGJoY0YzcDQzMHZUNndoUlROUUdUN2My?=
 =?utf-8?B?MDBFQ2QybTJ3ejcyZUZTdkhHN0tjZG1wbm1aQ0xRV1dpeGlQa1VHUjlMMDRr?=
 =?utf-8?B?L1JHdEV0QWpvQjFSa2RNWEFmNFgzSHFnNmF5VnQzUTBVby94a0w3TE1lRHN6?=
 =?utf-8?B?bHRLMjQzcGhXaHhVY2RJdDFVd0UyT0lOd1RpS3VGOGxGejMybHZxYjEycVBI?=
 =?utf-8?Q?p1rLcNYogOVZTUSg=3D?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48da5a21-ac37-46b7-3437-08da10cfe0eb
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2022 15:30:24.7100
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7jhucM+zVVip9k0Lh7CC7I7ztY2oKjHzm0LSFC7aepO44K/ARbBLolgSOFJRTbZs
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB3035
X-Proofpoint-GUID: Qtt4naJ4Xg6am2P8Z5OWs2T9tDsXudyZ
X-Proofpoint-ORIG-GUID: Qtt4naJ4Xg6am2P8Z5OWs2T9tDsXudyZ
Content-Transfer-Encoding: 7bit
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-03-28_07,2022-03-28_01,2022-02-23_01
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/27/22 2:50 PM, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
> 
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
> 
> This removes the need to use a found variable (supported & existed)
> and simply checking if the variable was set, can determine if the
> break/goto was hit.
> 
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/

Since in the commit message, we have a reference '[1]'. Maybe the above 
should be something like below?

   [1] 
https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/

> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>

Acked-by: Yonghong Song <yhs@fb.com>