Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 28 Mar 2022 09:08:43 -0700
From:   Mark Greer <mgreer@animalcreek.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Xiaomeng Tong <xiam0nd.tong@gmail.com>, vaibhav.sr@gmail.com,
        mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org,
        gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] greybus: audio_codec: fix three missing initializers for
 data
Message-ID: <20220328160843.GA262674@animalcreek.com>
References: <20220327060120.4316-1-xiam0nd.tong@gmail.com>
 <20220328141944.GT3293@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220328141944.GT3293@kadam>
Organization: Animal Creek Technologies, Inc.
Precedence: bulk

On Mon, Mar 28, 2022 at 05:19:45PM +0300, Dan Carpenter wrote:
> On Sun, Mar 27, 2022 at 02:01:20PM +0800, Xiaomeng Tong wrote:
> > These three bugs are here:
> > 	struct gbaudio_data_connection *data;
> > 
> > If the list '&codec->module_list' is empty then the 'data' will
> > keep unchanged.
> 
> All three of these functions check for if the codec->module_list is
> empty at the start of the function so these are not real bugs.

Umm, yep, oops.  Thanks Dan.

Mark
--