Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp5613542pxb; Mon, 28 Mar 2022 14:59:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBtVRO3mzlFfpiI1U4zV6qitHVDM1LHoj2CZydDE9tqUFDpKu1oJ6R1tCmo78KGsu1xNxq X-Received: by 2002:a9d:57c1:0:b0:5b2:2a7c:354b with SMTP id q1-20020a9d57c1000000b005b22a7c354bmr11165561oti.191.1648504776163; Mon, 28 Mar 2022 14:59:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648504776; cv=none; d=google.com; s=arc-20160816; b=Q6nuHGpAqJ38kJWVYzNN3JjLge/MkSTuLfccQtUAPoP/zB79e1AeVeJ0EdbEHHPoxO UbctPmeVo9mtfVg1MaxIo/VSO19LaiqoWtgkjZgfv+b7O0TmhUvYt0Kxi7vC3H/wU7+P s1N6xLPmjWsiwlVEqm/bUHfqDSrCxI7jGw4nvIl2/68ntib5dR5oUdVMRtB2bvO0IblS TQWjGHKZtPqXgagyCxwWRy7aKJ2TG1/7q/RCAfL6PWjCF9mNmAEU4VVJ6ykB1CvMKnpw LFYCIfr6tjMBuuqa/CyBLRfYDNW4nzrWWvWpA7oKW1Z67E7h+yEuNoLud4vvKI7CI5PT lAjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=K1GDc+QJWhYEe9B5KwJciqzvBoL8N5FOvcNlONWFAIU=; b=O4bT/4MPOJ+tqRHu421qKVNpd9Ky2ai+mmBz59hx/g/UrzJw2ahT1CjxxlxIUj7to9 SUWRwxk6TUkK8q/J0ysahd6l6E366UP+Hbn02KpwKqUPlKIJfRYt0/1TrbrA1AW4gMP+ 0p45pw5ytgADe7JBBmrAxXXPACoHtI3j+mmci6o69L9vAMMEU+mkzWmlASux6hhizL8i Ja2bV85LZ/0wflLpgc4AIepskwlNwN8mFJUF6AtAhfyPeLfpy3/C0ICzShtav1v4a2Oz 8EfDOjXeltRqEdIPC1icciYSXTJN/qEW8dz7wT9KsGpz8Aj14RoAXje3YdzTWOyjBalR gSTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=RubwMEPD; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id g13-20020a056870c38d00b000da716e6249si11622197oao.210.2022.03.28.14.59.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 14:59:36 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=RubwMEPD; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E0C05673D1; Mon, 28 Mar 2022 14:25:23 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241690AbiC1Lqj (ORCPT + 99 others); Mon, 28 Mar 2022 07:46:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244164AbiC1LhY (ORCPT ); Mon, 28 Mar 2022 07:37:24 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B40E28E26 for ; Mon, 28 Mar 2022 04:29:39 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id m22so13716843pja.0 for ; Mon, 28 Mar 2022 04:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=K1GDc+QJWhYEe9B5KwJciqzvBoL8N5FOvcNlONWFAIU=; b=RubwMEPDFLu856QooxU8gVDiQIA2hT1b620J4DxI9O8yZdT5Q3ZmepeXh/LsHlKr9Q ga31VSpBvCU2kgCkEQo57UWND6TOscCSI2C9+kKt9ik3dLiG1217Yr1XaAGzeMAnedpF w3V/Neo4elRASPM4JWEA6uuNkXjAHyqDvTuyZMZlv7BVMKdZriYyhu6t+zlpXAbxPvfl tne8ytdGQXMFroeRM47d1y71A4hIgxsRpdyDbyCh3lZaFtmUMBo3jV8hGSfv789g0uE9 wAhydDl29xGGcoxRL/JI7969bFs7NE/WQ+C30E8I9/UA33RexHtMBBWYmbbqX0EXlL4a 3l5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=K1GDc+QJWhYEe9B5KwJciqzvBoL8N5FOvcNlONWFAIU=; b=v70sMsAFbY5/BCIYUa15gAcivWdefcmSm1f5+OH6rxdMJCPGlE90D5VgD6Z+5YzXc4 NCwHrgteHXKcd+aYh65ZvjVjqajsTE5Pgq5jZsg0QPqUC/5ZbKnCv8lHVysF5I+J4MSb 7lCdYoMHsBPQuRcv3jQBicwIT1x+4SbSnuklqhaFbeXr02fD+GY9z9COLn2Wpgqfk0FW XGCUnw1fLiw84eQNTiMSaMH9mxFw8Gg9RYgUfYF6eIONPwKR6rOMITENLf1KgIpphnYJ MzJRZkMlvhfpNAIfAvG6sXluBR1x7ISzFbebdwhIzT6hte1VyXb5XqjcS8Pn+sFGahHV Z1ig== X-Gm-Message-State: AOAM5339kCVYvKijErMlkgrXbIHWshe4Z9WA7q37esxLA9iHaU5qIAB0 Yia3mg0QCJR5fytC0NyH/YU= X-Received: by 2002:a17:902:d2ce:b0:154:7271:9c0f with SMTP id n14-20020a170902d2ce00b0015472719c0fmr25690548plc.85.1648466979418; Mon, 28 Mar 2022 04:29:39 -0700 (PDT) Received: from ubuntu.huawei.com ([119.3.119.18]) by smtp.googlemail.com with ESMTPSA id c69-20020a633548000000b0038554192b91sm13064338pga.38.2022.03.28.04.29.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 04:29:38 -0700 (PDT) From: Xiaomeng Tong To: sj@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaomeng Tong Subject: [PATCH] damon: vaddr-test: tweak code to make the logic clearer Date: Mon, 28 Mar 2022 19:29:30 +0800 Message-Id: <20220328112930.31229-1-xiam0nd.tong@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move these two lines into the damon_for_each_region loop, it is always for testing the last region. And also avoid to use a list iterator 'r' outside the loop which is considered harmful[1]. [1]: https://lkml.org/lkml/2022/2/17/1032 Signed-off-by: Xiaomeng Tong --- mm/damon/vaddr-test.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mm/damon/vaddr-test.h b/mm/damon/vaddr-test.h index 6a1b9272ea12..98b7a9f54b35 100644 --- a/mm/damon/vaddr-test.h +++ b/mm/damon/vaddr-test.h @@ -281,14 +281,16 @@ static void damon_test_split_evenly_succ(struct kunit *test, KUNIT_EXPECT_EQ(test, damon_nr_regions(t), nr_pieces); damon_for_each_region(r, t) { - if (i == nr_pieces - 1) + if (i == nr_pieces - 1) { + KUNIT_EXPECT_EQ(test, + r->ar.start, start + i * expected_width); + KUNIT_EXPECT_EQ(test, r->ar.end, end); break; + } KUNIT_EXPECT_EQ(test, r->ar.start, start + i++ * expected_width); KUNIT_EXPECT_EQ(test, r->ar.end, start + i * expected_width); } - KUNIT_EXPECT_EQ(test, r->ar.start, start + i * expected_width); - KUNIT_EXPECT_EQ(test, r->ar.end, end); damon_free_target(t); } -- 2.17.1