Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
In-Reply-To: <HK2PR04MB3891BE0766FAF0AEC39FE2DC811A9@HK2PR04MB3891.apcprd04.prod.outlook.com>
References: <HK2PR04MB3891BE0766FAF0AEC39FE2DC811A9@HK2PR04MB3891.apcprd04.prod.outlook.com>
From:   Namjae Jeon <linkinjeon@kernel.org>
Date:   Mon, 28 Mar 2022 10:43:39 +0900
Message-ID: <CAKYAXd8Q7-1O9PQ693stmLjoG99KME__FSm0gPtvndi4xxoVcA@mail.gmail.com>
Subject: Re: [PATCH 1/2] exfat: fix referencing wrong parent directory
 information after renaming
To:     "Yuezhang.Mo@sony.com" <Yuezhang.Mo@sony.com>
Cc:     "sj1557.seo@samsung.com" <sj1557.seo@samsung.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "Andy.Wu@sony.com" <Andy.Wu@sony.com>,
        "Wataru.Aoyama@sony.com" <Wataru.Aoyama@sony.com>,
        "Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp" 
        <Kohada.Tetsuhiro@dc.mitsubishielectric.co.jp>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

2022-03-25 18:42 GMT+09:00, Yuezhang.Mo@sony.com <Yuezhang.Mo@sony.com>:
Hi Yuezhang,

> During renaming, the parent directory information maybe
> updated. But the file/directory still references to the
> old parent directory information.
>
> This bug will cause 2 problems.
>
> (1) The renamed file can not be written.
>
>     [10768.175172] exFAT-fs (sda1): error, failed to bmap (inode : 7afd50e4
> iblock : 0, err : -5)
>     [10768.184285] exFAT-fs (sda1): Filesystem has been set read-only
>     ash: write error: Input/output error
Could you please elaborate how to reproduce it ?

Thanks.
>
> (2) Some dentries of the renamed file/directory are not set
>     to deleted after removing the file/directory.
>
> fixes: 5f2aa075070c ("exfat: add inode operations")
>
> Signed-off-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
> Reviewed-by: Andy Wu <Andy.Wu@sony.com>
> Reviewed-by: Aoyama Wataru <wataru.aoyama@sony.com>
> Reviewed-by: Daniel Palmer <daniel.palmer@sony.com>
> ---
>  fs/exfat/namei.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c
> index a02a04a993bf..e7adb6bfd9d5 100644
> --- a/fs/exfat/namei.c
> +++ b/fs/exfat/namei.c
> @@ -1080,6 +1080,7 @@ static int exfat_rename_file(struct inode *inode,
> struct exfat_chain *p_dir,
>
>  		exfat_remove_entries(inode, p_dir, oldentry, 0,
>  			num_old_entries);
> +		ei->dir = *p_dir;
>  		ei->entry = newentry;
>  	} else {
>  		if (exfat_get_entry_type(epold) == TYPE_FILE) {
> --
> 2.25.1
>