Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <d723e20a-b461-f63e-2fd1-eea91b0dddf1@intel.com>
Date:   Mon, 28 Mar 2022 05:39:02 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [patch 0/7] x86/fpu: Cure supervisor mode (ENQCMD) fallout
Content-Language: en-CA
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     <x86@kernel.org>, Paolo Bonzini <bonzini@gnu.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Tony Luck <tony.luck@intel.com>
References: <20220324134548.432837672@linutronix.de>
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <20220324134548.432837672@linutronix.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWcxdkhnT3pUMVc3MUs3Ukh2dUl5T0xMeFMyNjNaQjBJU011WU1hTW5SSmhS?=
 =?utf-8?B?eVRFWTlmVmlIdGZqNi9oTXZnRTYwODRuVHVJdGs0TVFRNzdkSWE1U0NLU0Ex?=
 =?utf-8?B?bThwWlFrTC8xeEJhaW93ejhHN2UxVG9tRVlqSW9NemxTR0NycStnbXpBOFJa?=
 =?utf-8?B?Q2xKUnZsRmZTZlZCaGdpNDNyNEZHZFZWaUJxT1RXKzZ4YVFWbFR0U0xaZTRL?=
 =?utf-8?B?dEJrTWIrQTRJdjdodkRISHhkWVNKeU5pWEtkdmprdW1oZWUwazZBNWFWWFVl?=
 =?utf-8?B?UHl4UERTRXo2eE5WaDAvMHBXcDNyKzZ0VDlNS0UyUDZtNWZ2aEhYMlNIdEhq?=
 =?utf-8?B?NGxFVW5GSHIxNUgrb1hPZ2pEOGFlTG5GTjVsdk5Qa2VqT3pFK0daTDJPQVdV?=
 =?utf-8?B?T0dGMVlMZkl3TGxmV0taNjlTWThxbnRMd0FjTUFFYm9CRmtVaWxIM3dzWUFz?=
 =?utf-8?B?djhqZnRsVVpoaTVrZThFQTB5YlhEbGhZV3RBRGN5aDZCWEJVZzNGN0QvVndP?=
 =?utf-8?B?aEREMXBDMVZ3K3p6aCtRWmVWWU1lMTdrRjFpdlBlMXI3L2dKWkwrQkdhZWpz?=
 =?utf-8?B?bFlIZytqTUZYeUZhTVMyL2d3SDR5NFNVM09Wc3lPdWJGRnhkRXBjNUM4UU1L?=
 =?utf-8?B?SWk4czRaVWNhMUlDa2poeUxnSTAxSG8yTDgreWpFTm1vSDR6R1VpeDdZTDMw?=
 =?utf-8?B?V09ySGRESU9uSEpxSFFKQ0xlQUZNckJ4ZktjRUJQNHNpTzhXQXNKWGpFaitE?=
 =?utf-8?B?VllQQlJDcGNoNFNuczgwTWNKdVhTcjY1eGpiYlZIOWh0aUMvUzA4WXc0TE9X?=
 =?utf-8?B?dFZ2dDZscUVncjBTVEVzRzJ3dTZoTnRieVJPeGlaWGNFK0ltZ0FFcDh4S282?=
 =?utf-8?B?ZE4vZkFSVHFKdGZTaG1pQzFCMHhXbEVJeDNlc3FUL2dyUE5VcmdXaGtwVm1X?=
 =?utf-8?B?U3ZXV2R1UkJ3MThsTzVPRDAzRlo2U09OUmFGWVcxWWlxeXpOdFZldmNlMHI0?=
 =?utf-8?B?YjlmbHgvSHc0U1R4SkVQYWZ5MllOeGx1cnQzczd6ZGNhSnU2NXVwaGNZQjlG?=
 =?utf-8?B?cjZWQmZTVzZFTVlKdGVQQ05MNFVDa1NyZ0RPbTBScjhJSGdVSHJpcmorZTAw?=
 =?utf-8?B?OW5KQTJVT0RZL2ZKajJWUUtLQW9OQjBtSC8rdlVhQkZBMTYxWDBrak1mZVRx?=
 =?utf-8?B?T01kTEk4M0c3UU1JTEhXVlc4NWZOYlJBR2JtZUdXK244bFFiNmNzVm44OXhR?=
 =?utf-8?B?UTA3ckMyZUk1VFhqTUdLOFhscE5oRk9YYm90RmFQSmU1Tnp5d0FvUzBtUmVG?=
 =?utf-8?B?elI3L3BUcUpwUmtYRFZOY3VIRkY2UFJqMTMxc0Y5V1lVU0tjb0l4bXpuN1ps?=
 =?utf-8?B?ZklGVVlRbkNGMkxuNXBOcHhZeDBMb2RVUjBONHJrRGxIUTFrWG1tT01wMWxw?=
 =?utf-8?B?cXJsN1gxR1E3RTBaMVkxSWpOZ3EwOVQya1BZTkVtZzB2a2p1TEdxYWNsRUlQ?=
 =?utf-8?B?WE9jTWF4OUcrdm05d1R1eDdScDJIV1BSR0NCaUI1bVFoRG42dExaL2huTGJm?=
 =?utf-8?B?cjluaWw4RmNmVmlNMktHNDhaOUxnK3c1U2VCYUNxMjhlSWkxSyt2eXhuOEgz?=
 =?utf-8?B?UWVtaTR4QWFsNFlQQ0pBZVZUS3JzalBvNUFEZ21ycWYxaGdnbFZQaHNQblRY?=
 =?utf-8?B?aDFpUWJZZ2F1VWxBT0NpSStBYjNpaC9kVUJNdmpxREE2NCs4ampNYjFTVGVO?=
 =?utf-8?B?cS9LaFQra0hzRkQvc0EySitiZG96azlOWWJBeDQ1YW5ZOS9hV1hqUEE5bXZ4?=
 =?utf-8?B?MVlyMVd4VjdRZTdTNkNCSGlxZ29ZYTFrd0tURGFSdHdJb3h0NWZwSXdKRDA0?=
 =?utf-8?B?VnRteE5RMDhMU3UrbTQzb0tLT0s3Y2hTZDMyZWNBZ2xZQ05qSHplcWlDU2E4?=
 =?utf-8?B?MHplcC9BV2RLVmxqUnZMQnBhZHlDVlBDYmEvUjNRVjJoYkdjNUZCaWsvRXdi?=
 =?utf-8?B?RXF3THRGbjdlM1JQYnpRY29HV1BUbWRWMDRhdlorL2pMbHVXYzJ0Qlc2cE9X?=
 =?utf-8?B?VEF5KzZETEIrVERkMEtPaXFzbVQweStNazhPTWRXQnd4bGRTcWpPSTJXZ3F3?=
 =?utf-8?B?OGVZenl0V3JmRUNUN3dQT0FIOWZpM3gxb2ZUck5rM1FpR0g0NGRnT3F5U0ds?=
 =?utf-8?B?ckVZQldFTnNPOTY1bXBSTEpTUEpMaCtwYXpqeFNoS3ZTMy9GWjNzVGxDaUpM?=
 =?utf-8?B?ck9SL29RUU1kblhONTUvYVRTb2loWEluYzNMMTJYL05DOVJ2NkgrZUx0WGY2?=
 =?utf-8?B?TXRNd05UU3NrOTdLOEUzS3RMNGpUNGVMSm9lS0VINzNQL2c0ckthZndSN253?=
 =?utf-8?Q?lWAwjjm8kDrAchj8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a03201a-dbd7-4ab0-fb83-08da10b7f872
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4849.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2022 12:39:16.3127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fKFEVSkgrk2KKcySZewJ4p5Yqg02C4eXgH3wvaZ3ohbdmXM82xOeC7Zmzbk7SR/YnVQf65tcfBZk83rCdnfalWTvFbaGnM2uAfkYbRdeUpo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1885
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/24/2022 6:47 AM, Thomas Gleixner wrote:
> 
> It builds, boots on host and guest, but is not yet extensively tested.
> Testing with a AMX + PASID enabled machine has not been done at all as I
> don't have easy access to such a beast.

The AMX tests [1][2] went well on both host and guest. Also dmesg logs 
look to be okay:

On host,

$ sudo dmesg | grep fpu
[    0.000000] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating 
point registers'
[    0.000000] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers'
[    0.000000] x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers'
[    0.000000] x86/fpu: Supporting XSAVE feature 0x020: 'AVX-512 opmask'
[    0.000000] x86/fpu: Supporting XSAVE feature 0x040: 'AVX-512 Hi256'
[    0.000000] x86/fpu: Supporting XSAVE feature 0x080: 'AVX-512 ZMM_Hi256'
[    0.000000] x86/fpu: Supporting XSAVE feature 0x200: 'Protection Keys 
User registers'
[    0.000000] x86/fpu: Supporting XSAVE feature 0x400: 'PASID state'
[    0.000000] x86/fpu: Supporting XSAVE feature 0x20000: 'AMX Tile config'
[    0.000000] x86/fpu: Supporting XSAVE feature 0x40000: 'AMX Tile data'
[    0.000000] x86/fpu: xstate_offset[2]:  576, xstate_sizes[2]:  256
[    0.000000] x86/fpu: xstate_offset[5]:  832, xstate_sizes[5]:   64
[    0.000000] x86/fpu: xstate_offset[6]:  896, xstate_sizes[6]:  512
[    0.000000] x86/fpu: xstate_offset[7]: 1408, xstate_sizes[7]: 1024
[    0.000000] x86/fpu: xstate_offset[9]: 2432, xstate_sizes[9]:    8
[    0.000000] x86/fpu: xstate_offset[10]: 2440, xstate_sizes[10]:    8
[    0.000000] x86/fpu: xstate_offset[17]: 2496, xstate_sizes[17]:   64
[    0.000000] x86/fpu: xstate_offset[18]: 2560, xstate_sizes[18]: 8192
[    0.000000] x86/fpu: Enabled xstate features 0x606e7, context size is 
10752 bytes, using 'compacted' format.

On guest,
(AMX is available with the upstream Qemu [3].)

$ sudo dmesg | grep fpu
...
[    0.000000] x86/fpu: Supporting XSAVE feature 0x200: 'Protection Keys 
User registers'
[    0.000000] x86/fpu: Supporting XSAVE feature 0x20000: 'AMX Tile config'
[    0.000000] x86/fpu: Supporting XSAVE feature 0x40000: 'AMX Tile data'
...
[    0.000000] x86/fpu: xstate_offset[9]: 2432, xstate_sizes[9]:    8
[    0.000000] x86/fpu: xstate_offset[17]: 2496, xstate_sizes[17]:   64
[    0.000000] x86/fpu: xstate_offset[18]: 2560, xstate_sizes[18]: 8192
[    0.000000] x86/fpu: Enabled xstate features 0x602e7, context size is 
10752 bytes, using 'compacted' format.

Thanks,
Chang

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/tree/tools/testing/selftests/x86/amx.c?h=x86/fpu
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/tree/tools/testing/selftests/kvm/x86_64/amx_test.c?h=x86/fpu
[3] 
https://git.qemu.org/?p=qemu.git;a=commit;h=3d31fe4d662f13c70eb7e87f29513623ccd76322