Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 28 Mar 2022 09:07:05 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     trix@redhat.com
Cc:     sfrench@samba.org, ndesaulniers@google.com,
        linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] cifs: fix enum usage
Message-ID: <YkHdKQ8TlhXTv1FP@dev-arch.thelio-3990X>
References: <20220328130300.3090213-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220328130300.3090213-1-trix@redhat.com>
Precedence: bulk

On Mon, Mar 28, 2022 at 06:03:00AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Clang build fails with
> cifsfs.c:709:18: error: implicit conversion from enumeration
>   type 'enum statusEnum' to different enumeration
>   type 'enum tid_status_enum'
>   tcon->status = CifsExiting;
>                ~ ^~~~~~~~~~~
> 
> The type of the element status changed, so enum needed to change.
> Replace CifsExiting with TID_EXITING.

Right, this was clearly missed by the below commit, as every other
instance of tidStatus was changed to status plus the value from
enum tid_status_enum, except this one.

> Fixes: 7e5c8c02911b ("smb3: cleanup and clarify status of tree connections")
> Signed-off-by: Tom Rix <trix@redhat.com>

Thanks for sending the patch!

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  fs/cifs/cifsfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> index 0789bf1496c74..a47fa44b6d52b 100644
> --- a/fs/cifs/cifsfs.c
> +++ b/fs/cifs/cifsfs.c
> @@ -706,7 +706,7 @@ static void cifs_umount_begin(struct super_block *sb)
>  		spin_unlock(&cifs_tcp_ses_lock);
>  		return;
>  	} else if (tcon->tc_count == 1)
> -		tcon->status = CifsExiting;
> +		tcon->status = TID_EXITING;
>  	spin_unlock(&cifs_tcp_ses_lock);
>  
>  	/* cancel_brl_requests(tcon); */ /* BB mark all brl mids as exiting */
> -- 
> 2.26.3
> 
>