Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220318141441.32329-1-pali@kernel.org>
In-Reply-To: <20220318141441.32329-1-pali@kernel.org>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Mon, 28 Mar 2022 16:04:26 +0200
Message-ID: <CAPDyKFrQiHoY6wrGRDE6p0zarBiABJJB3DH5d1K+Mw5SrxMmEA@mail.gmail.com>
Subject: Re: [PATCH] Revert "mmc: sdhci-xenon: fix annoying 1.8V regulator warning"
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>
Cc:     Hu Ziji <huziji@marvell.com>,
        =?UTF-8?B?TWFyZWsgQmVow7pu?= <marek.behun@nic.cz>,
        Marcin Wojtas <mw@semihalf.com>,
        Konstantin Porotchkin <kostap@marvell.com>,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 18 Mar 2022 at 15:14, Pali Roh=C3=A1r <pali@kernel.org> wrote:
>
> This reverts commit bb32e1987bc55ce1db400faf47d85891da3c9b9f.
>
> Commit 1a3ed0dc3594 ("mmc: sdhci-xenon: fix 1.8v regulator stabilization"=
)
> contains proper fix for the issue described in commit bb32e1987bc5 ("mmc:
> sdhci-xenon: fix annoying 1.8V regulator warning").
>
> Fixes: 8d876bf472db ("mmc: sdhci-xenon: wait 5ms after set 1.8V signal en=
able")
> Cc: stable@vger.kernel.org # 1a3ed0dc3594 ("mmc: sdhci-xenon: fix 1.8v re=
gulator stabilization")
> Signed-off-by: Pali Roh=C3=A1r <pali@kernel.org>

Applied for fixes, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-xenon.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xeno=
n.c
> index 666cee4c7f7c..08e838400b52 100644
> --- a/drivers/mmc/host/sdhci-xenon.c
> +++ b/drivers/mmc/host/sdhci-xenon.c
> @@ -241,16 +241,6 @@ static void xenon_voltage_switch(struct sdhci_host *=
host)
>  {
>         /* Wait for 5ms after set 1.8V signal enable bit */
>         usleep_range(5000, 5500);
> -
> -       /*
> -        * For some reason the controller's Host Control2 register report=
s
> -        * the bit representing 1.8V signaling as 0 when read after it wa=
s
> -        * written as 1. Subsequent read reports 1.
> -        *
> -        * Since this may cause some issues, do an empty read of the Host
> -        * Control2 register here to circumvent this.
> -        */
> -       sdhci_readw(host, SDHCI_HOST_CONTROL2);
>  }
>
>  static unsigned int xenon_get_max_clock(struct sdhci_host *host)
> --
> 2.20.1
>