Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <cda00ff76a61869294f2b17c4c7be2ca8402af35.camel@intel.com>
Subject: Re: [PATCH v2 03/21] x86/virt/tdx: Implement the SEAMCALL base
 function
From:   Kai Huang <kai.huang@intel.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc:     "Hansen, Dave" <dave.hansen@intel.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
        "sathyanarayanan.kuppuswamy@linux.intel.com" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "Luck, Tony" <tony.luck@intel.com>,
        "ak@linux.intel.com" <ak@linux.intel.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "Yamahata, Isaku" <isaku.yamahata@intel.com>
Date:   Mon, 28 Mar 2022 22:10:22 +1300
In-Reply-To: <BN9PR11MB5276D7C515C1F28300B0B3018C1D9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1647167475.git.kai.huang@intel.com>
         <269a053607357eedd9a1e8ddf0e7240ae0c3985c.1647167475.git.kai.huang@intel.com>
         <BN9PR11MB5276B5986582F9AD11D993618C189@BN9PR11MB5276.namprd11.prod.outlook.com>
         <926af8966a2233574ee0e679d9fc3c8209477156.camel@intel.com>
         <BN9PR11MB5276D7C515C1F28300B0B3018C1D9@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2022-03-28 at 21:16 +1300, Tian, Kevin wrote:
> > From: Huang, Kai <kai.huang@intel.com>
> > Sent: Monday, March 28, 2022 9:42 AM
> > 
> > 
> > > 
> > > > 
> > > > A CPU-attested software module (called the 'TDX module') runs in SEAM
> > > > VMX root to manage the crypto protected VMs running in SEAM VMX
> > non-
> > > > root.
> > > > SEAM VMX root is also used to host another CPU-attested software
> > module
> > > > (called the 'P-SEAMLDR') to load and update the TDX module.
> > > > 
> > > > Host kernel transits to either the P-SEAMLDR or the TDX module via the
> > > > new SEAMCALL instruction.  SEAMCALLs are host-side interface functions
> > > > defined by the P-SEAMLDR and the TDX module around the new
> > SEAMCALL
> > > > instruction.  They are similar to a hypercall, except they are made by
> > > 
> > > "SEAMCALLs are ... functions ... around the new SEAMCALL instruction"
> > > 
> > > This is confusing. Probably just:
> > 
> > May I ask why is it confusing?
> 
> SEAMCALL is an instruction. One of its arguments carries the function
> number.
> 

To confirm, are you saying the word "SEAMCALLs" is confusing, and we should use
"SEAMCALL leaf functions" instead?

-- 
Thanks,
-Kai