Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220310125450.4164164-1-sunsetdzz@gmail.com> <20220320152047.2a04a62e@jic23-huawei>
 <OZ839R.NWJC2LY54LGX@crapouillou.net>
In-Reply-To: <OZ839R.NWJC2LY54LGX@crapouillou.net>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sun, 27 Mar 2022 22:52:37 +0300
Message-ID: <CAHp75VdFPfWAbhysdr8gRuJPeGc2O5Vm8W3E6+EQ5kPynVnM-w@mail.gmail.com>
Subject: Re: [PATCH] iio: dac: ad5592r: Fix the missing return value.
To:     Paul Cercueil <paul@crapouillou.net>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Zizhuang Deng <sunsetdzz@gmail.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Paul Cercueil <paul.cercueil@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Mar 21, 2022 at 11:34 AM Paul Cercueil <paul@crapouillou.net> wrote=
:
> Le dim., mars 20 2022 at 15:20:47 +0000, Jonathan Cameron
> <jic23@kernel.org> a =C3=A9crit :
> > On Thu, 10 Mar 2022 20:54:50 +0800
> > Zizhuang Deng <sunsetdzz@gmail.com> wrote:
> >
> >>  The third call to `fwnode_property_read_u32` did not record
> >>  the return value, resulting in `channel_offstate` possibly
> >>  being assigned the wrong value.

> > Definitely rather odd looking and I think your conclusion is correct.
> > +CC Paul for confirmation that this isn't doing something clever..
>
> It's been a while, but I don't think there was anything clever going on
> here - so the patch is fine.

Basically the question here is what value should offstate have when
there is no such property. Currently it's the same value as modes (no
seeing context other than in the patch).

> >>              if (!ret)
> >>                      st->channel_modes[reg] =3D tmp;
> >>
> >>  -           fwnode_property_read_u32(child, "adi,off-state", &tmp);
> >>  +           ret =3D fwnode_property_read_u32(child, "adi,off-state", =
&tmp);
> >>              if (!ret)
> >>                      st->channel_offstate[reg] =3D tmp;


--=20
With Best Regards,
Andy Shevchenko