Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp5643961pxb; Mon, 28 Mar 2022 15:25:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWYUXKEqkjh+yXDrqFHGeHiuyxn2+bhBR682iQ8TX3EczCOaIAaG7xcXS9ikNYWDExoOJy X-Received: by 2002:a67:fd5c:0:b0:325:434e:714c with SMTP id g28-20020a67fd5c000000b00325434e714cmr13602596vsr.37.1648506300311; Mon, 28 Mar 2022 15:25:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648506300; cv=none; d=google.com; s=arc-20160816; b=Y9QM5qrh/k/qm6+abRGov6Uy+bSRjNQd5UzHArqnqDVmmZlVfbjC7V1TX7T0rqlqSB 3dJ1U4IvaN7CBM9q5q9G4vaKRxheGxQgoFtyceasPrVk/q7eQWLO1i11hD5nrn5j1UKK cDzkuXBphZU9ET2jefFvewEv/i/W0J8oL/FzoybDlh9oCE9EDc9MBJYODlxI8WUgIUsz 3Pjo0oBMYN1vyr58rnq9zIfNpZebLHbcPGwFRyNzllInJo/Rb+W0kwyQybgpDDzMlr50 ++FZj8KB4iVwPmSSlefp9889g72sisgJK1K24GPh5hjQVco6GrNnvijKOjoEuEgn9Z0U tW5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iaDCRr4jngunKHOzvwdGl/9tYszhyZ5av0wToaoMVfk=; b=sqO6aZmUEZ/G5ia+TIo+Wwq9KWMhZJWHiYl3yuGJ9BOGjf63A8bG9BzK01GKP+2fS0 RWhmnqz0RTvHcFBXcNkd7YCnSlPh/nwouKQcy8HZ0bTh+G5nbMsSQMJW7vlxRE2SfZUZ 8ix3O6+kO2ietqq0gIngzrQYDa0Fv3JPBYquIkaYYtipgon52bJGS1eossb5qFzUOboM oWG1WoDRiejxzPboDrl6i+kx/G99dFYdsdR8A1pPn8vQR/UCj3G+j9VAGZ+/eweI36Qo aSoP9kc2qoZ0LuT59kT5UU+FmqBv1SmfgiUwAaIlMRk/4yT9kIHBm85PsklYwTGSQt09 LrHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u1UEUseN; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id p26-20020a05610223fa00b00325a9dcfcc1si2603341vsc.528.2022.03.28.15.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 15:25:00 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u1UEUseN; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6BC551C0247; Mon, 28 Mar 2022 14:41:27 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229538AbiC1LWR (ORCPT + 99 others); Mon, 28 Mar 2022 07:22:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240766AbiC1LVc (ORCPT ); Mon, 28 Mar 2022 07:21:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEC1A5642A; Mon, 28 Mar 2022 04:19:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21BE061147; Mon, 28 Mar 2022 11:19:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD0FDC36AE3; Mon, 28 Mar 2022 11:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648466343; bh=W/lcVOcoPY+v/WrwziGHG8JE2ki8hpSfLXopMnCP2oA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u1UEUseNxD/w8t/BS4gCojvIqc8pckrrYHuBl267jYbqQzvOXk+B+/5RfLi+QCXqW G0SGC0ptHBWFj4tWjI67zR7QPpAJ+xS+YVIpZeRVNvX9tZ8TmbHhufimTVBuIwCkjW uFCFmsLXiXVWAvQBRZHxa4foeDfj3sv13nh3z3kP63S0UpzecYfvG7WF7iat179agW EM52oundRWFunvGZMozUTUanMxyQwGS2bVpF3GnKDng9FEvS6xF6jiXEMzbpwoJZfp cXGlExspMXaHR7lZp1OM5KBe7AwvbbreZ+S1JBLzztkPso/JEgvX4Sbk/HVweJFfua kVYPVfOcAAI8g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Daniel Lezcano , Ulf Hansson , Sasha Levin , daniel.lezcano@kernel.org, rafael@kernel.org, linux-pm@vger.kernel.org Subject: [PATCH AUTOSEL 5.17 19/43] powercap/dtpm_cpu: Reset per_cpu variable in the release function Date: Mon, 28 Mar 2022 07:18:03 -0400 Message-Id: <20220328111828.1554086-19-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220328111828.1554086-1-sashal@kernel.org> References: <20220328111828.1554086-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Lezcano [ Upstream commit 0aea2e4ec2a2bfa2d7e8820e37ba5b5ce04f20a5 ] The release function does not reset the per cpu variable when it is called. That will prevent creation again as the variable will be already from the previous creation. Fix it by resetting them. Signed-off-by: Daniel Lezcano Reviewed-by: Ulf Hansson Link: https://lore.kernel.org/r/20220130210210.549877-2-daniel.lezcano@linaro.org Signed-off-by: Sasha Levin --- drivers/powercap/dtpm_cpu.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c index b740866b228d..1e8cac699646 100644 --- a/drivers/powercap/dtpm_cpu.c +++ b/drivers/powercap/dtpm_cpu.c @@ -150,10 +150,17 @@ static int update_pd_power_uw(struct dtpm *dtpm) static void pd_release(struct dtpm *dtpm) { struct dtpm_cpu *dtpm_cpu = to_dtpm_cpu(dtpm); + struct cpufreq_policy *policy; if (freq_qos_request_active(&dtpm_cpu->qos_req)) freq_qos_remove_request(&dtpm_cpu->qos_req); + policy = cpufreq_cpu_get(dtpm_cpu->cpu); + if (policy) { + for_each_cpu(dtpm_cpu->cpu, policy->related_cpus) + per_cpu(dtpm_per_cpu, dtpm_cpu->cpu) = NULL; + } + kfree(dtpm_cpu); } -- 2.34.1