Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 28 Mar 2022 16:41:07 +0200
From:   Fabien Parent <fparent@baylibre.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195
 Demo board
Message-ID: <20220328144107.ed4xwzuiezzixqrx@radium>
References: <20220327200312.3090515-1-fparent@baylibre.com>
 <20220327200312.3090515-3-fparent@baylibre.com>
 <94d231cf-ce4c-22f5-b9af-41ae68f1e659@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="xajkuje6fmke6plh"
Content-Disposition: inline
In-Reply-To: <94d231cf-ce4c-22f5-b9af-41ae68f1e659@collabora.com>
Precedence: bulk


--xajkuje6fmke6plh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 28, 2022 at 03:47:09PM +0200, AngeloGioacchino Del Regno wrote:
> Il 27/03/22 22:03, Fabien Parent ha scritto:
> > Add basic device-tree for the MT8195 Demo board. The
> > Demo board is made by MediaTek and has a MT8195 SoC,
> > associated with the MT6359 and MT6360 PMICs, and
> > the MT7921 connectivity chip.
> >=20
> > The IOs available on that board are:
> > * 1 USB Type-C connector with DP aux mode support
> > * 1 USB Type-A connector
> > * 1 full size HDMI RX and 1 full size HDMI TX connector
> > * 1 uSD slot
> > * 40 pins header
> > * SPI interface header
> > * 1 M.2 slot
> > * 1 audio jack
> > * 1 micro-USB port for serial debug
> > * 2 connectors for DSI displays
> > * 3 connectors for CSI cameras
> > * 1 connector for a eDP panel
> > * 1 MMC storage
> >=20
> > This commit adds basic support in order to be able to boot.
> >=20
> > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > ---
> > v2:
> >   * remove empty i2c nodes
> >   * remove empty spi node
> >   * remove unused pcie pinctrls
> >   * fixup node nodes to not contains underscore
> >   * rename mt6360 pmic node
> >   * move mmc1 node right after mmc0 node
> >   * use generic node name for gpio-keys
> >   * uniformize pinctrl node names
> >=20
> >   arch/arm64/boot/dts/mediatek/Makefile        |   1 +
> >   arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 447 +++++++++++++++++++
> >   2 files changed, 448 insertions(+)
> >   create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-demo.dts
> >=20
>=20
> ..snip..
>=20
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts b/arch/arm64/=
boot/dts/mediatek/mt8195-demo.dts
> > new file mode 100644
> > index 000000000000..d94b4e01159a
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
> > @@ -0,0 +1,447 @@
>=20
> ..snip..
>=20
> > +
> > +	gpio-keys {
> > +		compatible =3D "gpio-keys";
> > +		input-name =3D "gpio-keys";
> > +		pinctrl-names =3D "default";
> > +		pinctrl-0 =3D <&gpio_keys_pins>;
> > +
> > +		key-0 {
>=20
> key-volup is more descriptive, can you please change that?

Which review should I follow, yours or the one from Krzysztof? Because both=
 reviews are contradictory

>=20
> > +			gpios =3D <&pio 106 GPIO_ACTIVE_LOW>;
> > +			label =3D "volume_up";
> > +			linux,code =3D <KEY_VOLUMEUP>;
> > +			wakeup-source;
> > +			debounce-interval =3D <15>;
> > +		};
> > +	};
> > +};
> > +
>=20
> ..snip..
>=20
> > +
> > +&pmic {
> > +	interrupt-parent =3D <&pio>;
> > +	interrupts =3D <222 IRQ_TYPE_LEVEL_HIGH>;
>=20
> I would instead use interrupts-extended here:
>=20
> 	interrupts-extended =3D <&pio 222 IRQ_TYPE_LEVEL_HIGH>;

Thanks, it will be fixed in v3.

>=20
> > +};
> > +
> > +&i2c6 {
> > +	clock-frequency =3D <400000>;
> > +	pinctrl-0 =3D <&i2c6_pins>;
> > +	pinctrl-names =3D "default";
> > +	status =3D "okay";
> > +
> > +	mt6360: pmic@34 {
> > +		compatible =3D "mediatek,mt6360";
> > +		reg =3D <0x34>;
> > +		interrupt-controller;
> > +		interrupt-parent =3D <&pio>;
> > +		interrupts =3D <101 IRQ_TYPE_EDGE_FALLING>;
>=20
> Same here

Thanks, it will be fixed in v3.

>=20
> > +		interrupt-names =3D "IRQB";
> > +
>=20
> ...snip...
>=20
> > +
> > +&pio {
> > +	mmc0_default_pins: mmc0-default-pins {
> > +		pins-cmd-dat {
> > +			pinmux =3D <PINMUX_GPIO126__FUNC_MSDC0_DAT0>,
> > +				 <PINMUX_GPIO125__FUNC_MSDC0_DAT1>,
> > +				 <PINMUX_GPIO124__FUNC_MSDC0_DAT2>,
> > +				 <PINMUX_GPIO123__FUNC_MSDC0_DAT3>,
> > +				 <PINMUX_GPIO119__FUNC_MSDC0_DAT4>,
> > +				 <PINMUX_GPIO118__FUNC_MSDC0_DAT5>,
> > +				 <PINMUX_GPIO117__FUNC_MSDC0_DAT6>,
> > +				 <PINMUX_GPIO116__FUNC_MSDC0_DAT7>,
> > +				 <PINMUX_GPIO121__FUNC_MSDC0_CMD>;
> > +			input-enable;
> > +			drive-strength =3D <MTK_DRIVE_6mA>;
> > +			bias-pull-up =3D <MTK_PUPD_SET_R1R0_01>;
> > +		};
> > +
> > +		pin-clk {
>=20
> This is supposed to be "pins-clk", not "pin-clk"... same for all the other
> instances of the "pin-".

There is only one pin in that node, so it should be singular, no?

>=20
> Before pushing patches upstream, please run dtbs_check, as these are all
> mistakes that will be pointed out by that.
>=20
> Regards,
> Angelo
>=20

--xajkuje6fmke6plh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEQyJHfU3UNW7IG61XVJKc6g3CeAAFAmJByQIACgkQVJKc6g3C
eABNUg/7Befzz/j+X7NeVFnAtAEQJXYJp//BfXgdGIobco+gZfUKhfUWfETWso/X
W/XkRDtA5Fslnw0dUDo4mxP8uLWNZmqgxcx+4ScM4bEqFqxk4gv1BHSxpQxHIkaJ
OPraNE72+uQneXV3ZaXFI7R6DxZWZPxi1r6aQ7mdxb27/JAKUEnc7IqxSfdcWOVi
3qidD/W8f0dtZy68C1M/6+Pok0O0RO6Z1yO2/BHKLEgSFxWfM6xUId6fKhKu2IIl
EKy+Hc/O50lBp3HrU00ux7G7jYwud/c4jxXUH9m2J5k1acb/MTCilKAUoAIJSvwz
qpI71IarL2V6gEettEGEQ2GpKoTYLRQ7Hu6YCoN05EtKh8MH9l/qECwUIRJ2pgKp
Q8ptn8Qa4ScEcZyKeITwapWIlUmli81sVbo3OUXXYcJneFd8b3mlI+zFAxnBkiqb
wOatUg4tEdc1cTfv0UzZXQ8u2NPMvggLBQNWlPfMX+mn4RkQSfXPDkQu/MvF7ePd
NbWZ9jW7CE1YJ9R9VdpazWOKf3h9Pq2QahjrR3fINW9p2NyIpLz7STd5/I4yj/Dh
7zSqzaQlKew9+xRY7aOK6eOfXsxbHuSY994xLmN87gNY5qWhdNUuJLTGgfjZyW8/
eRcqNr9lhZZdqi8p8xE4lIFSonBzdUPRFGlBjorMc00EcQKCoX8=
=tvKe
-----END PGP SIGNATURE-----

--xajkuje6fmke6plh--