Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp5652998pxb; Mon, 28 Mar 2022 15:32:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHohgCDls5p07jCWE/KAjx2uVDAse4Ew9VkKG9cwj8emOvVMI8OFHaWCS2lAPbAVWYT9jF X-Received: by 2002:a05:6870:d211:b0:de:4e33:1717 with SMTP id g17-20020a056870d21100b000de4e331717mr680627oac.286.1648506764828; Mon, 28 Mar 2022 15:32:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648506764; cv=none; d=google.com; s=arc-20160816; b=G2TziC1pw025Dw29GYXArvuouRZoUWC7CLnLho3m/kp3D7lPzeb5EldWetMeC67gPh w2N+E+wkprX5/FDBwKtmCrjyy0Knrm/ay3f3EFTvTp1hWTCtf4gxo+5QPwrnyI0i+RqK Qkj/8I/Kou8hBhhjP2XWvZ8Qvdt08eFJ9HPAyxJAGOAxesbcMGj5E9Gygde++MbT3BO0 PhU9QMwxBpx71jO3v4/gP9VxvhqiGvbupRv/yC0sHWrrqyEqQLEQmpCbT9onSeA/sQGf KWtsiaVfgQHI+fhmmtDTbck0EPQ4jRSjrPY9ThSzp63ctGClkMpxjsX1jb26rA5JUpxy lfuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=Dbgc6/dIoGYhBdhIbPzmzSMnuOn91k3d9y6pTYpNWJk=; b=Yc2w9DpdicwSrBIpscKia1fhZCW2CmcvHjVNtBSshCwWB6oruyc3lj0tQzP/UdF55r rFurE9urDQQTrh6C63MgSfvG76Br5VBNmxrZflCuuxfFRufc8uJZRaoCEreQkodw4+JB +LzwNAb3iJu/nL2CoEmyWrHCu9oQKWexh5evOIX/y0VX98PEnxNUepjP1VnwbgjIvygB CpU/jzGvKyAceMEMPIH+kyNmPdlHzn6znwxAu/cCN3V2RSSdtvEYy1GFh2x6z2acLy6T 8KiAMxa+GinwDRyxoCRtBZwefUUvIRE0m0S3IG+pzQ6/9DHGas5mlG6nuJmw7Xp3cd2u ZI+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baikalelectronics.ru header.s=mail header.b=oSHtuRxH; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id r1-20020a056830134100b005cb2fc1383esi11429515otq.186.2022.03.28.15.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 15:32:44 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@baikalelectronics.ru header.s=mail header.b=oSHtuRxH; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 999671D4198; Mon, 28 Mar 2022 14:44:03 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244339AbiC1PLN (ORCPT + 99 others); Mon, 28 Mar 2022 11:11:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244275AbiC1PKv (ORCPT ); Mon, 28 Mar 2022 11:10:51 -0400 Received: from mail.baikalelectronics.ru (mail.baikalelectronics.com [87.245.175.226]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 283615FF30; Mon, 28 Mar 2022 08:09:11 -0700 (PDT) Received: from mail.baikalelectronics.ru (unknown [192.168.51.25]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 932E01D5AB0; Thu, 24 Mar 2022 04:25:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.baikalelectronics.ru 932E01D5AB0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baikalelectronics.ru; s=mail; t=1648085132; bh=Dbgc6/dIoGYhBdhIbPzmzSMnuOn91k3d9y6pTYpNWJk=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=oSHtuRxHXPHxaJYdDuGrLKof+OUuE1wf4y2oQ6le7umJJbexr9KnaM2H2OBo8EFVF 4I18HyCI27utupWHbZr74kpLeGNjWZirXOsYNzXHZ9lVncnTJezlSh32FFbUidrwRf A+wtAaKv3qcIP2tz+dIZ0z8rAhbi+6vFGPuo5eBY= Received: from localhost (192.168.168.10) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 24 Mar 2022 04:25:32 +0300 From: Serge Semin To: Jingoo Han , Gustavo Pimentel , Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Frank Li , Manivannan Sadhasivam , , Subject: [PATCH 07/12] PCI: dwc: Add trailing new-line literals to the log messages Date: Thu, 24 Mar 2022 04:25:18 +0300 Message-ID: <20220324012524.16784-8-Sergey.Semin@baikalelectronics.ru> In-Reply-To: <20220324012524.16784-1-Sergey.Semin@baikalelectronics.ru> References: <20220324012524.16784-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are two places in the DW PCIe controller driver, which omit the trailing newlines in the log info and warn messages. Not having them there will cause leaving the messages in the printk ring buffer until a next '\n'-terminated message is printed (it will consequently cause the buffer flush). As it isn't what the corresponding code implies let's add the new-line characters in the messages. Signed-off-by: Serge Semin --- drivers/pci/controller/dwc/pcie-designware-host.c | 2 +- drivers/pci/controller/dwc/pcie-designware.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index a048d88e0c30..8364ea234e88 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -657,7 +657,7 @@ void dw_pcie_setup_rc(struct pcie_port *pp) } if (pci->num_ob_windows <= atu_idx) - dev_warn(pci->dev, "Resources exceed number of ATU entries (%d)", + dev_warn(pci->dev, "Resources exceed number of ATU entries (%d)\n", pci->num_ob_windows); } diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c index 9f4d2b44612b..3bd1cfd12148 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -706,7 +706,7 @@ void dw_pcie_iatu_detect(struct dw_pcie *pci) dev_info(pci->dev, "iATU unroll: %s\n", pci->iatu_unroll_enabled ? "enabled" : "disabled"); - dev_info(pci->dev, "Detected iATU regions: %u outbound, %u inbound", + dev_info(pci->dev, "Detected iATU regions: %u outbound, %u inbound\n", pci->num_ob_windows, pci->num_ib_windows); } -- 2.35.1