Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <f74aa70e-8222-12fc-b44a-880865c9badd@vrvis.at>
Date:   Mon, 28 Mar 2022 17:06:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Justin Sanders <justin@coraid.com>,
        Jens Axboe <axboe@kernel.dk>
Content-Language: en-US
To:     Christoph Hellwig <hch@infradead.org>
References: <07bafc71-a6d2-ad6d-4706-7c99047b3228@vrvis.at>
 <YioZaO21yingv0nD@infradead.org>
From:   Valentin Kleibel <valentin@vrvis.at>
In-Reply-To: <YioZaO21yingv0nD@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] block: aoe: handle device timeouts atomic-safe
Precedence: bulk

On 10/03/2022 16:29, Christoph Hellwig wrote:
> On Thu, Mar 10, 2022 at 04:17:37PM +0100, Valentin Kleibel wrote:
>> If an aoe device does not respond to any packet on the network layer within
>> aoe_deadsecs, the driver tries to mark the device as down, fail all I/O and
>> clean out the queue.
> 
> I think the problem is that aoe even tries to queue up request
> internally. It really needs to switch to use BLK_MQ_F_BLOCKING and
> stop queuing up the requests internall at all.

Unfortunately I'm not able to assess this.
It would be a more complicated change than I'd be able to provide and 
the proposed patch fixes the existing issue.

Cheers,
Valentin