Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Xiaomeng Tong <xiam0nd.tong@gmail.com>
To:     guoqing.jiang@linux.dev
Cc:     linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
        rgoldwyn@suse.com, song@kernel.org, stable@vger.kernel.org,
        xiam0nd.tong@gmail.com
Subject: Re: [PATCH] md: md2: fix an incorrect NULL check on list iterator
Date:   Mon, 28 Mar 2022 15:56:28 +0800
Message-Id: <20220328075628.25545-1-xiam0nd.tong@gmail.com>
In-Reply-To: <bdc2ed02-6f13-c8a5-7e61-190a5dd9b6bc@linux.dev>
References: <bdc2ed02-6f13-c8a5-7e61-190a5dd9b6bc@linux.dev>
Precedence: bulk

> I'd suggest to rephrase the subject to "md: fix an incorrect NULL check 
> in md_reload_sb".

Thank you for the suggestion, i will take it in PATCH v2.

> > -	if (!rdev || rdev->desc_nr != nr) {
> > +	if (!rdev) {
> >   		pr_warn("%s: %d Could not find rdev with nr %d\n", __func__, __LINE__, nr);
> >   		return;
> >   	}
> 
> I guess we only need to check desc_nr since rdev should always be valid 
> , and IMO the fix tag
> is not necessary.

No. At least from the pr_warn log, the list can be empty or no element found in it.
If this cases happen, the 'rdev' will be an invalid pointer that point to a invalid
struct containning the HEAD '&((mddev)->disks)'. So this fix is necessary.

--
Xiaomeng Tong