Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 28 Mar 2022 21:01:08 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Linus Torvalds <torvalds@linux-foundation.org>,
        Jean Delvare <jdelvare@suse.de>
Cc:     linux-i2c@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Peter Rosin <peda@axentia.se>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Terry Bowman <terry.bowman@amd.com>
Subject: Re: [PULL REQUEST] i2c for v5.18
Message-ID: <YkIF9OqbZQ8yinz8@ninjato>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jean Delvare <jdelvare@suse.de>, linux-i2c@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Peter Rosin <peda@axentia.se>, Bartosz Golaszewski <brgl@bgdev.pl>,
        Terry Bowman <terry.bowman@amd.com>
References: <Yj19RH3qpzQsIV/O@shikoro>
 <CAHk-=wgoeUc15-8Wu8U=4FnwhgmyU3C13R107oigbmJRpi_sZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="E7iTNvwRJK4hNqtW"
Content-Disposition: inline
In-Reply-To: <CAHk-=wgoeUc15-8Wu8U=4FnwhgmyU3C13R107oigbmJRpi_sZA@mail.gmail.com>
Precedence: bulk


--E7iTNvwRJK4hNqtW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 26, 2022 at 12:58:36PM -0700, Linus Torvalds wrote:
> On Fri, Mar 25, 2022 at 1:28 AM Wolfram Sang <wsa@kernel.org> wrote:
> >
> > I2C has for 5.18: tracepoints when Linux acts as an I2C client, added
> > support for AMD PSP, whole subsytsem now uses generic_handle_irq_safe(),
> > piix4 driver gained MMIO access enabling so far missed controllers with
> > AMD chipsets, plus a bulk of device driver updates, refactorization, and
> > fixes.
>=20
> It feels odd/wrong to use the piix4 driver for the AMD MMIO case on SB800.
>=20
> Would it not have made more sense to just make that a separate driver?
>=20
> It feels like now the piix4 driver has a lot of "if SB800" for the
> probing code, and then a lot of "if (mmio)" at runtime.
>=20
> I've pulled this, but just wanted to mention this "that looks a bit
> odd". How much code is actually _shared_ in the SB800 case?
>=20
> I'm not insisting on splitting this up - maybe it all makes sense. I'm
> just questioning it.

Adding Jean to CC, he maintains the PC-style drivers.


--E7iTNvwRJK4hNqtW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmJCBe4ACgkQFA3kzBSg
KbbCFg/6Auuw5ANAZruLaiGI24QQzxC6+s6g3SKjue4LQeR8iw07tnPpulI56ugn
aZo3JTe8+/LJEcVFZokMPhQs6KH3qiByWj1J2BTWRu6Q1DJm7P8QsM/6ouHh0N+l
llI9p+Qdav9dhFcbrl0pjdEh/WrNnqYsUxnplY77cxFdQjV7j1U5oZbnseg91fZF
pAMfLADhqCUJVwvh3v4kQ7CUDgM5800zc2C6Eq7btiU8Fh9uKbDNkhprc+lNpg0y
kXY/3sAdhWZmxBuZXAUh2HumVNggOTOf6Svk76iJ2YoK1slp34C5YuP/Z4jsvhEY
zCwuGPdAVezo59pXe2s19qG5f49jEiO777s47UgZeK4nSSj2RUqTF1L5bF5UF4AI
H58A7ohnZ5SLEyDfvJ1HWQHB+RmUU3bRvSGHtP62cTnIdZqeGxoZtOo8FPupQ2+C
ZgRLdE4sKI6Sh2u/dt1VDuXXZFP95uTG/DHhQwgsHFHfaSdUDMvAmxSYMejfOv8s
+ua1mUF1mkNiR719ksAdgaWr2IMMB9726G6PdBnywSHnb6kUCeKioBg8GBp377t4
l2mXgzvW5OEyLorRE/db0hGmybhTjQ5TjCIaLa6iX03n6IO5Iu6Ji1YLI+1HUzwa
WiAvmsykMIe8m6/0uxk23YOc64bJT/rLS4ufNYr9am4wEtZ38RE=
=XFSv
-----END PGP SIGNATURE-----

--E7iTNvwRJK4hNqtW--