Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 28 Mar 2022 16:06:53 -0500
From:   Paul Lemmermann <thepaulodoom@thepaulodoom.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] IIO: accel: fixed coding style issues
Message-ID: <YkIjbdICfxBZx3qf@hp-amd-paul>
References: <YkHOpCT2Gad1YaxN@hp-amd-paul>
 <CAHp75Vf7R2=m7apZfXkY9-nETNiG7n6oXpivBg-56Wguzx2+8A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75Vf7R2=m7apZfXkY9-nETNiG7n6oXpivBg-56Wguzx2+8A@mail.gmail.com>
Precedence: bulk

On Mon, Mar 28, 2022 at 11:32:44PM +0300, Andy Shevchenko wrote:
> On Mon, Mar 28, 2022 at 7:45 PM Paul Lemmermann
> <thepaulodoom@thepaulodoom.com> wrote:
> >
> > Fixed case statement issues and spacing issues.
> 
> ...
> 
> >                         switch (val[j]) {
> > -                       case -1: str = "-1"; break;
> > -                       case 0:  str = "0";  break;
> > -                       case 1:  str = "1";  break;
> > -                       default: goto unknown_format;
> > +                       case -1:
> > +                               str = "-1";
> > +                               break;
> > +                       case 0:
> > +                               str = "0";
> > +                               break;
> > +                       case 1:
> > +                               str = "1";
> > +                               break;
> > +                       default:
> > +                               goto unknown_format;
> >                         }
> 
> What you cited from documentation mostly affects the new code, but
> this code is already in the kernel and modifying it, esp. taking into
> account 3x LOCs count, looks like an unneeded churn, even if
> documentation thinks otherwise.
> 
> What I could acknowledge from your proposal is the default case.
> Otherwise just leave it to the point if we touch this code for
> something else in the future.
> 
> ...
> 
> >  static const struct of_device_id kxsd9_of_match[] = {
> > -        { .compatible = "kionix,kxsd9" },
> > -        { },
> > +       { .compatible = "kionix,kxsd9" },
> 
> > +       { },
> 
> I dunno why you touched this line (likely TABs vs. spaces), but please
> remove the comma as well here.

Yes, that is exactly why this patch exists.

Thank you, I will take these thoughts into account and submit a new
patch.

Thanks!
Paul
> 
> >  };
> 
> -- 
> With Best Regards,
> Andy Shevchenko