Received: by 2002:a05:6512:2355:0:0:0:0 with SMTP id p21csp5528485lfu; Mon, 28 Mar 2022 16:02:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoOn2opO0lTILLDR0aUEZ2iZbaTXsWM0QQ0MyT6fraLJBZbl+M1rG+dwqwRLMDVTn3X09P X-Received: by 2002:a05:6214:2349:b0:439:9e84:eb21 with SMTP id hu9-20020a056214234900b004399e84eb21mr23300072qvb.78.1648508566912; Mon, 28 Mar 2022 16:02:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648508566; cv=none; d=google.com; s=arc-20160816; b=K/V4jT74uq5k8XdhPCRGUpHFCJXqnhf6AJIMOfogLQm5vaynsqDK6ReMbH6ThLsX/A oG3+thot/RcpMoS3vdDSmNBGCxlCQo2XBAsSklGlXmIsXZj6oEwwc8WoyV/tP9tP2tRj ORTBIZ/kiPZ1+pfKoRAGUKmpdWdz+25/g5FVwbeL1rJpI5F6vgKFkdR0Ja8tXRsmd/am KmL6rOFIj3ayNVUMN41hs3TPDdHM7mVnXmEph44VzfBeikJPmVktw1xQM8Izzk42MBUH 4+cpF+wAi4/BCHvAS/bFxiDQP8idBMVer0qBxYbclANGliTsslB8LF77nOr3GXqiKtR5 RSow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=jOAa7WpMNgbqgji3fRQGom5Ba+QYEkdDzROArpIBjvc=; b=vdiM6X/uRabTuZBUwQD3csrS+1iJPfxTokh72P+IjmP5y6sRS6vzKHQ37ZHPhBPcWr KJKQeoTi0It5sv46tIKbPcHia4gBluJU4IeMgNKpnIc57xxl2Q3mIr86qbv41cJBHX5X 3ltWkL+hRkoUuOkOt0ZnYwi81JzgIXUFBl0wH13IxnscS3kebDtU5iLVQHyZb8PcMnLd wfKUmGAv0Ra/z5/WhK3gIip+BoJ3mz/6KFUrJ/bgrkcl8zPUbJmyHrPegkJ9H6iBnRUU G09jAKfi7ve0H0q2evOFJtAuAtjvUzEPlp+mU73l1A/zRvZx55mMpwAiuy3IO1a0SCHv +XYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ENw5v98d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id x15-20020a67c08f000000b00325577dd2a0si3536921vsi.600.2022.03.28.16.02.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 16:02:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ENw5v98d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3BFF72A85EF; Mon, 28 Mar 2022 15:08:48 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243817AbiC1RIX (ORCPT + 99 others); Mon, 28 Mar 2022 13:08:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233834AbiC1RIW (ORCPT ); Mon, 28 Mar 2022 13:08:22 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E439562BCC for ; Mon, 28 Mar 2022 10:06:40 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id e16so25847687lfc.13 for ; Mon, 28 Mar 2022 10:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jOAa7WpMNgbqgji3fRQGom5Ba+QYEkdDzROArpIBjvc=; b=ENw5v98dathuIv0v3Q532b+NqOLHiJ3fyUjwxxYyseIx+Nx5kyLtsaLjIcefkdeNL9 IS6mlD38Idl9cNFzUflS7/2bSe2H7jFluyt13j3tgOhoffcXGXLpz23Ge1bsEIbDnUbs uddK+qnZk5D44idwiIMTVrkTNlCVx83nc1JIxtSICXQJtfnKuLN4r5aFF3zd4PP2jBR+ W5DUogc99JJoE1vCVXg6EKYnkXel5NSQI4bV+tkaNEPPGtApavU02ID1WMvX5Qufg8y0 PzzkYtZ72vpzJUSjqofTtQk6sJM5nkuZBHNUjZ26vrcxREbqZBunnlsTnWE/4lXHcsYR zFXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jOAa7WpMNgbqgji3fRQGom5Ba+QYEkdDzROArpIBjvc=; b=ZhoWEQEpu6Tc071Vhz7+kksuHGaCUxdyIiJBwP0Jg+9KXw0k/z3KUE+lJAmwAIXWJO 8t4wPDadzoo6Mu/LhsGHIfxhmKKktzYRyWgy3R5nTO8VpRupZXJlWjrzhyrb8Xq0H9QF +P6SybiYB2xpcqwHcdrADdQLe7eu+lrx+iS9IBuwPgNx3h/DrHx+pGKE8AjK7h1wCIA+ NqCptXiIkNT00FrJKLDjtXVBbPckyb5/y1U1uDUnBe61pLg2mXFhRY85okTW4Iw41alA H1FQ30+5xNSk8+oE8vPh1+agLfb2Lyk54uolQDgc9YbRcUiED7j32kYG9rPzkYsTZlh1 CfVg== X-Gm-Message-State: AOAM532DOLyUhOOH2RTKe79sTZw40nwuVHnuYjt6iMBolMyQKTDFRLDr 9uC6TCM6t/CiG5lX2VaRgMjt4vFZN0Fa+cVa1c4V0dmQscdrhA== X-Received: by 2002:a17:907:d06:b0:6e0:e2f5:4f55 with SMTP id gn6-20020a1709070d0600b006e0e2f54f55mr13018196ejc.618.1648486724923; Mon, 28 Mar 2022 09:58:44 -0700 (PDT) MIME-Version: 1.0 References: <20220326002013.483394-1-dlatypov@google.com> <20220326002013.483394-2-dlatypov@google.com> In-Reply-To: <20220326002013.483394-2-dlatypov@google.com> From: Brendan Higgins Date: Mon, 28 Mar 2022 12:58:33 -0400 Message-ID: Subject: Re: [PATCH v2 2/2] kunit: split resource API impl from test.c into new resource.c To: Daniel Latypov Cc: davidgow@google.com, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 25, 2022 at 8:20 PM Daniel Latypov wrote: > > We've split out the declarations from include/kunit/test.h into > resource.h. > This patch splits out the definitions as well for consistency. > > A side effect of this is git blame won't properly track history by > default, users need to run > $ git blame -L ,1 -C13 lib/kunit/resource.c > > Signed-off-by: Daniel Latypov Reviewed-by: Brendan Higgins