Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 28 Mar 2022 23:38:17 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Kees Cook <keescook@chromium.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [GIT PULL] pin control bulk changes for v5.18
Message-ID: <YkIqyb6lhn5uU2jb@latitude>
References: <CACRpkdZ_Jr3OzfoOpSSsAJMy1Oe_=zD861jouDzCVD-BQ6yZMg@mail.gmail.com>
 <CAHk-=whzqAB6kfHUcX2uhfPnNiWJRq=UmeA1TbgGi3XA+57j3w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yvrgZB0uozz8tcri"
Content-Disposition: inline
In-Reply-To: <CAHk-=whzqAB6kfHUcX2uhfPnNiWJRq=UmeA1TbgGi3XA+57j3w@mail.gmail.com>
Precedence: bulk


--yvrgZB0uozz8tcri
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Mar 28, 2022 at 12:11:49PM -0700, Linus Torvalds wrote:
> On Mon, Mar 28, 2022 at 6:08 AM Linus Walleij <linus.walleij@linaro.org> =
wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git
> > tags/pinctrl-v5.18-1
>=20
> Hmm.
>=20
> This clashes badly with the fact that we in the meantime have enabled
> -Warray-bounds, and I got
>=20
>   drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c: In function =E2=80=98npcmgpi=
o_irq_handler=E2=80=99:
>   ./include/linux/find.h:40:23: error: array subscript =E2=80=98long unsi=
gned
> int[0]=E2=80=99 is partly outside array bounds of =E2=80=98u32[1]=E2=80=
=99 {aka =E2=80=98unsigned
> int[1]=E2=80=99} [-Werror=3Darray-bounds]
>      40 |                 val =3D *addr & GENMASK(size - 1, offset);
>         |                       ^~~~~
>   drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c:219:13: note: while
> referencing =E2=80=98sts=E2=80=99
>     219 |         u32 sts, en, bit;
>         |             ^~~
>=20
> as a result.
>=20
> Was this not in linux-next?

It was =E2=80=94 but when it was noticed, the fix went through the IRQ tree=
, on
top of a refactoring that happened there (the switch to generic_handle_doma=
in_irq):

https://lore.kernel.org/lkml/164751044707.389.16417510835118111853.tip-bot2=
@tip-bot2/

So=E2=80=A6 the issue should resolve itself when the IRQ tree is pulled.

> Or was the array bounds checking not there?
>=20
> Anyway, that cast to "const void *"
>=20
>      for_each_set_bit(bit, (const void *)&sts,
>=20
> in that driver is completely wrong.
>
> The bit operations are defined in arrays of 'unsigned long', and you
> can't just cast the issue away, because the end result is not the same
> on a big-endian machine.
>=20
> I fixed it up in the merge, but what really confuses me (apart from
> the apparent lack of testing in linux-next) is that I don't actually
> see what made this happen now, and not before. Maybe that's why it
> didn't show up in linux-next: it's some odd gcc heisenbug.
>=20
> Because there seems to be no actual changes to that driver that would
> explain why I get the warning now, but not before the pull.

When I added the pinctrl-wpcm450 driver, I changed the pinctrl/nuvoton/
directory to obj-y and exposed the pinctrl-npcm7xx to CI bot testing.
The bug existed, untouched, since the driver was added a few years ago.


Jonathan

--yvrgZB0uozz8tcri
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmJCKqgACgkQCDBEmo7z
X9tAfRAA0Lwv6e2tpRvOKaLo/Ou9kPLpQCasdBSh/IgzKFoVlMsZmfGNbBZqU/bv
dy6/AoTuVnwXRAJt7QM9MPd1N8ekXnMT0VMZOh+4hhBLhN8lAsB2fNaFCcjTNeA/
IxgTx1zqzdpjgQq7vWzX3om1graLj9OV4E59sD4Dl9/jeXP5ESz71yaq4WEYFW25
nxPnj6OxXhlS5CEkOVIUUO7mGzlv6a8+rtcU7tjXeNmZ1QlLZ/jhaOEo0tbPn2Gv
AmDDscAS8olaFCHdcMWAP+YFbFD6sjWBzkBuCETk2CX3YnJuITMQsjjyUvEva/Hm
aAgOQf+bZBRgcVnS1hI+RH1zpq5ahrNtXbAbMrGqSbMMaI/6VyPdsJyf3LXA6/id
bp6zNuwSGber0yU2YFGtvNFKx7e5tBGuckNebu/E/VFQAwwB0jwSpK/pifWt3p3i
LVbcOcauLddSQqUlejjs/buMOrSt+lWzhIY0m1ZuC6xqyCm1/LJz2LwoLMAfw0gi
IEj93h+SzT5X+zeNuNojxCVaxuEa+DJdTTrA58ztzI5f8Hwy7D2Hq4JmrAQiJM+z
v44tGk+W9ye8ONaQ2lL02oFDHgfic1QN0uJzflU7bpFY9EEqsGWps9GweMeYr7LD
HIJrALebsg5geI0gKyAAf6gwWgF/GREiqF45IxuK5fdrc4enmRI=
=gFUj
-----END PGP SIGNATURE-----

--yvrgZB0uozz8tcri--