Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <9b799a29ec8bc87386bc370a03a11b33ac948209.camel@kernel.org>
Subject: Re: [PATCH v2] ceph: remove unused CEPH_MDS_LEASE_RELEASE related
 code
From:   Jeff Layton <jlayton@kernel.org>
To:     xiubli@redhat.com
Cc:     idryomov@gmail.com, vshankar@redhat.com,
        ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 28 Mar 2022 17:41:37 -0400
In-Reply-To: <20220328131026.923174-1-xiubli@redhat.com>
References: <20220328131026.923174-1-xiubli@redhat.com>
Content-Type: text/plain; charset="ISO-8859-15"
User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2022-03-28 at 21:10 +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
> 
> ceph_mdsc_lease_release was removed by commit 8aa152c77890 (ceph:
> remove ceph_mdsc_lease_release). ceph_mdsc_lease_send_msg will never
> call this function with CEPH_MDS_LEASE_RELEASE.
> 
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
>  fs/ceph/mds_client.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 459c6f23915f..a89ee866ebbb 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -4424,12 +4424,6 @@ void ceph_mdsc_lease_send_msg(struct ceph_mds_session *session,
>  	memcpy((void *)(lease + 1) + 4,
>  	       dentry->d_name.name, dentry->d_name.len);
>  	spin_unlock(&dentry->d_lock);
> -	/*
> -	 * if this is a preemptive lease RELEASE, no need to
> -	 * flush request stream, since the actual request will
> -	 * soon follow.
> -	 */
> -	msg->more_to_follow = (action == CEPH_MDS_LEASE_RELEASE);
>  
>  	ceph_con_send(&session->s_con, msg);
>  }

Reviewed-by: Jeff Layton <jlayton@kernel.org>