Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <7b7732ec-c7ff-cf92-510f-64c83ed985cd@intel.com>
Date:   Mon, 28 Mar 2022 14:49:04 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH v2 1/2] selftests/sgx: Use rip relative addressing for
 encl_stack
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>
CC:     Dave Hansen <dave.hansen@linux.intel.com>,
        Shuah Khan <shuah@kernel.org>,
        "open list:INTEL SGX" <linux-sgx@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220322074313.7444-1-jarkko@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220322074313.7444-1-jarkko@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEhpcTJIQzdEcWZjMzZxYWhjcnowdzNwZHJpdUZiUkVhSG1BSXF0cVIxbytT?=
 =?utf-8?B?OTJzODJJVi9ZRE1pL2pOU2ppdFBma2FxdWpZRlBhMjVaaUFjbmNaRlZJQ01J?=
 =?utf-8?B?S0NzUUJYNS9CbFdyem1PeUlwWlBhSzhuRS9Ic0ZyUUd5eWFSWXhqRERGY0N0?=
 =?utf-8?B?eUpMSkRNbC9xMElWeUp5cit4bGJ4RjVyZko3QzQ0RjJjUDZxV1krN0psaVFG?=
 =?utf-8?B?TVBRaFJkR24vSlBUM21kdmcvQi94RmtBQmhVNEkwajFJQjhRR0puUlhkRTlF?=
 =?utf-8?B?OExtVnY0WHQ0VmZqK3N5M05XK0tKS1IxNkVMMFlNQnJxYm53TWdoVkFGN041?=
 =?utf-8?B?ZXdkL0ZiczZrSFNSaG4zOUNmYzA4K0dsTVMwK2JzSHdhaWVnbWFzOTlJQlR4?=
 =?utf-8?B?NWthdVBvTDN3SjRTdXVVU2F0Z2NsbUhnRklqRmtBVWhJdXlQUGpXajEwTG1x?=
 =?utf-8?B?RWs4VHliY0R5UnBRTzE1YSsxcHk5YUU2eFRnMXNjLzU2cWFzYmlnSVF2N0dS?=
 =?utf-8?B?UEpvR29PWDJxUGd0OHpja1YreXpZdTZyNG9rRzVmV1VFMUc1Y3I2eXAwL0JP?=
 =?utf-8?B?WXBQR2NOeFNSc0lSVHZGNmc4NGhPeHJPdHhNUkQ5cmpqelY3UWtRMGg4OEQw?=
 =?utf-8?B?RVcrS0RBTXpMa3VqZ0VvUmZxZHNXVzFpdE9UaGhhUkRhVzRNSU1YOWhkR1Bw?=
 =?utf-8?B?Y1BVS2IwcW9KWDRQS0VpNjhSUkF4ampYQmNyaHhwS28yU29wcUMvUHE3QnBG?=
 =?utf-8?B?Y3FCcGRQcEwzSGlUcjllM0dmTi8rbHY0a1dNeWFpYTFWdG5RNWlTMlhjRGpu?=
 =?utf-8?B?enVzb3Jpa01jbTZnYzhydzBEbkFXRDQ0SlF4VEhQWnpKN3FPY01xQnpKWUor?=
 =?utf-8?B?RHp4aUJnRjRaZE90NTJSREpKTEh3OGxOc01yaTJMd2V5N0RQODZ0eFlWS3Rk?=
 =?utf-8?B?dG44NXdKcmZRUG1lOFVSZFp6bWFYd0pWQ2M5NmpNTzl4ZTVpelcwZkJXZ2pS?=
 =?utf-8?B?S0paMC96Y2tDRlNnTFZSN1dmYzhneC95dFlhVnJTRWJQa1hJV3FGaDVibm1n?=
 =?utf-8?B?cjFIUzloeU9BUVNxemYxc0p4WlhNRzkvTkg4Uno1NWtqVjFNeVNzYURlSk1y?=
 =?utf-8?B?d3FrNGpYejRralFUb25WK0JXQi9EUzA2NFJjZHVzY21LNUdrNG55NlNZQUVV?=
 =?utf-8?B?OWNrcFhpVlRzaWdyVDVtSzNydm5tTVB5aTRka2p1VHFxNjlBTzBDZVZVS2FP?=
 =?utf-8?B?L2R5ZDd0dnJ0ellvRDZGaTIyMFJueWR3UWtmUzFzS1RjdnRJR0dQM281dzBP?=
 =?utf-8?B?VWdtUnFSdjBxTTJKYktCeDNCQmMyN1dYOFBJUmpwdUJWVGJicWNaaWRhZmZR?=
 =?utf-8?B?My9tZ0FoU09PUTBqUGdacnFBWDgvUzdxdkV2Zm11dTAwaWx4ZzMvZ29zcXhK?=
 =?utf-8?B?MUxsSFlIa2hISGx1U3U1dHVTNnk0cVJDSGlzbDZzLytNNnFKay9aTXZzZUx0?=
 =?utf-8?B?cm1pT0dMQlZUdW5sdmpLUmxMblB0ekluNlBTRFVHZlJZNEJyQWhrMkw4OU1D?=
 =?utf-8?B?WERtL01YaGRtRDRmVTI0VWVXOVY3aVJub0dTRTIvRmZHdVdXS2VaWGdpb1VI?=
 =?utf-8?B?MUFMYkJ1dUJDaDV1YThra282c281d0tuN3FxODdXbVUrYU9TTEhvbG9kVStB?=
 =?utf-8?B?YmRJNzdEcFk5ZDlsOTFFR29XSmxoMzQ1L0g1cFgyREs4djJ4ZDMrTGRnQjRr?=
 =?utf-8?B?bVJGUDVka1FRajVKNGxKNlBkemV5Y291NStqNmo0UnFFemZHRnEyZFVaSXlV?=
 =?utf-8?B?dDltdDREeXBnRzE3anVPSkFnVXE0WW1ZMlVxQnNpM2VlQlRSQ21IZXlKb09B?=
 =?utf-8?B?VjlXWXo3S1N6ZWwzZktDNVJLYmtEMmlNUkpHaVFtckZCd0ZpMjlLa1VoSzlJ?=
 =?utf-8?B?SjJtL0JpM3pWdE5UZ0dvQVNjMXJGS1kwV2w4VHBnOHBqanMwYmFjTEIzS0hH?=
 =?utf-8?B?ZURvb2ZCU3lDT1ZoZ1ZRd3ZmYlcxS24rNXdwL0RNMXNMbjJLR29qaThNRTV4?=
 =?utf-8?B?ek5RWm1LeFEvSW85cE5zMGlFdTVtc1FzOTVqeTdUM1A0NUtQdDBMU0dNU0Z0?=
 =?utf-8?B?VnAybE5CbVhzaEZ0aXNRaEdGRkhaQThGQXJpZ3NPbWoxaElZVnVKYUZGelZV?=
 =?utf-8?B?TW1GS29md2dVUTc4NU5wOVdDVkUrbnhuZ2RGOVN6VUxDanVnVGc5MFpRSmdo?=
 =?utf-8?B?NDFoNkFRYno3ZFYyN21CbWc0b1Zpa2tHU2JWeTVSNjgxL25TR2U3NzRVMEll?=
 =?utf-8?B?UG85aWVCaVJuRUYxN2lQZEdXMWtxbnBMOFZiejB3RVFVZllkK2VPVUVycDVW?=
 =?utf-8?Q?nK2s3gyfR9mMwb4o=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 29f392fa-e79e-40e6-e2b7-08da1104c975
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2022 21:49:08.6333
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W/+l04TmlRKsgw7qK46qYmoYI7QA3MwdZyTyYQ2R6Oyywqm1dkRv+IH7vWxZCYVneReu786l2FXqgDefzckgwLuodWiO7T4lbex0bHvCkDA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1908
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 3/22/2022 12:43 AM, Jarkko Sakkinen wrote:
> Simplify the test_encl_bootstrap.S flow by using rip-relative addressing.
> Compiler does the right thing here, and this removes dependency on where
> TCS entries need to be located in the binary, i.e. allows the binary layout
> changed freely in the future.
> 
> Cc: Reinette Chatre <reinette.chatre@intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> ---
>  tools/testing/selftests/sgx/test_encl_bootstrap.S | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/tools/testing/selftests/sgx/test_encl_bootstrap.S b/tools/testing/selftests/sgx/test_encl_bootstrap.S
> index 82fb0dfcbd23..1c1b5c6c4ffe 100644
> --- a/tools/testing/selftests/sgx/test_encl_bootstrap.S
> +++ b/tools/testing/selftests/sgx/test_encl_bootstrap.S
> @@ -40,11 +40,7 @@
>  	.text
>  
>  encl_entry:
> -	# RBX contains the base address for TCS, which is the first address
> -	# inside the enclave for TCS #1 and one page into the enclave for
> -	# TCS #2. By adding the value of encl_stack to it, we get
> -	# the absolute address for the stack.
> -	lea	(encl_stack)(%rbx), %rax
> +	lea	(encl_stack)(%rip), %rax
>  	xchg	%rsp, %rax
>  	push	%rax
>  

The goal of the above snippet is to set RSP to ensure that each thread has its own stack.

Since EENTER computes RIP as EnclaveBase + TCS.OENTRY, by using offset from RIP this
would result in all TCS with OENTRY of encl_entry to use the same stack, no?

Could you please consider the following as an alternative:
https://lore.kernel.org/lkml/65c137c875bd4da675eaba35316ff43d7cfd52f8.1644274683.git.reinette.chatre@intel.com/

The idea in that patch is that a new TCS would always need to be accompanied by a
dedicated stack so, at least for testing purposes, the TCS and stack can be dynamically
allocated together with the TCS page following its stack.  This seems much simpler
to me and also makes the following patch unnecessary.

Reinette