Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp5710474pxb; Mon, 28 Mar 2022 16:35:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjbEqO/xN7L4U3c+rTS/gxEeqmZKU4FkieLLIYLDfJAaiUS6AhJgt5O/0AxiyR0z9JuAqB X-Received: by 2002:a67:af0d:0:b0:325:740c:b15a with SMTP id v13-20020a67af0d000000b00325740cb15amr10112475vsl.54.1648510540703; Mon, 28 Mar 2022 16:35:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648510540; cv=none; d=google.com; s=arc-20160816; b=WwPPgPcXsrvL+SwHSM1xyj9JhbPWgUV6dcZvRN3tfb47UrgAWUC7isiu0A2lgCtWNs JrYNAEN9ynk5QAEN8RvJ6rPxtUB4fgR6G7DiEiFZNV9fsGEpSFgna9rS14gCZKbmOV65 dvP7P4Cf/VTzWlirq7EoPjbEBZ13bO6/BT5jwXepxG9Sd8viQ1r9ZGCpEbpQDpNj8Ove qZ+NuirW9ykAxvcabJP+semBz0CqFgux+QrWPuq4hjpcFyPPYSqaBAPqcsOjeFQ+EXXa 0y9IHzIH4EpgivmDNmiFyJj6jg9jJwbs4Rb8MSHHAMMQCruzK+tdX37yoJP7ut4GMa2F R91Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=gzPQY7CIWdirwhm4LKv1cbxDimk2BF99P/v3WRyGEPA=; b=FuARqaaBS+3cMULZutxkDZnmG6y6baNFhSX7WY3sIn5TzNjLrewQ/SxHULGxXwNum0 U8UrILt5LUe/4joKyFyIeMk2RJVoR6KpEb8VD8WZ6q1+xLULygJkqICXITEaJ8QCn3UB 9tqVbogeUb49bKcR68pjZh7Mdtqd3KnmdIQ6klBGx5M37Y+4ynU8lgCNDF+CBKDcVHmz 3NC1cU/p/HJ9BzHibwQZLmx98oJBOVkPMNPkImczAujM3ohGK1Di3hNqlwCopY2fUPlp g4paAqOf8SfEdedFllbN4WKmq5iSl8NU9X0iF0oW1FDteVcMWy2hvcByG3oQr0rtiAZC nb+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=id0zVO7s; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id m20-20020a67d594000000b00324c5c3bebcsi3580609vsj.254.2022.03.28.16.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 16:35:40 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=id0zVO7s; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7D5BA25C54; Mon, 28 Mar 2022 16:00:21 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230204AbiC1XB6 (ORCPT + 99 others); Mon, 28 Mar 2022 19:01:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230108AbiC1XB4 (ORCPT ); Mon, 28 Mar 2022 19:01:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5078240BD; Mon, 28 Mar 2022 16:00:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A1D660C7D; Mon, 28 Mar 2022 23:00:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3525AC340EC; Mon, 28 Mar 2022 23:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648508412; bh=7C2zg81KqOPL2oH4kK0Qvprda9/Ao9Mc247z5u2Vhek=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=id0zVO7sDGlf9kZ37Xmm3W2vqP4HQ6Nx8BFmzlf4pK6cRRawvVWJCRhrc3WJNQMmh 8SOk/4153l4fNYchqGmpNIONa/WBdWeU4990FXm9guej0rDqzS9iEzvY+65EM9+lF0 unKhwrNDWDnyZzteKKXNhgify24sUvSS53oLSQZB9zhUBGVzjDdwOa16AtYHA1ajsC IZ+M/d07et278qpc3m+o6Ktug8tnQj22mWvN+V27xXBemHIaBEoo8LEptb/CxnSX1x BFIsO3SC4BJn7nwKjY6AmpfbKqlxi1acp12QXdt8Wfu0I7PAdeNXN/55GQMsRqok2n oMzCyPpL42emg== Date: Mon, 28 Mar 2022 16:00:10 -0700 From: Jakub Kicinski To: Michael Walle Cc: Guenter Roeck , Andrew Lunn , Xu Yilun , Tom Rix , Jean Delvare , Heiner Kallweit , Russell King , "David S . Miller" , Paolo Abeni , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1 0/2] hwmon: introduce hwmon_sanitize() Message-ID: <20220328160010.73bd2a47@kernel.org> In-Reply-To: References: <20220328115226.3042322-1-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Mar 2022 00:50:28 +0200 Michael Walle wrote: > > No, it isn't the easiest solution because it also modifies a hwmon > > driver to use it. > > So that leaves us with option 1? The next version will contain the > additional patch which moves the hwmon_is_bad_char() from the include > to the core and make it private. That will then need an immutable > branch from netdev to get merged back into hwmon before that patch > can be applied, right? If anything immutable branch from hwmon that we can pull, because hwmon is the home of the API, and netdev is just _a_ consumer. Either way I think you can post the patch that adds the new helper for review.