Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp5736341pxb; Mon, 28 Mar 2022 17:01:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuYDxBGneb251+UNYPaWCjLukQP6wJg9N3ktRf5guY+lieVQiMma3OwZutpIka7+z4UR5/ X-Received: by 2002:a05:6102:6cd:b0:325:66cf:ddc9 with SMTP id m13-20020a05610206cd00b0032566cfddc9mr11896946vsg.27.1648512070517; Mon, 28 Mar 2022 17:01:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648512070; cv=none; d=google.com; s=arc-20160816; b=ZzcmZTwZun/iiK80e/uyHt4/A2v/pxGARL2OJgPeFrSt+RSuvW+hF00PC83dTejrHX E0Y5Nj/ysXxqwQUO8pU5aFW+qyI+Us8kQqii7PLYyalyyZzkaAhnT2SqBxPJAJRTa3Cj LUcBqXcUPgOEirevIaI2T26Gyzlq58v1YUDnLqFx/jCVh8GtRwqAvvHztzzln7w1mzYQ gvTWa9WJjk3A3Ptm274RlyHylHzv/vBsJw7u4MPJbVWoSPRe5tHrcP36tO0bKDcVQEiw lzBwowlnNW28pl+W5+cNZtzEA8FZIZtMKYvIJ+wMhKzjPu7xr/CP5HHKTlY45GVWXWLH XFYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=IownmVPatFLQN+iUm59pfkSutEWOH+L676XGxbR+99M=; b=qnRtmKdUgORvt5xEHUckktTaS3TnYldVj6E9HonsW91TLaNRCqDoKrrYD81tTF7fQm YwxTvckZ384LXSuuklqL9ALAaox1SIMJssLX6DbG8NgGgN4/T6R5nZLkxghUmNxgwp7b 7fSH9tV7NU0bmzj4ItJFdRubP0VEHTthIWcWeHikV5hrDkPOmIZfpWppXPb4QTmjCxiI IuBLL53V+C0Cfxd9Y18M26X5FFnvSndClAZxChblv9AqLK50ZWViUQZ/M1MGL3lGFcCM HxpIkH4B1PifAEjQqpFr9oTrMF56MO6mezBGgwQgppULw9xHf9GHsV4K3bquYJcJcDf/ 4xtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="GMaMR//p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id m13-20020a67e0cd000000b003255fa0b983si3571913vsl.763.2022.03.28.17.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 17:01:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="GMaMR//p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8267D47557; Mon, 28 Mar 2022 16:30:27 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230438AbiC1XcB (ORCPT + 99 others); Mon, 28 Mar 2022 19:32:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230357AbiC1Xb4 (ORCPT ); Mon, 28 Mar 2022 19:31:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC41B3C711; Mon, 28 Mar 2022 16:30:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 811E1B8115C; Mon, 28 Mar 2022 23:30:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 20297C34110; Mon, 28 Mar 2022 23:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648510212; bh=jfLEW8Shh94IpRP5NsFyGBrC0Ur4xy9XSQg9OBesm5w=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=GMaMR//pqJ0XsxFuwy3IazWa8tfk0X3VL3piygIXOEBJaD+kPwqrTOsnTTG7Nc5So Tt99HAd2NrMP3E4tvK2Jul+H1Qggk6YejjZSlmfvhA/7+D0TCPbQZvkiLcwTlwLONK 9THnnc2dwk1IxdhXDWHmXRAdrRoiAYvY4woQeTlsM9i0h97QLzf1So7y8hZGmWsICd rEMNQfuowVaORQ4v6AY3HHBDUWpv8lG5HooV57RFK2z9KqCS7/CdnjyHgIEbP7Zfo4 DxsO6qrt6ZjsZc0SK1H5ag8uJxrK0qmjEiJJzQ0DzETgNuQDRO9m2Y8K/9NAeQSOle GMAIDQRFQvDfQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 0213BE7BB0B; Mon, 28 Mar 2022 23:30:12 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164851021200.6043.5974433550480970783.git-patchwork-notify@kernel.org> Date: Mon, 28 Mar 2022 23:30:12 +0000 References: <20220328032431.22538-1-xiam0nd.tong@gmail.com> In-Reply-To: <20220328032431.22538-1-xiam0nd.tong@gmail.com> To: Xiaomeng Tong Cc: f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Mon, 28 Mar 2022 11:24:31 +0800 you wrote: > The bug is here: > return rule; > > The list iterator value 'rule' will *always* be set and non-NULL > by list_for_each_entry(), so it is incorrect to assume that the > iterator value will be NULL if the list is empty or no element > is found. > > [...] Here is the summary with links: - net: dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator https://git.kernel.org/netdev/net/c/6da69b1da130 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html