Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Beau Belgrave <beaub@linux.microsoft.com>
To:     mathieu.desnoyers@efficios.com
Cc:     linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-trace-devel@vger.kernel.org, rostedt@goodmis.org,
        beaub@linux.microsoft.com
Subject: Re: Comments on new user events ABI
Date:   Mon, 28 Mar 2022 16:30:10 -0700
Message-Id: <20220328233010.2636-1-beaub@linux.microsoft.com>
In-Reply-To: <1283359416.196715.1648499713041.JavaMail.zimbra@efficios.com>
References: <1283359416.196715.1648499713041.JavaMail.zimbra@efficios.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

> ----- On Mar 28, 2022, at 4:24 PM, Mathieu Desnoyers mathieu.desnoyers@efficios.com wrote:
> 
> > Hi Beau, Hi Steven,
> > 
> > I've done a review of the trace events ABI, and I have a few comments.
> > Sorry for being late to the party, but I only noticed this new ABI recently.
> > Hopefully we can improve this ABI before the 5.18 release.
> > 
> 
> Also a bit of testing shows that dyn_event_add() is called without holding the event_mutex.
> Has this been tested with lockdep ?

Sorry, looks like I've been running with LOCKDEP_SUPPORT without it on :(
I now have both CONFIG_LOCKDEP and CONFIG_LOCK_DEBUGGING_SUPPORT.

You are right about this, thanks! I've sent a patch.

Link: https://lore.kernel.org/all/20220328223225.1992-1-beaub@linux.microsoft.com/

Thanks,
-Beau