Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 29 Mar 2022 00:48:53 +0000
From:   Wei Yang <richard.weiyang@gmail.com>
To:     Oscar Salvador <osalvador@suse.de>
Cc:     Wei Yang <richard.weiyang@gmail.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        ying.huang@intel.com, mgorman@techsingularity.net
Subject: Re: [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones
Message-ID: <20220329004853.svpeohdxyav4joi2@master>
Reply-To: Wei Yang <richard.weiyang@gmail.com>
References: <20220327024101.10378-1-richard.weiyang@gmail.com>
 <YkFuUsWe2LAuQa3n@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YkFuUsWe2LAuQa3n@localhost.localdomain>
User-Agent: NeoMutt/20170113 (1.7.2)
Precedence: bulk

On Mon, Mar 28, 2022 at 10:14:10AM +0200, Oscar Salvador wrote:
>On Sun, Mar 27, 2022 at 02:41:00AM +0000, Wei Yang wrote:
>> As mentioned in commit 6aa303defb74 ("mm, vmscan: only allocate and
>> reclaim from zones with pages managed by the buddy allocator") , reclaim
>> only affects managed_zones.
>> 
>> Let's adjust the code and comment accordingly.
>> 
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>
>LGTM,
>
>Reviewed-by: Oscar Salvador <osalvador@suse.de>
>
>We still have some other places scattered all over where we use
>populated_zone().
>I think it should be great to check whether all those usages are
>right.
>

Thanks.

This time I have checked vmscan related places, it looks all related part are
fixed. For others, I didn't get a chance to catch them. 

>
>-- 
>Oscar Salvador
>SUSE Labs

-- 
Wei Yang
Help you, Help me