Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 28 Mar 2022 20:00:36 -0500
From:   Rob Herring <robh@kernel.org>
To:     Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org, broonie@kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, rohitkr@codeaurora.org,
        srinivas.kandagatla@linaro.org, dianders@chromium.org,
        swboyd@chromium.org, judyhsiao@chromium.org,
        alsa-devel@alsa-project.org, krzysztof.kozlowski@canonical.com,
        Venkata Prasad Potturu <quic_potturu@quicinc.com>
Subject: Re: [PATCH 3/3] ASoC: dt-bindings: lpass-cpu: Update clocks and
 power domain names for sc7280 platform
Message-ID: <YkJaNJT2yt6UpBZG@robh.at.kernel.org>
References: <1647852981-27895-1-git-send-email-quic_srivasam@quicinc.com>
 <1647852981-27895-4-git-send-email-quic_srivasam@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1647852981-27895-4-git-send-email-quic_srivasam@quicinc.com>
Precedence: bulk

On Mon, Mar 21, 2022 at 02:26:21PM +0530, Srinivasa Rao Mandadapu wrote:
> Update required clock-names used for MI2S primary path, VA macro's
> codec memory path and HDMI path in sc7280 based platforms.
> Update power domain names required for sc7280 platforms.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
>  .../devicetree/bindings/sound/qcom,lpass-cpu.yaml       | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> index 2c81efb..e9a5330 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> @@ -38,8 +38,8 @@ properties:
>      maxItems: 7
>  
>    clock-names:
> -    minItems: 3
> -    maxItems: 7
> +    minItems: 1
> +    maxItems: 10
>  
>    interrupts:
>      minItems: 2
> @@ -62,6 +62,9 @@ properties:
>    power-domains:
>      maxItems: 1
>  
> +  power-domain-names:
> +    maxItems: 1
> +
>    '#sound-dai-cells':
>      const: 1
>  
> @@ -192,15 +195,19 @@ allOf:
>            oneOf:
>              - items:   #for I2S
>                  - const: aon_cc_audio_hm_h
> +                - const: audio_cc_ext_mclk0
>                  - const: core_cc_sysnoc_mport_core
> +                - const: core_cc_ext_if0_ibit
>                  - const: core_cc_ext_if1_ibit

You can't add new clocks in the middle. That breaks the ABI.

>              - items:   #for Soundwire
>                  - const: aon_cc_audio_hm_h
> +                - const: audio_cc_codec_mem
>                  - const: audio_cc_codec_mem0
>                  - const: audio_cc_codec_mem1
>                  - const: audio_cc_codec_mem2
> +                - const: aon_cc_va_mem0
>              - items:   #for HDMI
> -                - const: aon_cc_audio_hm_h
> +                - const: core_cc_sysnoc_mport_core
>  
>          reg-names:
>            anyOf:
> @@ -228,6 +235,10 @@ allOf:
>                  - const: lpass-irq-hdmi
>                  - const: lpass-irq-vaif
>                  - const: lpass-irq-rxtxif
> +        power-domain-names:
> +          allOf:
> +            - items:
> +                - const: lcx
>  
>        required:
>          - iommus
> -- 
> 2.7.4
> 
>