Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp5836229pxb; Mon, 28 Mar 2022 18:36:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLHHdaiyq6vWP55KaWesDGzOhbMmSZffCoJOYsh7MkhxcrIUxQG+1yDSt20Hj0uzA5ETVY X-Received: by 2002:a9d:69c4:0:b0:5b2:3abb:612a with SMTP id v4-20020a9d69c4000000b005b23abb612amr138443oto.319.1648517796927; Mon, 28 Mar 2022 18:36:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648517796; cv=none; d=google.com; s=arc-20160816; b=ExozxK79MfY5L+UazYTp5AOs5/v/1mFbAsAK/H6q5gjRf7sKMG93c8FH5DPdQWfAaB LdsnS9ZhRK1avJyadjhBaoSGS0vm27PvLE5b7UpqsXpVivp8EQwk3U6YCvRvAZT3zuZG nxx7KTzAJot98Q9gFQq0LTVbUNwTS9bKA2RVJ99hgoEuGd6+6f86Sx34ZMow2RVoPbTD EAIA+nI6P1pVTP4EPu5iw2wubIDbnJ7sH2iY9p/9UoRPyQOyCuaL9Kn5NNRYvW4Wv8l3 qwAn/PKfRMwx4i14OJrzD0+3M648FiF5GuLW9DJgtyuX41yPkHAgEovPNG/pFL96H0h3 i4Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=nGUt+aj/CNfWrM2Ds8HvT/Dl56Vks6aVB/g96nW8bf8=; b=khQg5AnHWENsUyL+231PBh126RKYQKBS6TCbPbDXOpmjKawlD9c5xDPIfIRL+y8Er5 0mwbxaS6Yd/CullKb7dq1mo7is+gztMbgP4ajp4tRpfDTCLJNFKT6bVudWQgDDJ8XpPp E0fqdUyzsGZmkiFlF2Uk7xcYZmmg6nmvDe/n2Xd8YaEHOnolsD3kDKtF6VrMJr25s+kA kH6xRZW0hz3qAyEjcfCwb/uL1GsQg0WCg2BoYBYg3NZOV1MCbxPAFIsI8ZzRT1781Oqf vWo+p93VCeg5Ga2kl8OskS6Uj29Y8yyb9v567KmQufeWA5tZK2m81nRJCpUNP1NUtz9O W7yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="CDT/Buav"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w19-20020a056830111300b005cb2fc13845si11642774otq.193.2022.03.28.18.36.19; Mon, 28 Mar 2022 18:36:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="CDT/Buav"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229543AbiC2BX3 (ORCPT + 99 others); Mon, 28 Mar 2022 21:23:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbiC2BX2 (ORCPT ); Mon, 28 Mar 2022 21:23:28 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC1082C117; Mon, 28 Mar 2022 18:21:45 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id t2so14449112pfj.10; Mon, 28 Mar 2022 18:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=nGUt+aj/CNfWrM2Ds8HvT/Dl56Vks6aVB/g96nW8bf8=; b=CDT/BuavpP8mQxwjlPaichjpYYhA3Pw5JcLcuD/nscNa9g9fnbkC3tpHyJqdSexocF zFhQRERUhpt+lkdFizRqiSfEzjvH94C69yp6cRX2WnpK9ax1Z/pulaCRMCJkMmdtu1/m kqKBw8HtGQgdVEFMMuJdfWWoounDtqP92su7IXtOCPxCVpFWJgwZ555vugcwen10Bw+Y 3zFCWzY8DEZAiRXmmsAlMptcmOJ0l3XDPVmDWbCKj5Ez/+UmTuJyDO8oYwBixSrRCL8o AJtCVg3evK6iTcQA0t3sBdngLoQRMxexm4kaWSC404LdoglxH6F8HdK7Hjzuv+zjydj0 +ftQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nGUt+aj/CNfWrM2Ds8HvT/Dl56Vks6aVB/g96nW8bf8=; b=pbRbXNtOSt4TPlN+S49vV48hkSFOrKAkja5uE6QKJmpf2Ns4DO1p+nWVqrnvRFP1H6 VlEwRZep/+AMPz47H9gnWdC0lo/lHz2a6XbpE7W5ym/BNdAEyIJ6JkF7ApKuk82KCw81 otxs5Z/MRG7/xEAaB858pEILZ+njh84ipVLWp5upW6/4gEthZZwOhtP4pdwvrWwDgjTx lN3spEkRl4zF6vsFzdffiCWhwOPwf+K5+EHk+FCXinmL3t3h2GNNJGrJVaTEVAp+Wami MW+PBlgMjo9C98zuoI+10GIVPY6Z4RWsBGMlcb5GUD7FQwsM8kdzlqBOUAKxCXXFy6Rk D34Q== X-Gm-Message-State: AOAM532M0JmgTs2urqlVmTVTNzDql9aXkzSdvCpcF8DKr3itlxiDwiKH ThWfQDJDFvmZUodgR3545XM= X-Received: by 2002:a63:5020:0:b0:382:4781:7f4c with SMTP id e32-20020a635020000000b0038247817f4cmr176192pgb.230.1648516904993; Mon, 28 Mar 2022 18:21:44 -0700 (PDT) Received: from localhost ([119.3.119.18]) by smtp.gmail.com with ESMTPSA id i15-20020a63b30f000000b003803aee35a2sm13711447pgf.31.2022.03.28.18.21.43 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Mar 2022 18:21:44 -0700 (PDT) From: Xiaomeng Tong To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Xiaomeng Tong , stable@vger.kernel.org Subject: [PATCH v2] soc: soc-dapm: fix two incorrect uses of list iterator Date: Tue, 29 Mar 2022 09:21:34 +0800 Message-Id: <20220329012134.9375-1-xiam0nd.tong@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These two bug are here: list_for_each_entry_safe_continue(w, n, list, power_list); list_for_each_entry_safe_continue(w, n, list, power_list); After the list_for_each_entry_safe_continue() exits, the list iterator will always be a bogus pointer which point to an invalid struct objdect containing HEAD member. The funciton poniter 'w->event' will be a invalid value which can lead to a control-flow hijack if the 'w' can be controlled. The original intention was to continue the outer list_for_each_entry_safe() loop with the same entry if w->event is NULL, but misunderstanding the meaning of list_for_each_entry_safe_continue(). So just add a 'continue;' to fix the bug. Cc: stable@vger.kernel.org Fixes: 163cac061c973 ("ASoC: Factor out DAPM sequence execution") Signed-off-by: Xiaomeng Tong --- changes since v1: - use continue statement instead (Mark Brown) v1:https://lore.kernel.org/lkml/20220327082138.13696-1-xiam0nd.tong@gmail.com/ --- sound/soc/soc-dapm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index b06c5682445c..fb43b331a36e 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -1687,8 +1687,7 @@ static void dapm_seq_run(struct snd_soc_card *card, switch (w->id) { case snd_soc_dapm_pre: if (!w->event) - list_for_each_entry_safe_continue(w, n, list, - power_list); + continue; if (event == SND_SOC_DAPM_STREAM_START) ret = w->event(w, @@ -1700,8 +1699,7 @@ static void dapm_seq_run(struct snd_soc_card *card, case snd_soc_dapm_post: if (!w->event) - list_for_each_entry_safe_continue(w, n, list, - power_list); + continue; if (event == SND_SOC_DAPM_STREAM_START) ret = w->event(w, -- 2.17.1