Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Mar 2022 11:35:49 +0900
From:   Jung Daehwan <dh10.jung@samsung.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Howard Yen <howardyen@google.com>,
        Jack Pham <jackp@codeaurora.org>,
        Puma Hsu <pumahsu@google.com>,
        "J . Avila" <elavila@google.com>, sc.suh@samsung.com
Subject: Re: [PATCH v3 4/4] usb: host: add xhci-exynos driver
Message-ID: <20220329023549.GA174737@ubuntu>
MIME-Version: 1.0
In-Reply-To: <0366bcc4-b38d-db36-22d6-e6f33af9dbef@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Content-Type: multipart/mixed;
        boundary="----ONjdBwygxer2qCWpL6Cfkdc2CTGKeo01bleMSM1m.vqr4jSS=_275d1_"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <1647853194-62147-1-git-send-email-dh10.jung@samsung.com>
        <CGME20220321090205epcas2p15ac16f281554b663062e0e31666defab@epcas2p1.samsung.com>
        <1647853194-62147-5-git-send-email-dh10.jung@samsung.com>
        <ad877924-68bb-f029-258a-0cf9094265eb@kernel.org>
        <20220323023420.GC19041@ubuntu>
        <0366bcc4-b38d-db36-22d6-e6f33af9dbef@kernel.org>
Precedence: bulk

------ONjdBwygxer2qCWpL6Cfkdc2CTGKeo01bleMSM1m.vqr4jSS=_275d1_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Wed, Mar 23, 2022 at 09:26:13AM +0100, Krzysztof Kozlowski wrote:
> On 23/03/2022 03:34, Jung Daehwan wrote:
> > On Tue, Mar 22, 2022 at 06:10:00PM +0100, Krzysztof Kozlowski wrote:
> >> On 21/03/2022 09:59, Daehwan Jung wrote:
> >>> This driver supports USB Audio offload with Co-processor.
> >>
> >> One do you need one more XHCI driver? How does it differ from existing
> >> and why existing cannot be extended?
> > 
> > I have some exynos specific features and that's because need own driver.
> > It's not good to modify other XHCI driver for my features.
> > 
> > Additinally, I've been developing some features with other IP or Co-Processors.
> > Extending is not enough to cover them and I think owning driver is also better
> > on structural view.
> 
> This reason is not good enough because it's not visible that you cannot
> extend existing drivers.
> 
> 
> Best regards,
> Krzysztof
> 

I could extend existing drivers as you said. It needs big change on my
driver and it could take long time... I'm going to try it. Thanks for
the comment.

Best Regards,
Jung Daehwan

------ONjdBwygxer2qCWpL6Cfkdc2CTGKeo01bleMSM1m.vqr4jSS=_275d1_
Content-Type: text/plain; charset="utf-8"


------ONjdBwygxer2qCWpL6Cfkdc2CTGKeo01bleMSM1m.vqr4jSS=_275d1_--