Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp100197pxb; Tue, 29 Mar 2022 00:33:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUBSIZ7xdOAKlB0oxCsZXZjLXlfr8CDuC57ffSA6AU7B8g2drJZ9Yfyv79q5FUuowjYOrY X-Received: by 2002:a05:6402:2342:b0:419:e86:c7d5 with SMTP id r2-20020a056402234200b004190e86c7d5mr2848817eda.92.1648539214082; Tue, 29 Mar 2022 00:33:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648539214; cv=none; d=google.com; s=arc-20160816; b=JHwSvYhsH/929hYdJdh4WimCArsjbqaYYB2SRy+R0yB1wEo/fkWQVdDA6Lfmb/55gm kZb2dBeif7yJlsG8ZQ33Rd3T/DnERu3VqYVOc2ULMVTeFE/qCh7zb+oQpCKCBRR7s7Kg MW9PmC2pz2z8fCjYrjEXP8uR1kJIzdbw3d7dRbOyWiHUIrOYggjodDGdnXSjeL/6I7NA lQ95N3E7uEOGEu7b8U9vGvYB5d43kxlcelVCPS1RJSXXVqMyVoNPJ4eYyZFn28OsHti2 8QHOMt3qwKbUbqghAuMoVumNwblFHGjjhtoVanmrhWmjntlC23UcCRixTRaWKAA9zyid /ltQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BLn23ZPzFztDmKi1r1MS0HG3EmTPbihADR06egULMkA=; b=a0CeNp0nFe/yoW4INvfLqeYTCJhlxrc0tLqb2pZUZVoKILJQqRTd5FsVXuqCvkhbd6 +4humaDr5efUsR7EOWdIBHRGwM6cgFBrlbqOTeQ8//j4ZyBB5oHWra2rf6BqfhuxQoBg oKGPaxPeVudjXF0z2rCs4M72UweFO7Rm1R/Mhk2G446w7lwB8dWbBAJRloKIPnjSLwkv 8UXkmo9Zwfn25gwqzoxwK+mc0wt0kHmwVw/Fx3kWi2tIXH2Ht04ELJ2aD+Qua5tN+wQJ acqXVpTekCyiPzQNjjK15vzaG2nzxOadXnriBRxUXdiVs0ArkUD5htVqvb+DXji1/9KC t8Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=FU+QQA9Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gu1-20020a170906f28100b006e134033f6fsi1864761ejb.5.2022.03.29.00.33.07; Tue, 29 Mar 2022 00:33:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=FU+QQA9Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233059AbiC2Gi3 (ORCPT + 99 others); Tue, 29 Mar 2022 02:38:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232553AbiC2Gi0 (ORCPT ); Tue, 29 Mar 2022 02:38:26 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 471DD1D41B3 for ; Mon, 28 Mar 2022 23:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BLn23ZPzFztDmKi1r1MS0HG3EmTPbihADR06egULMkA=; b=FU+QQA9ZpAEVDVXWOFgSWn4vAe vCDQ7JhwFailgLwyMcxDwEGJ+pkh3+xhmPZhhGiUlulrXd+bIjD1HH3LmxvaNMppNncIBvBTzXNNE x6QsZ14Ohy4VXLMmOecd5F8fYphuQoWcq0Uitr2CCXm3VIM0xrEtjtg5rBsSpp7WqMg4INJgATACR wZ1CoPa4EflUhSEIb+Z8xsDTycAEU6tE6WOmfBKsv0LTvyaQAB7LJ3XgML5+UiS0rMQTsuLFDVBg+ 2FhvZ3hkHKAqYJMUYyFnqVrbPpx/lwELDbCRjLS2KiSgCpXi37EFDawQ8L4scnU9H3Bviyyh0Bpyh ZM8dZ5gQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZ5T6-00BDGn-0A; Tue, 29 Mar 2022 06:36:40 +0000 Date: Mon, 28 Mar 2022 23:36:39 -0700 From: Christoph Hellwig To: Rolf Eike Beer Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: mm: use mmap_assert_write_locked() instead of open coding it Message-ID: References: <5827758.TJ1SttVevJ@mobilepool36.emlix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5827758.TJ1SttVevJ@mobilepool36.emlix.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 28, 2022 at 10:24:51AM +0200, Rolf Eike Beer wrote: > In case the lock is actually not held at this point this also avoids a > stale lock reference if built with NDEBUG. The change looks good: Reviewed-by: Christoph Hellwig But I don't think NDEBUG is a thing in the kernel.