Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b882ffc5-97df-7b26-4506-30ab7933d960@kernel.org>
Date:   Tue, 29 Mar 2022 08:13:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] tty: goldfish: Use tty_port_destroy() to destroy port
Content-Language: en-US
To:     Wang Weiyang <wangweiyang2@huawei.com>, gregkh@linuxfoundation.org,
        sheng@linux.intel.com, bruce.j.beare@intel.com,
        xiaohui.xin@intel.com, yunhong.jiang@intel.com, arve@google.com
Cc:     linux-kernel@vger.kernel.org
References: <20220328115844.86032-1-wangweiyang2@huawei.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20220328115844.86032-1-wangweiyang2@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 28. 03. 22, 13:58, Wang Weiyang wrote:
> In goldfish_tty_probe(), the port initialized through tty_port_init()
> should be destroyed in error paths.In goldfish_tty_remove(), qtty->port
> also should be destroyed or else might leak resources.
> 
> Fix the above by calling tty_port_destroy().

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> Fixes: 666b7793d4bf ("goldfish: tty driver")
> Signed-off-by: Wang Weiyang <wangweiyang2@huawei.com>
> ---
>   drivers/tty/goldfish.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
> index ad13532e92fe..9e1168c39e77 100644
> --- a/drivers/tty/goldfish.c
> +++ b/drivers/tty/goldfish.c
> @@ -405,6 +405,7 @@ static int goldfish_tty_probe(struct platform_device *pdev)
>   err_tty_register_device_failed:
>   	free_irq(irq, qtty);
>   err_dec_line_count:
> +	tty_port_destroy(&qtty->port);
>   	goldfish_tty_current_line_count--;
>   	if (goldfish_tty_current_line_count == 0)
>   		goldfish_tty_delete_driver();
> @@ -426,6 +427,7 @@ static int goldfish_tty_remove(struct platform_device *pdev)
>   	iounmap(qtty->base);
>   	qtty->base = NULL;
>   	free_irq(qtty->irq, pdev);
> +	tty_port_destroy(&qtty->port);
>   	goldfish_tty_current_line_count--;
>   	if (goldfish_tty_current_line_count == 0)
>   		goldfish_tty_delete_driver();

thanks,
-- 
js
suse labs