Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Mar 2022 10:47:45 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     axboe@kernel.dk, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org,
        syzbot+f08c77040fa163a75a46@syzkaller.appspotmail.com
Subject: Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}()
 fail
Message-ID: <20220329074744.GR12805@kadam>
References: <20220328084452.11479-1-fmdefrancesco@gmail.com>
 <20220328143853.GU3293@kadam>
 <2179817.iZASKD2KPV@leap>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2179817.iZASKD2KPV@leap>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ea4LHvAkGP1JUXS+sYF5wR8YvqEQIRFkxsMg38vSTcXT0v5mwiqJLwuAUOXl?=
 =?us-ascii?Q?LkBckC6RiRdJriharblEYIQIIt0+zNKcHCPDSow3cR48BOenqK9GTx7DQsOG?=
 =?us-ascii?Q?qGSZO9etNqo6wJbW55c0MtSGAuJRuNCSrDFWvMye5O7yYR59A3FQr0aG98Kj?=
 =?us-ascii?Q?tXyqt+oeK/+czCK3E25kKB2PiNmgxyI5dOKkI/ZP9/xcZypTEWfLkB/7a39n?=
 =?us-ascii?Q?ggfGYyrS7DKhRmOv4aTlGqS0WdsG6O6tlnF1DL3bqhphO/+KqeFD4+LRaaeX?=
 =?us-ascii?Q?pel/MKn0bczRR2shgydnLdVnh2J6IXVSuvImjN9UyVbzrXc7V2Kr05MOeBkE?=
 =?us-ascii?Q?glWxIF1X5VoVH8ghSNAVc5Pqo6Mm32zJGTtVnCBS41LumlWZ94UkorEc8jnl?=
 =?us-ascii?Q?H4DGX1JSeVKXW7FrU5shzoqiTZQGPAlONyXXRIRkwJika6WPrppCX0nQROis?=
 =?us-ascii?Q?loIxN3/V7n9H6iafPbTrkUsNsU3MBIZVZS9pp9EPUQASG6Oaex1QBJ4tvV6l?=
 =?us-ascii?Q?TCW/YsesR3GHLJlSpBX64LPXiCP/CMxETEm3qbO+KRABLRjGlzeHP4gfOCeU?=
 =?us-ascii?Q?hhqSX8XoM4RMfVumMdmZY9h10ESa/4YwAEbhM1aVNXL0JWWZe/W1akK5OLnY?=
 =?us-ascii?Q?51xJpjzfrjA7UsfFCo6RvdFxlscv3+0KPWkUZQ8VW30o4FphBGfJpESZ1r++?=
 =?us-ascii?Q?HHjJJZMBI1H9F8hWTERzZK3gVJGyoW+/Cod+AT2eVEBX2szoc5SLIBi5rvRi?=
 =?us-ascii?Q?tbDP6LsamSgmo7UAkDqahRRA9lnc2QTV3TSMd+i2fXpuwoVe8hGd+PYit7wR?=
 =?us-ascii?Q?ticE2NZEQPXdoWQOuNgDKGo2vcwBrGG9sluiVx2ec/NNBZArqZMgCuilhApG?=
 =?us-ascii?Q?qSJWwYARoywBpuzuUs4aYfAFdT6ec/VWJmI8O+krS9aMg3D+f0BmEXFSb1Ht?=
 =?us-ascii?Q?wXtY9maOitC5Wp68xJjWlEGrtvToIQEDLESbPjSRYPbLmeE4gw2BrOx9rOlX?=
 =?us-ascii?Q?7voFGNctzkMr1Xl+8mf/tkALHkqDCnC1k6wp8ZydiTLj3Lr5X3TLwh8zxjdW?=
 =?us-ascii?Q?rhgoycE17eENuMtp6bd7cGjmZy93w+gt3FC/zFwye3aATOQrRjLwDOOHwLDO?=
 =?us-ascii?Q?DIRyqqbkh1HiZ6VkoKNC8/17f86jAn7tDYGn/7p12kcEiv5oK3sZ/yG/2dBj?=
 =?us-ascii?Q?q4P7M5yA+lZ0KxrW7ZExqn88Q8I3EiTsu9Zl0dQN7Fto6Nhfnmg42ubEyfUW?=
 =?us-ascii?Q?rWFHEt8FIdMrqhexzM7x3kaCeuRvFJqwx9Fs4vfObe/eAYRDK5RiB74YNErQ?=
 =?us-ascii?Q?tw/VUQNm5XabWiRVZ4/aFUtC9kNOdH+NTCO16I+0A/5G3gG4htRgw9IO2Jah?=
 =?us-ascii?Q?grN0D3TZ9BiddYeCqjDXJvcrm/7nPzr+YKTlVpR4/Ylp3G+xcFWRUyVBaB0w?=
 =?us-ascii?Q?kAO2QoVvvXxbZ/sjiA3vvAqmOxo/uUUV2hEP+dtRiBNR8GVMKbjhVkltiVMK?=
 =?us-ascii?Q?jhNuGw4RrXn+Q0KoiwaOFUIPxLieKd553PQxhKpDvo0fq36ijaNAoTK/RPN7?=
 =?us-ascii?Q?JBh7fHRxR0rtAurtHzcLPjO0Q8ng8jNz610pA2+upNPyDcMfBNCSKGGrRZlq?=
 =?us-ascii?Q?/Vef4fL2UNmJB82m44+Ou0V6b03pkhsbOvBQCNwMUoSAHfTC8hZ7snyL5zUL?=
 =?us-ascii?Q?1LR54PNd1XNhDVa86VTv1gyGraP3SKaf47QKmPpPv4TUfeTipjQOg94yhs/P?=
 =?us-ascii?Q?6IkePb2s1lZvw+JJOM4Y8/JxmY24ArU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 194fbd48-0d42-4042-ba5c-08da115870f7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2022 07:47:57.7986
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nW+jS+0aW/ecCNhWOhXEOP3ru/ecQqRSwTds4F7J5hpFjReI/p74V3keQL3K3zSdI0BN/JLKRWF5fwLHlrxmnmjLmCG/rB7F1AEWhthLccE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4176
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10300 signatures=694973
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=768 spamscore=0
 adultscore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203290045
X-Proofpoint-GUID: E94WwdABvnPRbPgdTHQSNgUwg7qSErW0
X-Proofpoint-ORIG-GUID: E94WwdABvnPRbPgdTHQSNgUwg7qSErW0
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

No, this patch is wrong.  That is supposed to be freed in scsi_disk_release()
but apparently that's not getting called.  Is the ref counting off?

On Tue, Mar 29, 2022 at 08:18:16AM +0200, Fabio M. De Francesco wrote:
> > There is a larger process issue here.  We need to figure out why syzbot
> > did not detect that this patch introduces bugs.
> 
> This is something that the people who run Syzbot/Syzkaller should help to
> figure out.

Yeah.  Right now syzbot just says "TEST PASSED" but it doesn't give a
complete dmesg.  There were other leaks on this path.  Were they not
detected?  We can't know without looking at the dmesg.

regards,
dan carpenter