Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: gywd8qDig/D1aHffmz+gFEU3Yu2xZg2JWSwatxlY5sEiWVKWMCgxdN7xAu9/MgFJB5dub//Lcl
 dO/kL49tQc8BdXTWckLtcCf+3S7va0YMiMU/Tsf+oJFR/J6IbtimppNB80s7k9VSB8xmdXcn+n
 axRGKnqjZIm/fBBaTgVgR7lhPgvMLT43V6IIVnXQ43cFA47fInNevR5QO3BBElyasN8jmL4/oE
 OrtKYBD8R7IY6Tn88iqd4jhkZKd1IEvG6NtCZPI9cJlQSeRE1wfgqPR8h7c9gZjgJ8QmHwwjkR
 iAMjOrkTdQqnfYhqrgZ8gYLA
IronPort-SDR: m8JZA3DBgwEVEyu4wA0Q7TG93oyxsJXAHVjkac0fY+yqQgaE507osLHS+mq0+UQS+cf3LpTM41
 9q9V4AKMg7eM3fZLarK5DuswaDmDrOrNHLJT5NEQXUIWbxrJpVk95MXfmuWUEVc56nqB1pkpm4
 Pq0AkPAs29u3Jc7r4GZCeQquB8t3n15jYmsbRU3tiAgoUiiN4zV7RldPifhFEBRi2b+0yGc/9l
 /leEu6EcVaB8EBDwdBZWrUC5AB9rFX/Xv6+dCmYLi6i8N+0ZAUi6rjtOAZlZHVlHTrGdOhS1Zy
 I/k=
WDCIronportException: Internal
Message-ID: <19912886-4032-633e-e4a7-ef47ae389ffd@opensource.wdc.com>
Date:   Tue, 29 Mar 2022 17:20:18 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 03/21] ata: libahci_platform: Explicitly set rc on
 devres_alloc failure
Content-Language: en-US
To:     Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        Hans de Goede <hdegoede@redhat.com>,
        Jens Axboe <axboe@kernel.dk>
Cc:     Serge Semin <fancer.lancer@gmail.com>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        Rob Herring <robh+dt@kernel.org>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20220324001628.13028-1-Sergey.Semin@baikalelectronics.ru>
 <20220324001628.13028-4-Sergey.Semin@baikalelectronics.ru>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220324001628.13028-4-Sergey.Semin@baikalelectronics.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/24/22 09:16, Serge Semin wrote:
> It's better for readability and maintainability to explicitly assign an
> error number to the variable used then as a return value from the method
> on the cleanup-on-error path. So adding new code in the method we won't
> have to think whether the overridden rc-variable is set afterward in case
> of an error. Saving one line of code doesn't worth it especially seeing
> the rest of the ahci_platform_get_resources() function errors handling
> blocks do explicitly write errno to rc.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
>  drivers/ata/libahci_platform.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index 18296443ccba..1bd2f1686239 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -389,7 +389,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
>  	struct ahci_host_priv *hpriv;
>  	struct clk *clk;
>  	struct device_node *child;
> -	int i, enabled_ports = 0, rc = -ENOMEM, child_nodes;
> +	int i, enabled_ports = 0, rc = 0, child_nodes;

You I did say that I do not like this. Especially considering that this
function uses rc only in the case of an error return. Having it uselessly
initialized to 0 does not make sense and goes against your goal of
avoiding problems in case it is not set in an error path. returning
"ERR_PTR(0)" is the same as returning NULL, which defeats the purpose of
using ERR_PTR/PTR_ERR.

Please drop this patch.

>  	u32 mask_port_map = 0;
>  
>  	if (!devres_open_group(dev, NULL, GFP_KERNEL))
> @@ -397,8 +397,10 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
>  
>  	hpriv = devres_alloc(ahci_platform_put_resources, sizeof(*hpriv),
>  			     GFP_KERNEL);
> -	if (!hpriv)
> +	if (!hpriv) {
> +		rc = -ENOMEM;
>  		goto err_out;
> +	}
>  
>  	devres_add(dev, hpriv);
>  


-- 
Damien Le Moal
Western Digital Research