Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp313220pxb; Tue, 29 Mar 2022 04:30:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxB8o+yHZzFidQ6YyneTQAxlEqcNSB2VYgtPExgYdc5jgjCaH5GogdH4KxmQe9n4qUa3bK X-Received: by 2002:a05:620a:40ce:b0:67d:8f47:eb6d with SMTP id g14-20020a05620a40ce00b0067d8f47eb6dmr19942612qko.108.1648553420937; Tue, 29 Mar 2022 04:30:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648553420; cv=none; d=google.com; s=arc-20160816; b=IgXpjSFsJ4tJ5cv2Al1IuS9V+TmvHv2Ml9cWwK24kugGe55N28eQ8CY5xxOSX2vTAC XpJtrR6OZJMT2RqJ+an67zzWHz6+fekfTgIsNm+bDdo+Cc4/ImqMST+T6HhRPsq6LR7m +cFyrcrU10O0sjhBPK3n6KUOVNbOtMghxyyiMFzkzpe3BwmKd1aaRfxJSwDCaxyEcS3N JPONtQDjc9xEAfUPwPrXpABhgukL5ULqvpBib807cvj+p/7AWEgdqakxQVnipOl+IAWr S1d/GAsn43FuwJlNugrR5DlpBtvVYXit3rCFCv8De5DSO+9LSmcekaG/KNbLk6wrnRbm r99A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=imMf/sCDlNOhGkWvKvVgGBwm+adrUzJS7j7Ttujr4UY=; b=Ea3Ga4HENbm6RcuTazaKPsrh2iAy9rT13qIXybN3ze4OWy9Hr5kpONEwotyNG9tOWy aQKHU4V6k4dfhEhRB7CpxtwALzPeTyWHa0Em84Bx9VmggLcASx/3kzfjUlw1H5XAdNNd kUteRQXoeEgTi5RgJe6czGPOWkq2XCaTOjQ1MKJzSNmECyQyuDWR9U9CSABLXR1B4rwF w8dvAIJfFTZGw5mr1GXAnGGelQfWISE+OjXVQLQ1wsxGsyZ7JIfjslTbw4JyDnK7N6VS xSGUj/Dk1wyIF6WOauXEJnhW8urXZW0Wnkkl+IGXqh5Jse4DLWSsYE+9wTQNqyHjWZTv KsuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o207-20020a3741d8000000b0067e4be23a96si8008538qka.731.2022.03.29.04.29.49; Tue, 29 Mar 2022 04:30:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233169AbiC2G5Y (ORCPT + 99 others); Tue, 29 Mar 2022 02:57:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232317AbiC2G5V (ORCPT ); Tue, 29 Mar 2022 02:57:21 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4379D2DD46; Mon, 28 Mar 2022 23:55:39 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id F365868AFE; Tue, 29 Mar 2022 08:55:35 +0200 (CEST) Date: Tue, 29 Mar 2022 08:55:35 +0200 From: Christoph Hellwig To: Jiri Slaby Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Jan Kara Subject: Re: [PATCH] block: restore the old set_task_ioprio() behaviour wrt PF_EXITING Message-ID: <20220329065535.GA20158@lst.de> References: <20220328085928.7899-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220328085928.7899-1-jslaby@suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > task_lock(task); > if (task->flags & PF_EXITING) { > - err = -ESRCH; > kmem_cache_free(iocontext_cachep, ioc); > goto out; Please add a commnt here why we are not returning an error, otherwise this is just getting "fixed" over and over again.