Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Mar 2022 12:18:27 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Benjamin Philip <benjamin.philip495@gmail.com>,
        Bart Van Assche <bvanassche@acm.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Colin Ian King <colin.king@intel.com>,
        Samuel =?iso-8859-1?Q?Sj=F6berg?= <info@samuelsjoberg.se>,
        Charlie Sands <sandsch@northvilleschools.net>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev, ira.weiny@intel.com
Subject: Re: [PATCH v2] staging: rts5208: Convert kmap() to kmap_local_page()
Message-ID: <20220329091827.GY3293@kadam>
References: <20220329055539.29299-1-fmdefrancesco@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220329055539.29299-1-fmdefrancesco@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Bsvpps6J7O2wnhcdqHk4U8c7U44Juu4GAYJ9+mXzy6BZLaUEum1HkDPk4liZ?=
 =?us-ascii?Q?Yn1D955DjeSLO/IBWS7If4kQemTtdtA0fRuYAjealxE5THjOJ6vsGRokfyLe?=
 =?us-ascii?Q?pW3IdzMInE79rRnfv52/zoD0+8xWnpTINIB0OTQSqnBFgeE0k5EmdgWZOT68?=
 =?us-ascii?Q?Qyc4pltgQbba9wxlwXYD+PtxPksZ3eeOXdK783idw/0lQeFoVYqtt9QL5bZX?=
 =?us-ascii?Q?sZtrG2sWVDEyA0Rugs4m0D1qUIucOHp5bwgKtg3Gx+C4uMwGBBMQLa1LJGjk?=
 =?us-ascii?Q?pFARF6DtqH//V0RlXm5Wh2+s/znc9omzTMfUEE9xiwljBweAlO/8gvePsu0u?=
 =?us-ascii?Q?Ts8AqbM3r5KQX6fpapO2lwkgTRIhoryY+cTzU3jfBmY6LldvYGdCeq0qOcyC?=
 =?us-ascii?Q?Op55MzIUN0/PGT3d8V6dDGOsPr5CBjD5VvHKO9tZ88jJxPnycUk67PsIUh9e?=
 =?us-ascii?Q?/eg27cn+HL6JciC+m1blBEMK7sTnfff1f3jjI7i8vCnuL0PRMkh8L1halqtE?=
 =?us-ascii?Q?Hh5kFzORagrmUbEDMCbPt/j1HE9of8cmA0UgzZSBb3Yw1kbFpA4VstGJuX5E?=
 =?us-ascii?Q?GFpPAb/IwHcRqMZtU/scq55ppQFwbKZozfgC6uUVqQmzwl++6GWJpkBRNxFO?=
 =?us-ascii?Q?cqoAwkva4JjUgZaEB8/+yIQtjkUKm+0HARTZI50znAD8cusmfaFeBoRToBkT?=
 =?us-ascii?Q?Ri358Esrtu64rP8Z3u03LTeg6zM2Vp+vspOe9tuQ6Ix0njAsImSrP6QvbL6V?=
 =?us-ascii?Q?LblpujF1DjXKyG+S4nqkbYuelimlm1L1NkwFdKV5gt53hRS7zHE2b0gAAfWN?=
 =?us-ascii?Q?73ENh0e9yVvxLnv+jgiZt6xHoX5xJYJP25JBxcGUYWhiD5lWRXNrTwAvghnk?=
 =?us-ascii?Q?RvZ7/tY9Ww3P6Hzq7gKsf81Rf6VMvbakEHlLO7AOZt0SZG1b6W374ZiObSHK?=
 =?us-ascii?Q?n5WUpukKiFDzwC/Z+qnVV3j7oxIZB3hUgeGyYhNsf+nmie6Jsu2DdkWTBGBd?=
 =?us-ascii?Q?37wA4XTWzdu3xjBSAAPeFVDbEjBM2P+MItw+ARkmk4Flj/ujyHM6EDVYf9no?=
 =?us-ascii?Q?XIoqODUK0Xtir9m7gvG7m1NdfAc9xIK9TzFa6khtLEq/Sx6M7E7k93VWDK19?=
 =?us-ascii?Q?QrvT8y93ao0I3IlkrPyvixqJjWkK3f84jVArrOFFYYBX+zaFlT1zR7tM2PxO?=
 =?us-ascii?Q?YAQAkU65EpH+pnv84conIx8/boKbANtAIF+hw3IBVdHX+erL7DaxUC1dDOaM?=
 =?us-ascii?Q?P5WdJEk84zimi4Y0W7a/9ZCume5lUeuiNOvbmVGCD7UOuhbKENmULUrC8mA2?=
 =?us-ascii?Q?+4Qw9C1+hVASrAhrZnUi+y8+l98FIIbF0KzxhKSvMxncqc83Y/cbtfDHXm1o?=
 =?us-ascii?Q?Y0ia+PAMPmpQEyxVsIN0/yq56Hx6I9vTOwL748uE0MPD5F1vZ32svakJptkc?=
 =?us-ascii?Q?Vw3pa5VC3B0I7WPKZJOd9twtrbiss8I/6It5uxuPsp4u67YMM6Aw4P6nBPSO?=
 =?us-ascii?Q?c3KwpKiX4sz2CclwwoMBscySgT6+N2XK3kMizyhhwPlvqVFqS2pw16ILVMoe?=
 =?us-ascii?Q?XiSBa6tzSz5T89bkllC8Vgkid7J6DNmcQWEmaudfy+XB8zWhluP2OU+sqmox?=
 =?us-ascii?Q?i2EJCvyLDnwjgzmkAmIRapf51KNv72XONV0YuSiE0YvpYXcc9EPZ3JGaT1Wh?=
 =?us-ascii?Q?YDdehe3DxcvcEcJlAQErJDIZWojTHMOWRlMeN1tWyW1P0owYKP9hEHL9P8Ny?=
 =?us-ascii?Q?fhrrZDsPIMqB9aZAS2JOhA0Lpvh3XRE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae133bfb-950c-43bc-ae36-08da11652272
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2022 09:18:49.5531
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QwW0a9gNbueWhVRZHfexAyPEbKmtvzMBMnh3ZD3BAG+REncgf0nGINNjtG7F9uNEKt/TE1fMSXdytNoSkT6SFmPk6sUIRLD5+nQmK21eyY0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1384
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10300 signatures=694973
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0
 phishscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203290055
X-Proofpoint-ORIG-GUID: rMDKRT1-srd-AmE1ba_0Klox0ocjOROm
X-Proofpoint-GUID: rMDKRT1-srd-AmE1ba_0Klox0ocjOROm
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 29, 2022 at 07:55:39AM +0200, Fabio M. De Francesco wrote:
> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
> index 805dc18fac0a..56b6cc845619 100644
> --- a/drivers/staging/rts5208/rtsx_transport.c
> +++ b/drivers/staging/rts5208/rtsx_transport.c
> @@ -92,13 +92,11 @@ unsigned int rtsx_stor_access_xfer_buf(unsigned char *buffer,
>  			while (sglen > 0) {
>  				unsigned int plen = min(sglen, (unsigned int)
>  						PAGE_SIZE - poff);
> -				unsigned char *ptr = kmap(page);
>  
>  				if (dir == TO_XFER_BUF)
> -					memcpy(ptr + poff, buffer + cnt, plen);
> +					memcpy_to_page(page + poff, 0, buffer + cnt, plen);

You meant:

	memcpy_to_page(page, poff, buffer + cnt, plen);

>  				else
> -					memcpy(buffer + cnt, ptr + poff, plen);
> -				kunmap(page);
> +					memcpy_from_page(buffer + cnt, page + poff, 0, plen);

Same.

regards,
dan carpenter