Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ca485dfa-58e7-6a09-97b0-dbf7cde7a7e2@ddn.com>
Date:   Tue, 29 Mar 2022 12:09:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] fix certs compilation / export is_key_on_revocation_list
Content-Language: fr
From:   Bernd Schubert <bschubert@ddn.com>
To:     David Howells <dhowells@redhat.com>,
        "\"David Woodhouse" <dwmw2@infradead.org>,
        keyrings@vger.kernel.org,
        Linux Kernel <linux-kernel@vger.kernel.org>
References: <ce5bc8c0-2c6d-2a22-1ad3-357254686366@ddn.com>
 <e92ef2ea-bb1c-8a8d-2e25-c784a784b995@ddn.com>
In-Reply-To: <e92ef2ea-bb1c-8a8d-2e25-c784a784b995@ddn.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODVzOTRwbDFzTkdIeUJLa0IvK01LY3JVaDFXTWpkbWcxaUMrZUpGektiYTJr?=
 =?utf-8?B?bWhCWFRUc2tkZ09vQXFuK3RhM0ZQa2M3RFJqdmdXcXd1cTlGY2R5cmMvVUha?=
 =?utf-8?B?V21tblBTNHpYK3Fyc2dZUDBDaEkwTEpBYUltd1oyd0JKWjRHK2l6QnhOMkRO?=
 =?utf-8?B?VDYxbVBkT05JaHkxTjUrR1dMMDcyRDlrNXhSbGFQcWU0WjVpWG11NWFDbGl2?=
 =?utf-8?B?a3ZIZUkvaHZCNy96T2JhQnFKVW10ZWtkNklLMGRqdkxjM3dXS0hIWTJuUmEv?=
 =?utf-8?B?MXQ4ejZZRU1uWFB5b1J5UFQ0Vk01eE5hR1ZHMlY4cCsrWE9MUzRUU1pzRzhF?=
 =?utf-8?B?Ulg0QWIzTGo4dzV1V1dYYW9nUTE0QWhHYW9pdGUrSVh0TGlheFE4eTlIN0ND?=
 =?utf-8?B?L0JBQkZFZ2tIaWNkbjdQNTgremxXNWJKcHRWZVR6djVnOUxjRWJQeHRoUFlh?=
 =?utf-8?B?SEN2S0VxeXhKS1VXZFVZeVRpZlNFWDlGcjJ3T2ZMVnVmUlBrelU2MGN4Kzhp?=
 =?utf-8?B?ZXpXMVpLbWFqQXYwRzhCT2pmcHdtQnFhWGFRcGpQS3MrYzhyUURwbGdSaHQ0?=
 =?utf-8?B?WmpNMWVtbGdsVnFVY0VOZ3R4L05kbDU0WHM1T0NsdTh2cnM3S1NzenZuMTZ3?=
 =?utf-8?B?cEpjeWpuZllIM2RBOEw5ajVmbmtqdGxCcXVrMThXOEppdTdKNTdBY2pDMmtZ?=
 =?utf-8?B?THlTWEFZY3h4OTdYelJYY0huSS9BcU9MTkZmYkdpSFJ6MFBDUzlkdmZvWmNF?=
 =?utf-8?B?TTZGL2ZkdXRSTkhCbjhybkY5ZEJLY04zUEVDZFZNMFFiQi9WcFVUR1ZhakFL?=
 =?utf-8?B?enNJY1RIZzlJUXFFS0pVbmRCTGMzZjhSczVVUVU4TFJVUzVnRVl0STlEZ2VP?=
 =?utf-8?B?QVh2WkVOTTZPU28yeWtTUjc0T0ZuSGlKL3FJUTVhbkNWVDB0a3VDSWYwNktF?=
 =?utf-8?B?cjI1QmRYaTRUTElFSllDaEg0YXhxLzRxTWVkTkFxdnpKYzJyRWg1MDVoaGNF?=
 =?utf-8?B?VXBSOXNxMlR4ZWMreStKekptN1JMaHpWUmtrc25SakYzNDlac0Z6b1RxSHZU?=
 =?utf-8?B?NnlYM1NzLzI1eEg3MjZROGlKZVJLcDhpRm03dmFKWWx5Mm5iMTVTa2l4d0Nh?=
 =?utf-8?B?UzQ0UGRjTm5TVDFZcmRkVmRnZW95Yi81SkxKTThWNVd0bVhVNyt3dlpldXgz?=
 =?utf-8?B?M25XQ2thOGJwcE16eHJCbUU4S3E5Um1DNFZkS0orU3BmRFd2ZzNQTDQvUnUz?=
 =?utf-8?B?QTk0TU1PZEYxbWZSZ1liTjhsdllMS3ZmY0o1a2NVVm1sdCs5UllCLzMxNytG?=
 =?utf-8?B?UEc1K1pvQjVKdXRHZlJXUmxBYktTMWFtUW91MHFkREhmUThwemxNbFZyRkhB?=
 =?utf-8?B?RVptVkFVd2FueTR6V2hiU2hVM29Ia0ZZYnhXTDRpNC9ENjBaQkpwZGN3WW9C?=
 =?utf-8?B?R3B3V1kwTjJja3hFZ2xHNUZIaXk0RFgrVTZhaVNreWVTQ1k5c2JYZFo3UTZk?=
 =?utf-8?B?c3pqRk9zWnEvY3ZqcnlJY08rQVVkbnNZUWliUitneHdUYXpoMGJKOHJaZ2wy?=
 =?utf-8?B?ajhER3B2enZ4djRpVnptUDVFeWw4NnFpa0JHZlpBM3kyY01SUjd3TjRUa3JJ?=
 =?utf-8?B?VkNHSjdjV293ZUJmbUIvTkFiY1pCMVNkV2ZWY2RXaUlzeStYeXJ3cHFncS9z?=
 =?utf-8?B?ZGxDbkdJWVpQaVZiN2ppUzRYQmtXQmtLZXBGTXE3bEp5ZEV5aHBuc1ZYdlp5?=
 =?utf-8?B?S2dsMmFWWTJTTXFVOU12QXcrMDR2VmUvK0dQSEFCWGVtY3pMSC93Z3RnNW5F?=
 =?utf-8?B?ZVF4bnBLQWVLYlRVQnF3Z3JLbXA2VG0vQlh6bVFYQitxV1JIbklHZktLbjI2?=
 =?utf-8?B?akpJVk41N2V0MXorRUg1cHFiZjU1MGhoRHNSalZQSjN4NmVITHhwREgyaHBa?=
 =?utf-8?B?MVBlOC95dU9rMWx6bkU1TVd1OVB3N2hMS0dUSXlWNUtucW1IWjNrbWs5YXpD?=
 =?utf-8?B?YVRSaVQ5V1hoYmhBSlkwY29Md2dnRm14Y0tBUUc2Y3dYWlE2U01OcGhEU1R0?=
 =?utf-8?B?WTVoOHpiNXlwUHZDQWlyRGxhbW1mZHVMbWJUOUlyT1dTRU5CUVRXLzRsem1Y?=
 =?utf-8?B?ckk4UlVSUjRtLzBVdGUxemJVcENrL3ovRlphVk5IMkFIbFU2RU1US0UyZ1dY?=
 =?utf-8?B?aVd3L3lBSXBSVDNsWER5VWpiV1kvNVY2bmpqOVlCVHRxWDIxQkFGbkVSWFd4?=
 =?utf-8?B?cy91RVMrRG1jT2RKVEZwb0ZqZURVa0FtNFhEUkk5d2V6U1ZTQmdjcWdua2Jl?=
 =?utf-8?B?Z0huVEEyc3NYL3Z0U1MveEpuZk5XSS80UTZxVm01MnhyUUxIb3ZwY2o4UTRY?=
 =?utf-8?Q?T+JMs1swkkOu3zqJmhefYBr0ctPmZi9EITyb+mPRgGubU?=
X-MS-Exchange-AntiSpam-MessageData-1: 0bcU4u5P+8nwVA==
X-OriginatorOrg: ddn.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ca5107f-5d00-4867-29d5-08da116c3448
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1901MB2037.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2022 10:09:26.1068
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 753b6e26-6fd3-43e6-8248-3f1735d59bb4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PS32iECf0NjU0/CVLLKTSyKbilhEg5ACdgYms1S64HyoyvcRS4suySCOz/ibxZjk6LZ3t3oe8aXwnaM1tZ7liQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR19MB5960
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ping

On 3/2/22 21:19, Bernd Schubert wrote:
> Sorry for the spam, besides that pasting the patch somehow did not work 
> (I cannot apply it myself), I had also a typo in David W.'s mail. I hope 
> that attaching the patch is fine.
> 
> 
> 
> On 3/2/22 21:06, Bernd Schubert wrote:
>> From: Bernd Schubert <bschubert@ddn.com>
>>
>> Compilation of 5.17-rc7-master was failing with my .config
>> (actually taken from Ubuntus 5.17 package)
>>
>> certs/system_keyring.o: In function `verify_pkcs7_message_sig':
>> linux/certs/system_keyring.c:224:
>>      undefined reference to `is_key_on_revocation_list'
>>
>>
>> That got fixed by exporting the 'is_key_on_revocation_list' symbol.
>>
>>
>> Signed-off-by: Bernd Schubert <bschubert@ddn.com>
>> ---
>>   certs/blacklist.c |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/certs/blacklist.c b/certs/blacklist.c
>> index c9a435b15af4..ad39780e5150 100644
>> --- a/certs/blacklist.c
>> +++ b/certs/blacklist.c
>> @@ -192,6 +192,7 @@ int is_key_on_revocation_list(struct pkcs7_message 
>> *pkcs7)
>>
>>       return -ENOKEY;
>>   }
>> +EXPORT_SYMBOL_GPL(is_key_on_revocation_list);
>>   #endif
>>
>>   /*