Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp406374pxb; Tue, 29 Mar 2022 05:51:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJ83AEbNpuTUH+9LzBM3iXeZkP4yx6OEPHk1XB0zy9Z9fb3nNaU1h1GbRdDsKdRZp03kE0 X-Received: by 2002:a05:6808:1b21:b0:2d9:fd1b:c85d with SMTP id bx33-20020a0568081b2100b002d9fd1bc85dmr1165360oib.174.1648558310735; Tue, 29 Mar 2022 05:51:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648558310; cv=none; d=google.com; s=arc-20160816; b=bEPZjqC5Mk2lt8Yf8cdWNS9qIseTxkYpCdQjqm7SxkBaUwiQBePzYbgJZ7bIh0H3/q A+hBzCpLe/lkgldbRtoF9z8GN1kLyMWJgQUCNYUOAY13+0SYVCx82JELB5n/m+SI6g/0 5dvIDgo049wd8kD+Gd9w0a4Po573i3keO+EiJnn/0YaH9OtGQNs/c1GW5aDltEkb9K47 qPGcHcDzZJkuN6KyOOxygZ9zYjBreQ5VLiraiTne80Hmn7F/AdS617Sn/EfeqFl7L9k5 vB9Vy7qtONyJ65FIVw8PgNGJPO3l0evV44483aFEZaum58ix9U+K+vD1aCnZ9m98qUvd gEWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=VOjJ7Q0ZA4mllpvjA0RX3ngAdKju5rUvcFqpW0fI4vc=; b=PQ2XvgMmInprY99JqVGfqo+PBUxhhmrn3dBCYdPlGlV2NFDkJxvhLogi8XPoDJOBEQ EPMsLhM9KIEcvF31JiPN0x0KZK9m6ttc++7jYW8xdBiZOMXn8f2SK6SWcTQDjVR2ZZ9i 4KbLqq+YojDFsi1rG/n+DwxS4XEd5fYLFLkv5xzLzVz9IVG6Q+BTosTGmikUuVWX2PJI CONIJM/pHhrPWVQoQhcVbptW9HQGSP9UO7LxHy3wPWFcLMG+zvXBw16b9qx1Yt1/ZP8h sNaGYbwtKN6Udxh1IiSAWCxYuPr1KrcY60gI1MEVxAmgfoWYFZiufhPrS8Ft4dzVYN1y QCAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=FTCfDTMe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bl4-20020a056808308400b002ef0c3475dcsi17906997oib.92.2022.03.29.05.51.36; Tue, 29 Mar 2022 05:51:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=FTCfDTMe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234890AbiC2J6M (ORCPT + 99 others); Tue, 29 Mar 2022 05:58:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231864AbiC2J6K (ORCPT ); Tue, 29 Mar 2022 05:58:10 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D40B9E9E9 for ; Tue, 29 Mar 2022 02:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=pJFbieYuMliDkorM/V/PDbhfFVJI 4OfwO+V1QhjgIjI=; b=FTCfDTMel3Y0xfBFes0gT9fT1cbL485/LVqU1dPzzEIX 21iJL573t/oUpScLaRVSknihh7GZNAUreCGodX9U1P44S6Qv/CS4JWKX20C+Gsyr cdLnHadYSxGaOn6NzDhGY9/0wjy+kn567cy+XHOcT/rhhfoeHF8gsADLM6wPIVc= Received: (qmail 1736111 invoked from network); 29 Mar 2022 11:56:26 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 29 Mar 2022 11:56:26 +0200 X-UD-Smtp-Session: l3s3148p1@yf0ycVjbXKggAQnoAFHmAKNSQL+AeJes Date: Tue, 29 Mar 2022 11:56:26 +0200 From: Wolfram Sang To: Geert Uytterhoeven Cc: Krzysztof Kozlowski , Sergey Shtylyov , Dung Nguyen , Lad Prabhakar , Andrew Gabbasov , Mark Brown , linux-renesas-soc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] memory: renesas-rpc-if: Fix HF/OSPI data transfer in Manual mode Message-ID: Mail-Followup-To: Wolfram Sang , Geert Uytterhoeven , Krzysztof Kozlowski , Sergey Shtylyov , Dung Nguyen , Lad Prabhakar , Andrew Gabbasov , Mark Brown , linux-renesas-soc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1HwUNj8StJmyV25U" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1HwUNj8StJmyV25U Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Geert, thank you for this update! > - Update comments to match changed code, > - Add explicit {read,write}l() for the 4/8 byte case, to increase > readability, > - Remove redundant break statements, I really like these changes and have nothing more to add: Reviewed-by: Wolfram Sang I also tested writing on R-Car V3U and V3M, so: Tested-by: Wolfram Sang Happy hacking, Wolfram --1HwUNj8StJmyV25U Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmJC18YACgkQFA3kzBSg KbZIQRAAkuzVjLW2JAhysnb/w5LhrCW28JB4+nAMveqOktOY8nICtFIKcYMBzKPz 8YPcWrsZw5vxhoO9U/QJLHGvqu1m2jcgVB5sQmHZK82PhBgHAWDH3bv01NCpau+C 6FQdyfi9UO1BJmsezDi/gBpLwSuQDGdWSdVZ8C6NCUUxjsZwqCmzahupWSCgzgHN ZqI821Tl3L5P7ynMtgZ0C66ATZ62tmtLlG/Iby21e6VeEnIvrdu15G1v9GeqFScY MQg89w38h15ZkU/nKOIuULw4ZwGqdKpFrTFG/GsUaiG8/qkRpqE99IMouIqO2svQ aGqGDT8JCx1NE92uB357nAkgjywo2q3cZqFEH2brG7GREVUfhzrP2d4eJqnYDWbB lrjiYPMgaMtDLjlW0RqcbETFQGQDVlVqHgU3dGBmSGzHm2R1hanTAuoxwyNUTtVv 3WxwDo91OP4RjS5QyY/6M2VE9nSyOSEY2XVB8pjw92OUoovU7CONwfIVgLm5FOcZ m0RBpwRWXgdU9P/+11OfvDJmVaREcMK/hi0OVvvi52Ynebq35JfHtsNUAkynCwM4 1/81dieewJoPzABVqtuqzbSIktbaXFGCT1+kmaj+aRn1ywhoWKldmMGIm8lXKuvm rZCYovg8BEKzTx2oQjxn25byetZGGRCIcbSWu1i3CEB65piiFFU= =USGZ -----END PGP SIGNATURE----- --1HwUNj8StJmyV25U--