Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Rolf Eike Beer <eb@emlix.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: mm: use mmap_assert_write_locked() instead of open coding it
Date:   Tue, 29 Mar 2022 08:45:37 +0200
Message-ID: <10178697.CBVEcFiDRS@mobilepool36.emlix.com>
In-Reply-To: <YkKo93R1Fm0JXXtS@infradead.org>
References: <5827758.TJ1SttVevJ@mobilepool36.emlix.com> <YkKo93R1Fm0JXXtS@infradead.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart5766660.gleqY7jeCr"; micalg="pgp-sha256"; protocol="application/pgp-signature"
Precedence: bulk

--nextPart5766660.gleqY7jeCr
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
From: Rolf Eike Beer <eb@emlix.com>
To: Christoph Hellwig <hch@infradead.org>
Date: Tue, 29 Mar 2022 08:45:37 +0200
Message-ID: <10178697.CBVEcFiDRS@mobilepool36.emlix.com>
In-Reply-To: <YkKo93R1Fm0JXXtS@infradead.org>

Am Dienstag, 29. M=C3=A4rz 2022, 08:36:39 CEST schrieb Christoph Hellwig:
> On Mon, Mar 28, 2022 at 10:24:51AM +0200, Rolf Eike Beer wrote:
> > In case the lock is actually not held at this point this also avoids a
> > stale lock reference if built with NDEBUG.
>=20
> The change looks good:
>=20
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>=20
> But I don't think NDEBUG is a thing in the kernel.

You are right, it was in tools/include/linux/kernel.h and I didn't spot the=
=20
prefix. Andrew, maybe you could just delete the sentence when you add the=20
Reviewed-by?

Eike
=2D-=20
Rolf Eike Beer, emlix GmbH, https://www.emlix.com
=46on +49 551 30664-0, Fax +49 551 30664-11
Gothaer Platz 3, 37083 G=C3=B6ttingen, Germany
Sitz der Gesellschaft: G=C3=B6ttingen, Amtsgericht G=C3=B6ttingen HR B 3160
Gesch=C3=A4ftsf=C3=BChrung: Heike Jordan, Dr. Uwe Kracke =E2=80=93 Ust-IdNr=
=2E: DE 205 198 055

emlix - smart embedded open source
--nextPart5766660.gleqY7jeCr
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iLMEAAEIAB0WIQQ/Uctzh31xzAxFCLur5FH7Xu2t/AUCYkKrEQAKCRCr5FH7Xu2t
/LXcBADMuAegclXembgVJmHq0YcEloLQWTaJRtS92hzIVkoOWoPOLiv9eDVPRin7
prtThu86pU+RMyxgDF9t0rO304qTCVXtZ3yuL8O1g1DGEBp+aCIaXvpBW2CuxUO+
BCVCmXDNrGHIx7ZS7ZVs/trKfFOROvdkxLcLnAILsM4636Orjw==
=zfeV
-----END PGP SIGNATURE-----

--nextPart5766660.gleqY7jeCr--