Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Mar 2022 12:08:36 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     axboe@kernel.dk, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org,
        syzbot+f08c77040fa163a75a46@syzkaller.appspotmail.com
Subject: Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}()
 fail
Message-ID: <20220329090836.GT12805@kadam>
References: <20220328084452.11479-1-fmdefrancesco@gmail.com>
 <20220329074744.GR12805@kadam>
 <20220329075752.GS12805@kadam>
 <824276213.0ifERbkFSE@leap>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <824276213.0ifERbkFSE@leap>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JG+ZU43WMDY/NyBnTwOAH1zmjN4cSZpePhgJKcqNP73PUs9gzWIHfLHoZUK5?=
 =?us-ascii?Q?+b9FFJ4HtZaTm71nH7UEEzFzUb3fDD1AGW6oi3gbc2NBftEg+w3K4c193jVI?=
 =?us-ascii?Q?4ld7Hu1OYExdeP0+VdGLQlfoInzkBquJW6gGlq+YM/eduW2TWkFYUYj+iKOJ?=
 =?us-ascii?Q?YTSMgxrqGA6je7OGI6O5ro9gNVVMc2pdpV+9Bzw1aqDRMmMtY4pQwTiILrm2?=
 =?us-ascii?Q?ZAfWGQmYTweyKymLk/65Sd1DGMxQ4sfKBO+E6Aht60LtPOm+xTpJAPOojyw4?=
 =?us-ascii?Q?intBqIzrFNKNRr5cR7YGF9gz2ebvgvEY4IzaQCrBKyXeotpQAKB172YXA6pX?=
 =?us-ascii?Q?W/tBEZ2fgEPVpCROI66pfhw3/HtLuID56vJRpX8FGsaSD3ivtt0XeeV7U5RA?=
 =?us-ascii?Q?pgIBp/v846qL2HZXi6pP2BKXVDMUGGSWnx/qdmdIr7gJgGGJSl1hE2GoShXf?=
 =?us-ascii?Q?TgV6qRH45EPRV+PTX3QVCI0OZKJArAF+uPhCOwQdVZGKyhMysBhJJaYdY857?=
 =?us-ascii?Q?FX9ug4jo8tccRxWwQPETiQ9s8hGINAWFGLpj+jNFjluTWsG0m30w5fEhbzXh?=
 =?us-ascii?Q?LQRi0433ActDhajGO618kctUB565YojNU6nE0MLOGzy6K3eiP+/DAChymG59?=
 =?us-ascii?Q?/7KFDPpw0AhDdIivR13cP8S7DNLcP6UKKpCuVdby0W0q3d8bPiIuXhpECWeN?=
 =?us-ascii?Q?BJKdWzllatkqleHcP2dq9Pi6eY+AmhOaqgyyyYknwvPomqxtwVS3jMUK5ioL?=
 =?us-ascii?Q?Dq7LBL34TMZ7fc6jozmK/Ve3oxzfdQ3KDcIlH5b2LcfX0UO2/cLrVq8cZhUg?=
 =?us-ascii?Q?CQZvwMtyF0XWVJMz5x727a65Eu9R5NYmp86MZ2RRTs+fG9ExTDsNOxW+9ECm?=
 =?us-ascii?Q?iEmk24nikjnvTsOE7w3jPGHxi/Gwh7qUSF3B45EyObgBvhs46QltK6/HEFS6?=
 =?us-ascii?Q?B+B0o2pqbEE3uQfuT8EbRymzzS5DRnD5QOPr9IU5GA9xBApBkBvisnZyb9to?=
 =?us-ascii?Q?IqZwQMiS8wjlBnknVmNKvuyNRvZnzJWuLQBmgq7/IZV1gLTlnhfQBySrvsNQ?=
 =?us-ascii?Q?EiVFGtCSW5DwacfbftUXvdukWacxRzmGJ4nQoitNMDLFAMFs+520wt9lfKNR?=
 =?us-ascii?Q?2dhw5GuwzZUtXNc9sxumdTsyyygga97XnTb0mSFy2ibmC9wYm3MV9de6aiDI?=
 =?us-ascii?Q?k3EgiFKplZICiecg/bXoZRIDt+TsT80zr+4aUfttQs0kKCW6yVTMjSb/lEyv?=
 =?us-ascii?Q?NYm2itd1JXX4RtizB0iuuOIAvaoRJOFRZuvSj7MBwLGmShq8cr0agvmxf6nC?=
 =?us-ascii?Q?7XChWOlyg6OQOObpzkMkWiXKIcrlMQnvpGmvsbVxcDqEUntDTktZ9yU3H+/M?=
 =?us-ascii?Q?yPIJsCU8zJncqoSdu84WgzJbcUfzC5G0OcstU/4kxL5HWabNvxiNmsH1aozC?=
 =?us-ascii?Q?t23HC2ciLTxy7D5MjXbeqWudrk9jfR3/BTrkvBlMhJPuWwthLnJyFz1aGnNL?=
 =?us-ascii?Q?Y97tyKd5iGvKz0MR9iU86hfOblNRJ994Glz6pIcilalmExoi73LnPJdj7Zk/?=
 =?us-ascii?Q?SK92R6IdBxR84o5Vu+f/NevQfpxFCO++MLQxWxTq1bM1jFaUBigGXlNK8GY6?=
 =?us-ascii?Q?Xp9Qz5x9LnmSErOu2CcqxkJs6FDUbEK7waZzb39ZJ0/aR9gB5nHgPqtowhFh?=
 =?us-ascii?Q?2SUkGdK7qKPs2lDKAosiF9bJ3FtUC/QcM5eQN8HGukn25htE+UTjUfFj3zsx?=
 =?us-ascii?Q?o/GGD3gTwQRQDyiX0yp0dCIG+HTrgVk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52bcbbab-f39f-4be8-1d2c-08da1163c4d9
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2022 09:09:02.9437
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 98VErxu1q4P29pqugdf5w+PFPdKNNCCbR2GNc+pf7lgcnhv79squC/y4B+BEAFfMSFOoCv/vHtkn9lbIlIvce1Iz/bQdJ4uDL2wBfiScuTk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2523
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10300 signatures=694973
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0
 adultscore=0 mlxlogscore=836 phishscore=0 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203290053
X-Proofpoint-ORIG-GUID: rgLEjZ0PpTBRDmnDnItEvXZZRRFUlFLh
X-Proofpoint-GUID: rgLEjZ0PpTBRDmnDnItEvXZZRRFUlFLh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 29, 2022 at 10:28:24AM +0200, Fabio M. De Francesco wrote:
> Therefore, I suppose that you are suggesting the following simple change:
> 
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index a390679cf458..13d96d0f9dde 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -3474,6 +3474,7 @@ static int sd_probe(struct device *dev)
>  
>         error = device_add_disk(dev, gd, NULL);
>         if (error) {
> +               device_del(&sdkp->disk_dev);
>                 put_device(&sdkp->disk_dev);
>                 goto out;
>         }
> 
> Did I get it?

Yep.

regards,
dan carpenter