Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Mar 2022 10:57:53 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     axboe@kernel.dk, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org,
        syzbot+f08c77040fa163a75a46@syzkaller.appspotmail.com
Subject: Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}()
 fail
Message-ID: <20220329075752.GS12805@kadam>
References: <20220328084452.11479-1-fmdefrancesco@gmail.com>
 <20220328143853.GU3293@kadam>
 <2179817.iZASKD2KPV@leap>
 <20220329074744.GR12805@kadam>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220329074744.GR12805@kadam>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?s//anRaY4hRzSQgGVelCnvCo52/UrulPVPhQAWsw6xIIfMDN3xLo15IaYj6w?=
 =?us-ascii?Q?n0M2xuSaD2h4cwrIQ1zlaA9VU6Xa33MaWRkE9FrKm1fWSzFIlquL2k0E3bbM?=
 =?us-ascii?Q?g+r3V7kZb2zh/2C5i1GcuxMLp7/wpJpNUe+PxE/e1HEMMtSD/QYbk/xwPsZO?=
 =?us-ascii?Q?3EOl12rNgu8vCXyWQGzqmGZ1/3XjC1ytrYKWvNISREAxM13SkXCpNerpVDYs?=
 =?us-ascii?Q?hFGAa2t2C0Q0NTRd1d0wBKo4nzigS0UUw1vRVRh+k7cfJsdroBkI5x6EFtpZ?=
 =?us-ascii?Q?US/IrVuS7dxqTS8uj8unzqp06bDQexYawIf+n+ZD78JTuAVkVprtnt7NK0qz?=
 =?us-ascii?Q?KiRiT1GCv004awIsJVil7/4WHiKWT69DzvS6PJAQr+A73Wx/Y7DXF4OSwGcG?=
 =?us-ascii?Q?XsWs5LmWZVFzMxVaBeoSd9guYV3kMdfS5Bvvc6g6xXfJEaiOXlXsa5/Vfly/?=
 =?us-ascii?Q?2sGqvHvPqpCJE2/znS2UVKRrPmpY1pHy/paAO2BrYqNtKTq1gDjWkgiFz8rU?=
 =?us-ascii?Q?Cv6EkztO00rpP/rGHoz/IVG+ZPFcYOaX1n6rpIVWX9b7zmh9nKBvSD4xZZdX?=
 =?us-ascii?Q?e0SmF0jnNnzy/Zbjoa1O4t1JiePfJ8OBz/OofL7DkcWt1/cMb3zK2UKmdmiV?=
 =?us-ascii?Q?eI+gUEr2WST1BJpHF5hoRtt88ZiyoeJBoo4/zKh3OAX/Freg7SbG6fTc/Hrv?=
 =?us-ascii?Q?e3hE+2EbAqYfXV325Od9esqNBAHF1dgHPE0oMyIXXxUBPQZdhFbop62jZNPD?=
 =?us-ascii?Q?CUid2lVgBOOuxpgd33wsXJgpFn7vZ/K+i425yp9ZJTxImZxuRSrUvdut33Sv?=
 =?us-ascii?Q?v63i80nZ5FZYwDbdE0xasJ00zVdSyiFTRt4iegTo+SpYsA6JOChi8gr06SHZ?=
 =?us-ascii?Q?Xfo+Y85/AyUodYGCV3EHtzI+B0by06RNh5FnKkZbALh8ninKee+n2bE0iLqc?=
 =?us-ascii?Q?YwaPy3uz0LJNbPruf5yAIwCh9cPdldAzL+ctsW2zAGgKo1RcfjDohOql1gB4?=
 =?us-ascii?Q?EZX6xolK66haadxaE4nf1OBjGUU5LNXNaAhavs+Qt86E6GPERJnp6XThY1GK?=
 =?us-ascii?Q?pJyn4PeIhTWzUKMsGg4fRl3C3+KSa+EAoR0fxJ6SIVHRHKRqTCBNG3fIPb/2?=
 =?us-ascii?Q?f6mtCo9nYGT9XgudbJeyztaN2e9GEBW+hTsqOoiHBFZ1QVu8tQB8qdelAnbT?=
 =?us-ascii?Q?F6HIv0TSSaQtPzReEkVy+poH4j/ihKSlKltj6GUxDTTbgqWdDHydIG4+yn5O?=
 =?us-ascii?Q?yvLDj85dFC7WXDB1oCPcImNrcXOQWtX4dIWlb1Y6HF5+iqtnqfI4wclOebOJ?=
 =?us-ascii?Q?IajfBSF/Wxb2k6G/Ruxl94NInBh403eWis/lHOdHNrK8NdzrdnM6zbF2cKMy?=
 =?us-ascii?Q?8QEE90slOdViK9isRQpqM+ltI1fKTsFTcLU74QTbV2FG0fKns3pLSxzbLXYm?=
 =?us-ascii?Q?y+I6a4SDMObmQMcCCwshyGI4l8I7QpfF1TT9BAJbksqo+BP4sSwcUiLotPEM?=
 =?us-ascii?Q?gl46sovciEMKXa+08bk8JnLf+unBUa7ue/bt1JGrJRIAb/mxM7NfcYgEdIir?=
 =?us-ascii?Q?paMby6MA4kXnVGW1C4FBWDE5OP5T+0tYbwIzJPT2lweyfsYrxnpf6SXb/Yj3?=
 =?us-ascii?Q?VVc8J9sbK68mFX1FsYjlced1A81KACxbSkIz9grc7MczUymMWS6RS3qH2WR5?=
 =?us-ascii?Q?WYlyCn9DZa1CEP+5+MJz5GPMuiskSh8rJ7D8wXEJuyDynLnD58PKAOOKmD1k?=
 =?us-ascii?Q?YbBngERVyHvyZCLNkAWKTvXK0AiZ7sM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e09c2f68-cb2f-4cdb-c486-08da1159da9b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2022 07:58:04.4999
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wKV7KnzcUcZA1ueqcGCDZ5TO8iqgxgsq2gVIk420SiwNR9kGpgrJEKr9S7+Sf/L2AtmdLPtffFi/SPhu5xG33VNNwQjjadz//Ep5+6ieb+s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5591
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10300 signatures=694973
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 bulkscore=0
 adultscore=0 spamscore=0 mlxlogscore=841 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203290046
X-Proofpoint-GUID: 8XDu1ekGihg7PXXMX6WIk_FXk1tl-Kkb
X-Proofpoint-ORIG-GUID: 8XDu1ekGihg7PXXMX6WIk_FXk1tl-Kkb
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 29, 2022 at 10:47:45AM +0300, Dan Carpenter wrote:
> No, this patch is wrong.  That is supposed to be freed in scsi_disk_release()
> but apparently that's not getting called.  Is the ref counting off?
> 

Yeah.  The device_add() needs a matching device_del().

regards,
dan carpenter