Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp576527pxb; Tue, 29 Mar 2022 07:57:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3oUyUJCYVx5WJfe2RbE7MPJeMyTpejPH+cCim8WS7LXzWqwKBiwWc9+yw0KFfQI+PRBtS X-Received: by 2002:a05:6402:34d6:b0:419:4dc2:91c5 with SMTP id w22-20020a05640234d600b004194dc291c5mr5064763edc.329.1648565836218; Tue, 29 Mar 2022 07:57:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648565836; cv=none; d=google.com; s=arc-20160816; b=hkBv5PHJDa5NW1wNbSZX0Y5t7cT4HKC9F1ySci5aD5G9lPVwywQGeh0UO5f7EK4LR1 b6Bbyzs5P2jNRSGnoT7pmIR7NkdLNt1QSK34QnUwnJ6wuZuZ0ULP6WJa5PNRIpPLCNDZ 71KEOt2fciH5EECR3FNKItGfWntLoNxD6hNg8+xtgGhXOiChpW4vX1j89cPuAZkoPZaM zlug5+RzX0S1oY+a3lzki9MqKEjA0fbviYWmhTYZnlI78DNuDLWBHdfC/w+BIsxEbs16 R3oQnyHsCYQSMucrzId35Gud5KzRwQTaxbL1F+OiYMRlXRsdwCkE2g5Mn/7PujxuoiEI idJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=du90gsiDlM+40+IbjuJ8V4ICCC4TYDzPGHi3osdAGGw=; b=Rp2dLmGVelvaZKM8pC1Ymq2LfaMTnrC3r7UoT+13kquhOsKkl1/HxCPEaqiKDTgx/I E8RbipxRhaUpc4sHffNd7Gt4lY8enaQl1mmzZyN7KjkVl97SLFqe6vb9DKb73qUcoyhR WetD2bQp+auECyTHh7J1eg18WIeEEhigEqIMlCBMh7KF6uUa5YZwXg7Zj1KXRdcw55pd 3NqkuViAo/RIUBhl0unYRy1ySsci5mh5HSgQzI2tigKdic5GaAphsCzGxpc81b0ThxIX zLEjcNlHpyrdwvf6A2GQW1wa9zm+1RFjEfjvtAVICHtvrQ0sj/4bVDxx/xboT89AzGC0 NCzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=mAylmWCh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j1-20020a170906430100b006df76385ca3si17563284ejm.323.2022.03.29.07.56.47; Tue, 29 Mar 2022 07:57:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=mAylmWCh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233264AbiC2HFy (ORCPT + 99 others); Tue, 29 Mar 2022 03:05:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233249AbiC2HFw (ORCPT ); Tue, 29 Mar 2022 03:05:52 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70A62BB937; Tue, 29 Mar 2022 00:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=du90gsiDlM+40+IbjuJ8V4ICCC4TYDzPGHi3osdAGGw=; b=mAylmWChiSovWT4CCUEtsY4pC4 ciarHSfwCUcQnkIn87ofQykBFVLFtKOIuBP6jBN16sVFwYNSyZoj3YvWeaESF4RDPQhoTAYi+51SB aSmQ5hzJ/Jf7eR08SRzF9er2z5unN2a9mjuPxI0SqMi5fS4D8Pxtxl9WAgDPEslH3MS1Seu2haRFp dLNQRiiWubrxmwmAoIOtwgq0oVpr6fCZigNVHzpPZyGUEVNhRbLm2BeqfVt20l8F02W2Mk5+CDhGm 29XHGI1MpNjArUyqKlo5xLMiPcmm0DCfebs/JyMiCxlenw8b5LFQEDlIanePDZONfkwC7AYVklFw6 vDjMD9JA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZ5tf-00BGHd-J4; Tue, 29 Mar 2022 07:04:07 +0000 Date: Tue, 29 Mar 2022 00:04:07 -0700 From: Christoph Hellwig To: "Fabio M. De Francesco" Cc: Dan Carpenter , axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, syzbot+f08c77040fa163a75a46@syzkaller.appspotmail.com Subject: Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail Message-ID: References: <20220328084452.11479-1-fmdefrancesco@gmail.com> <20220328143853.GU3293@kadam> <2179817.iZASKD2KPV@leap> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2179817.iZASKD2KPV@leap> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 29, 2022 at 08:18:16AM +0200, Fabio M. De Francesco wrote: > Yes, correct. I've just looked at how put_device() is implemented. I didn't > know how it works until you made me notice. Thanks! > > Aside this I sent another diff to Syzbot. Today, at 4.30 CET, it replied again > that, after applying and testing my new patch, Syzkaller was not anymore able > to trigger the memory leak that it had reported. > > This is the new diff... Yes, this new diff makes much more sense.