Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v1] MIPS: ip22-gio: Add check for the return value of
 kzalloc()
To:     QintaoShen <unSimple1993@163.com>, <tsbogend@alpha.franken.de>
CC:     <linux-kernel@vger.kernel.org>, <linux-mips@vger.kernel.org>,
        <ralf@linux-mips.org>
References: <1648454654-27200-1-git-send-email-unSimple1993@163.com>
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
Organization: Open Mobile Platform
Message-ID: <6dd8bcf0-20a1-0bab-b48e-ec1bac5c15f0@omp.ru>
Date:   Tue, 29 Mar 2022 11:35:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <1648454654-27200-1-git-send-email-unSimple1993@163.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello!

On 3/28/22 11:04 AM, QintaoShen wrote:

> Since the memory allocation function kzalloc() may return a NULL pointer,
> the use of 'gio_dev' may lead to NULL pointer dereference.
> 
> So it is better to check the return value of kzalloc().
> 
> Signed-off-by: QintaoShen <unSimple1993@163.com>
> ---
>  arch/mips/sgi-ip22/ip22-gio.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c
> index dfc52f6..df7ca21 100644
> --- a/arch/mips/sgi-ip22/ip22-gio.c
> +++ b/arch/mips/sgi-ip22/ip22-gio.c
> @@ -363,7 +363,11 @@ static void ip22_check_gio(int slotno, unsigned long addr, int irq)
>  		printk(KERN_INFO "GIO: slot %d : %s (id %x)\n",
>  		       slotno, name, id);
>  		gio_dev = kzalloc(sizeof *gio_dev, GFP_KERNEL);
> -		gio_dev->name = name;
> +		
> +        if (!gio_dev)

   Indented too little. And indent with tabs please, not spaces.

> +            return ;

   No need for space before ';'.

[...]

MBR, Sergey