Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b70d47e7-5e1b-a23f-80af-eaa255a103e3@nvidia.com>
Date:   Tue, 29 Mar 2022 11:55:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] drm: tegra: fix memory leak in error handling path
Content-Language: en-US
To:     cgel.zte@gmail.com, thierry.reding@gmail.com
Cc:     airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lv Ruyi <lv.ruyi@zte.com.cn>, Zeal Robot <zealci@zte.com.cn>
References: <20220329103747.2376753-1-lv.ruyi@zte.com.cn>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20220329103747.2376753-1-lv.ruyi@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djFEQU1ZOVN3Um9JbTNETzNMY3RRUS80UUpLOWVNNCszWndIRitBd0duOThR?=
 =?utf-8?B?ZUp5ME9tOWl4VUtseGMrN1NFckl3TTlXemtxVjk3UC9NdUI2Z282cmU1VGdI?=
 =?utf-8?B?aVMwR3BuSWxiajArU0QrTTJuUVlVckJUN0doQ3RiRTJVeVZQUEkwMW5NMkZo?=
 =?utf-8?B?U3cvMzFobDExbEwrcXdldE84L0FMY0wvQzNWdDBaajZIRGs5NGlPSlhHcmZt?=
 =?utf-8?B?Y3hIWCt2Q2IwR1owenpzeUVZR1FUYndaVlFlOTR6eitoMVpZVCt4Z1RzMVZI?=
 =?utf-8?B?SVlWZ3E2eTdHU0N2Ynd3UFBNaXQ1L01walpaS1lzcHVSZGlXN2poN2lHRUJT?=
 =?utf-8?B?L1J5eVdzdW1wOEhIcUZRMWllMnpvK1FpUWdiZlNTV1NmY1dkVkR6eGEyZFV5?=
 =?utf-8?B?QWxCQVJaYTZ4NFFidHZqK0NqMnAwamZVTXNJbHZzcS9MMmVsa0g3dEZwTFBY?=
 =?utf-8?B?bFBGK1NwQWxmVFZ3THIrSFR6Yy9xZEdrVi9lM1pMN0FmYXpSczAzMWkxclVG?=
 =?utf-8?B?a1BTRG5QZXNvNGRyK3BzaVFySXYyV3VWQWRnTVBUb21iTjd5TGVXUVY0QlVI?=
 =?utf-8?B?akRGclh3ZE9lT0phM3ZkZDNmMk9GVHF5VWdyV1hZMHBGdGp0N29xazdSWCtZ?=
 =?utf-8?B?WjcxWXhvRytEcHdDL0xCZ0JsbmVBRWpqTHhhT3ZrdzJrUk16SHRKSHRFMEF2?=
 =?utf-8?B?L2FJWnhQTzZTei9QVG5UdFZ5c3lBbUlubzJoYURYUVJINEpacC9Td0pNd01l?=
 =?utf-8?B?emkwME0yM2prQzdlR0ZXY3dRWTZ5VTZzb1hhY3QxK1NzTTRmNStiNFZsLzNs?=
 =?utf-8?B?MWJ5RURZM1JxZ1RVd3dIdE4xQlJmUnI1QVQ0WkFJa3ZadTJuM1IrdkJnb0pq?=
 =?utf-8?B?WFQzS1JRTkZCdGs4Y3NRZ2loL3lrY3VhdVRxU2ttYnRtQU1reGhDcnlGNU12?=
 =?utf-8?B?VjcxQUNVOUlUZndMZDc4SXRuamY1WDJuSE0rbnFtdTV1Q3I5TS8vbGtZWjlt?=
 =?utf-8?B?N1NVODVCc015WUJFY0tJdnhGVThIQjQ4My9LVFBMZkZWajROelRIN3h2STJx?=
 =?utf-8?B?N3ZJS1hiVEN5MjFNM2NwZjd1UGkzQUc4WXJuaURJU2dQM0RucUMwWVZyMERS?=
 =?utf-8?B?S2hwSkhiT3gwNWRSbkc4Mm11emZ2TGJyVHFONDBCRXVMWDNYK2ZJOHU4dm11?=
 =?utf-8?B?eHkvTkNnNVdUcWdvbnMxOFBtNUczOVJsWUY3cE1BT1ZTbnNDVGxRNVFyQVNy?=
 =?utf-8?B?TVhUQmgrMGMvTWZZbWJBcmwrcldGVE5RcWpCalh2V2hHak92MWF6VEpUNG9O?=
 =?utf-8?B?RGxaR005SUJhNVIvdFJSVVBtbW9pTkNLRUZPdlJpUUtMV2ZxYUtJejRCUDhQ?=
 =?utf-8?B?VTIxTmdTUEcrTTRYbE9SOXZ3OEFMcDFNQnEzZDdZUlhKY3hQNWJUR3J4SGQy?=
 =?utf-8?B?c3doYUxJdXpVTjFhTkl2RitKWWNNUDlIWEROUWo0ZTR1S3lmSTFhSm1hWEJU?=
 =?utf-8?B?YXNtT3BUbkVBcmx5UllwK0Nhbi9NYWZlSWxGeFIrUHovZGNVcm9qZWloZTJE?=
 =?utf-8?B?QVRNUno2Y1VpMXBGdmVVTHM0Q0VwMlpVdi9QbDZPVGVzNDlwMVpmQndyV1A2?=
 =?utf-8?B?RkNKRmphWXd2M2FIdjZiZXJsMWxjYU9UR1NFTWdWWDBBYk1xdCtxSnk3a0FF?=
 =?utf-8?B?K3ZDV0R4NFRNL21KVHhzejg5eTRBQWlDRSthNStyK29JM2dQYTNjeVFLM2c3?=
 =?utf-8?B?S1VLT09hUDJIWmVHQlFIejFTeG5QWkYzVkIvbjdpSGduUXdXdHlyK1kzZHg4?=
 =?utf-8?B?UTdOT3AzNmtCdEhDU2JXOUFvbW80ajVqaldVWXpUOVFSL3JmVEd6NXBCSlNt?=
 =?utf-8?B?TEcycnJyMFRsbC9IOHJGenBSamQ1Z05uMmN6VE5xR3BmQmdOaDdEN3N6K1d0?=
 =?utf-8?B?TmJ5d0xnMWNYNFk3Nk9ScFZYQzJlOUZibEtuVG51ckNhRFhTLzkxYW0xU0JN?=
 =?utf-8?B?eXFBcHVqRTJWNXNybU9kc1hDZ0FabWtyV3lFUzhMZjdrR2xacXVkeXB2bEx4?=
 =?utf-8?B?TS9qVEpUYVJ5aVN0NzFWajlYV1NSWnFzN3U3eGJtL3NtNEZXK2NFVWttL0Y3?=
 =?utf-8?B?c0pVVFBNWXFyNW5uMU1iYWUwL0E0RlNwYnBuT3krMG5kSjJsblZHaWtrRk9U?=
 =?utf-8?B?d3psNzFtQkk3VzFCMUhLQXBpZ1ZGVHdmdzFkRER5aXNydTIxOEgvNFYvQ2xn?=
 =?utf-8?B?amF1MnVyNGpGbXdUNjVWRnhrV2J0dUZGVDlFT0dRSUZmZnJFZ01nWVNiSXh3?=
 =?utf-8?B?OG05aTV3L2oycDJYSHUyd3JXeGdLVFRmaXF1a0lwQ0N0Q1lJc1JHUT09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e21cb0ca-87d0-4060-74aa-08da1172ac24
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2022 10:55:44.1016
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J5ZGJRUQHUA3j12PVIqOjnjY7d4r08nfUp533DiBedoGlj6YSxDvjlKcOe1keEpCYGfx5fCVyuGIuUNzY5B28Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1534
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 29/03/2022 11:37, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
> 
> Before leave the nvdec_load_firmware, we shuold free virt which is alloced

s/shuold/should
s/alloced/allocated

> by dma_alloc_coherent, so change "return err" to "goto cleanup".
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
>   drivers/gpu/drm/tegra/nvdec.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tegra/nvdec.c b/drivers/gpu/drm/tegra/nvdec.c
> index 79e1e88203cf..a14863346bfa 100644
> --- a/drivers/gpu/drm/tegra/nvdec.c
> +++ b/drivers/gpu/drm/tegra/nvdec.c
> @@ -209,7 +209,7 @@ static int nvdec_load_firmware(struct nvdec *nvdec)
>   
>   		err = dma_mapping_error(nvdec->dev, iova);
>   		if (err < 0)
> -			return err;
> +			goto cleanup;


Actually, I think that the correct fix here would be the same as what 
was done for VIC ...

https://lore.kernel.org/linux-mm/6b86f6e530b504a5eee864af10e2ae1570d7b645.1639157090.git.robin.murphy@arm.com/

Jon

-- 
nvpublic