Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <65501e99-0839-5f08-8a69-95e3c77c64ac@huawei.com>
Date:   Tue, 29 Mar 2022 21:27:17 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.0.3
Subject: Re: [PATCH 2/2] mm: fix contiguous memmap assumptions about
 alloc/free pages
To:     Matthew Wilcox <willy@infradead.org>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <akpm@linux-foundation.org>
References: <20220329130928.266323-1-chenwandun@huawei.com>
 <20220329130928.266323-3-chenwandun@huawei.com>
 <YkMEyH9QB8MyzW37@casper.infradead.org>
From:   Chen Wandun <chenwandun@huawei.com>
In-Reply-To: <YkMEyH9QB8MyzW37@casper.infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


on 2022/3/29 21:08, Matthew Wilcox wrote:
> On Tue, Mar 29, 2022 at 09:09:28PM +0800, Chen Wandun wrote:
>> +#define page_nth(head, tail)	(page_to_pfn(tail) - page_to_pfn(head))
> Could we avoid reintroducing page_nth()?  It is a terrible name.
how about compound_index ?
>> @@ -1213,7 +1213,7 @@ static int free_tail_pages_check(struct page *head_page, struct page *page)
>>   		ret = 0;
>>   		goto out;
>>   	}
>> -	switch (page - head_page) {
>> +	switch (page_nth(head_page, page)) {
>>   	case 1:
>>   		/* the first tail page: ->mapping may be compound_mapcount() */
>>   		if (unlikely(compound_mapcount(page))) {
> This is the only place you use it.  I'd suggest free_tail_pages_check()
> should take 'i' as its second parameter instead of 'page + i', then
> there's no need to convert back to i.
OK， I will send v2， but I'm not sure whether similar function like 
page_nth is needed elsewhere

>
> .