Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <2059213643.196683.1648499088753.JavaMail.zimbra@efficios.com>
 <20220329002935.2869-1-beaub@linux.microsoft.com> <1014535694.197402.1648570634323.JavaMail.zimbra@efficios.com>
In-Reply-To: <1014535694.197402.1648570634323.JavaMail.zimbra@efficios.com>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Tue, 29 Mar 2022 09:25:52 -0700
Message-ID: <CAADnVQK=GCuhTHz=iwv0r7Y37gYvt_UBzkfFJmNT+uR0z+7Myw@mail.gmail.com>
Subject: Re: Comments on new user events ABI
To:     Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        bpf <bpf@vger.kernel.org>,
        Network Development <netdev@vger.kernel.org>
Cc:     Beau Belgrave <beaub@linux.microsoft.com>,
        Beau Belgrave <beaub@microsoft.com>,
        linux-arch <linux-arch@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-trace-devel <linux-trace-devel@vger.kernel.org>,
        rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Mar 29, 2022 at 9:17 AM Mathieu Desnoyers
<mathieu.desnoyers@efficios.com> wrote:
>
> >
> >> include/uapi/linux/user_events.h:
> >>
> >> struct user_bpf_iter {
> >>
> >>         /* Offset of the data within the first iovec */
> >>         __u32 iov_offset;
> >>
> >>         /* Number of iovec structures */
> >>         __u32 nr_segs;
> >>
> >>         /* Pointer to iovec structures */
> >>         const struct iovec *iov;
> >>
> >>                            ^ a pointer in a uapi header is usually a no-go. This should be a u64.
> >> };
> >>
> >> include/uapi/linux/user_events.h:
> >>
> >> struct user_bpf_context {
> >>
> >>         /* Data type being passed (see union below) */
> >>         __u32 data_type;
> >>
> >>         /* Length of the data */
> >>         __u32 data_len;
> >>
> >>         /* Pointer to data, varies by data type */
> >>         union {
> >>                 /* Kernel data (data_type == USER_BPF_DATA_KERNEL) */
> >>                 void *kdata;
> >>
> >>                 /* User data (data_type == USER_BPF_DATA_USER) */
> >>                 void *udata;
> >>
> >>                 /* Direct iovec (data_type == USER_BPF_DATA_ITER) */
> >>                 struct user_bpf_iter *iter;
> >>
> >>                                ^ likewise for the 3 pointers above. Should be u64 in uapi headers.
> >>         };
> >> };
> >>
> >
> > The bpf structs are only used within a BPF program. At that point the pointer
> > sizes should all align, right?
>
> I must admit I do not know enough about the eBPF uapi practices to answer this.
> [CCing Alexei on this]

Mathieu,

Thanks for flagging.

Whoever added this user_bpf* stuff please remove it immediately.
It was never reviewed by bpf maintainers.

It's a hard Nack to add a bpf interface to user_events.