Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Mar 2022 18:51:46 +0200
From:   David Sterba <dsterba@suse.cz>
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     David Sterba <dsterba@suse.com>, linux-fsdevel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/affs: remove redundant assignment to ch
Message-ID: <20220329165145.GZ2237@suse.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Colin Ian King <colin.i.king@gmail.com>,
        David Sterba <dsterba@suse.com>, linux-fsdevel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220307150742.137873-1-colin.i.king@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220307150742.137873-1-colin.i.king@gmail.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Precedence: bulk

On Mon, Mar 07, 2022 at 03:07:42PM +0000, Colin Ian King wrote:
> The assignment of ch after subtracting ('a' - 'A') is redundant and
> can be removed. Fix this by replacing the -= operator with just -
> to remove the assignment.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  fs/affs/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/affs/namei.c b/fs/affs/namei.c
> index bcab18956b4f..a1270deba908 100644
> --- a/fs/affs/namei.c
> +++ b/fs/affs/namei.c
> @@ -19,7 +19,7 @@ typedef int (*toupper_t)(int);
>  static int
>  affs_toupper(int ch)
>  {
> -	return ch >= 'a' && ch <= 'z' ? ch -= ('a' - 'A') : ch;
> +	return ch >= 'a' && ch <= 'z' ? ch - ('a' - 'A') : ch;

AFFS is in fixes-only mode, I wonder how much this change is affecting
anybody, from the user perspective. I'd say not at all, W=1 build is
clean and that's something I'd be fine to fix, W=2 and W=3 warnings are
from other code.