Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1123735pxb; Tue, 29 Mar 2022 17:57:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQxl60fN3d3BPaGHplgZnC20RQRSeLtOBbqfOg+V3QCJ8YMdQOn+zY1D9XdiTBeqnYTH9Z X-Received: by 2002:a17:90a:d302:b0:1c9:9204:136a with SMTP id p2-20020a17090ad30200b001c99204136amr1975393pju.136.1648601872706; Tue, 29 Mar 2022 17:57:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648601872; cv=none; d=google.com; s=arc-20160816; b=CzanksrfVt3xSzO1odQJLmkVJgZmQEfhSDPJuhJHIlRIeOOYzG9KishEUEvIEiHHdm siK1rtCn62MdfEeQ3XGsjX0iqtXUf871MzcLgbxGvZt7kqozyyzm5gK5jP5T30y8St9Z XmJ4lOragtT+27uQIyZ5fMN42pB/KODNvMarrzhzw31m7v1SjjJYPlgzQEJQl1PXoQM7 AUGsndOAK1Qa7117H+TyrgvdFksWg+D45gWFxs5uMBTGx2UzXpo8r+MN/O8aln91JeFD tiqde7s7bWJXVhxlpdGlLLJ35gYDteck7+YRPMrHw9w2WwHdxHum2GoroX+/III5y6km U4hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zIKf6bif4RDbPYlDQUKM62ySUzavLcyc+3Q3rzv+J1c=; b=zULZS9NFkJMCF1AJrzDUG2BqEB3NomHBHiXBgoWpUHRxWDvmSKIh5oug+cDNuV8HD9 SKX3Zv6EO0Wk7gpHj8lJVQ3UHKl2bQUGCaJboilA5qXPTL3sMzC5xA7gyxdILy9IRfZC p6cngGQT/bmC3vo7VjALzbY9Ot/FEMaEXt3VWARy+fYLmx7uKUyMXzogiSkAZ1ngpXtc XL8VvHXrDOUGqUcLqn4Ot8d8OHQ9g3nP+WY4Egtqw55wVUG0N7I0o82PvX9GCsr7pqJw F2NxiE0aFdySRPIU6ic+0DA4FGA0lvhFF3CgYVP6OvKn/Mv9i3lYKh7+GB9kSmaaRdj4 grYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="RO/j3CkU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r71-20020a632b4a000000b003816043ef3dsi19596614pgr.306.2022.03.29.17.57.30; Tue, 29 Mar 2022 17:57:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="RO/j3CkU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236913AbiC2Ome (ORCPT + 99 others); Tue, 29 Mar 2022 10:42:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229978AbiC2Omd (ORCPT ); Tue, 29 Mar 2022 10:42:33 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BF1A32054; Tue, 29 Mar 2022 07:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zIKf6bif4RDbPYlDQUKM62ySUzavLcyc+3Q3rzv+J1c=; b=RO/j3CkUCQ/izmSyUmEJizd8Cf 1Cgjr16QuOi8PAcsvNFgvTAu/GMs0TOEQWmrRs3tEy9Q2S5DEOTPTwd65cbdgKT1uJTcf1o/g0zvd cf7icO08tgTbRcqb7gVyl30Tp45dbXdovs1ZWZ8Kl8n9gRKyc6I5+IowA7M49M01bwp0jcQ9isD4V CXPTgVlBRVZH6mxgF3k7BDI9vM5H/qF2Qag3p7qq3aJ/SJxoS4OwiHjSSkxSU9mJoa0D8scqwOVbJ jCCFvYCpGDUwLDNsamfL/4OciTy65HFyn8pUmqpe3twMdnzQO8Kcynadh39xFz4XL1nVDycn5eT12 7CkfaYHg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZD1Z-00CWBB-1m; Tue, 29 Mar 2022 14:40:45 +0000 Date: Tue, 29 Mar 2022 07:40:45 -0700 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Yu Kuai , andriy.shevchenko@linux.intel.com, john.garry@huawei.com, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH -next RFC 2/6] block: refactor to split bio thoroughly Message-ID: References: <20220329094048.2107094-1-yukuai3@huawei.com> <20220329094048.2107094-3-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 29, 2022 at 08:35:29AM -0600, Jens Axboe wrote: > > But more importantly why does your use case even have splits that get > > submitted together? Is this a case of Linus' stupidly low default > > max_sectors when the hardware supports more, or is the hardware limited > > to a low number of sectors per request? Or do we hit another reason > > for the split? > > See the posted use case, it's running 512kb ios on a 128kb device. That is an awfully low limit these days. I'm really not sure we should optimize the block layer for that.