Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Mar 2022 20:46:39 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Kershner <david.kershner@unisys.com>,
        sparmaintainer@unisys.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: unisys: Properly test debugfs_create_dir()
 return values
Message-ID: <20220329174639.GC3293@kadam>
References: <20220322083858.16887-1-fmdefrancesco@gmail.com>
 <2030244.KlZ2vcFHjT@leap>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2030244.KlZ2vcFHjT@leap>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?8hOQIrCuzcfh03Rsv/+9+Mwd6V2vYpRnn7gEP8giSegNxN43/koM97vPk8?=
 =?iso-8859-1?Q?OqVut6rvZqzS5xYBNcci7Uc1VerPcrR4PwHsYPLZR3UrRRv9wpZCbsoXI1?=
 =?iso-8859-1?Q?18Hd7eg1mDMf+Wk+t5iGQt7OXucu7aQyOCnG0YX7YmlNr3SyQdBQ1Dsx4r?=
 =?iso-8859-1?Q?BjfboA9WcUieV0Mbb7rNFfpQyANAWxGMcd+w1pUe8Zm0L+XzsoiGRWJPe1?=
 =?iso-8859-1?Q?Vmg7hWERIYsAHzgzWA5LksbxAwaNFdzXmtmti+a2jPYxfA7yqfyA7dlx4h?=
 =?iso-8859-1?Q?lf+jQvbothnjbSrApq//3mD78ysbH95LRNUKg7a6Z+w3NBHXb5vvCAYwwe?=
 =?iso-8859-1?Q?tCMjT+RfWFP6bGP6M6jKptpwK20Y89P5H4vjdVfL+XpMJeFpSbXGo2pJji?=
 =?iso-8859-1?Q?Wy2SAR/qGY2FB+TJaxhW3xNONT2an5cXLQHm+kfLWdUBfT7PAaHcaAT0Gu?=
 =?iso-8859-1?Q?omG5MXIfBmc3X9Vul92XtEWpO+uJn30LEQVBxFLDr69ZwUb4+g/sJ0CH/b?=
 =?iso-8859-1?Q?/FG0f4Rww/JIBYh8t6Oj1zZg4x3sBIhtTgvs4RYRmlaQAJiZgGeCklnfDc?=
 =?iso-8859-1?Q?0H31iFo8mrDyuGLmjtcrbzQpJe79h/aO9vlkbBBE8zcoEqktHyD+jeecDQ?=
 =?iso-8859-1?Q?lOc6KZ4+60AiD3emco1jNCQF5CViqfLTtHXHwGv5F1gbpie3uBRUN/bmbG?=
 =?iso-8859-1?Q?7gcxGNZSbPP5axcoAMdvxUf3A+ogVOs6wSTQjb0ZLL6J4tW1lNVi09lBpO?=
 =?iso-8859-1?Q?On3GFpJarxyvLqGUi4sFExCZr+RtIRl1meUeckBJl+psqXm+X/HBeyDbQv?=
 =?iso-8859-1?Q?8b8qaDbipPfg7aD/5fsjucD3paWfTXO2+kBh/f/FLkEySJYDadDrUA9okE?=
 =?iso-8859-1?Q?WQwcM9Bq/0Ss3laohrKD6tOQmB5uQOfNReLB6XsvWGwONFBQXC0dXLN3FH?=
 =?iso-8859-1?Q?+D1MzwZsndztQpTmFgcTK3Ksa0B9vvpVSEVMGrI7KyJOkGAhCV1R7C+yt8?=
 =?iso-8859-1?Q?Duy4hqu6CWYdiQ6+LNKV3kWEmKzQfhxeX63nw343tWz0hWV9Aw+MPoR1Om?=
 =?iso-8859-1?Q?vpCqdYwjvSXQcADJ+hH28N0EQYMbwpwO5m8ALDuVVGGj4LyeLMpQtbCtZp?=
 =?iso-8859-1?Q?7l8pGByBlsYEgAkOYoRshj1EmKxq5mr7ifPBNoEV3DL3FlrKG7kvtxdcfx?=
 =?iso-8859-1?Q?USuRu8I0T86frqcsMJs5zeuV0TshCUDrCj5HeZgobbceA1q72+lYMhTern?=
 =?iso-8859-1?Q?7PSHoCCr0uqT7mWVsVHoi3YZIh+hk8CavHGcoplAxK2flPQl+FW9yCijuh?=
 =?iso-8859-1?Q?PWsfmL5+GmIrFXJ4nPDiecHYLkI0TPSE9bBtu5FAG1xBXt+M8jcM7FHdxL?=
 =?iso-8859-1?Q?CsOWXh2Zf2fyHs2K2CtyU1DREciSdm/G/hmSrslCHmwuTGW9+JFEd2byUJ?=
 =?iso-8859-1?Q?ETamam5oObD4Bg2jf08mVr3T3Av3SXX7GS1KkmBQaa14IZQOEeIUG6XkY3?=
 =?iso-8859-1?Q?aaPZXk2TsrYnKdCSRxrT66SNwjsGn7wy0J9va1rUags2+EpXTEfF0K8fV1?=
 =?iso-8859-1?Q?DWYo9UAnwoDFxHsbw+hWthIAqxVjZJ9zWsXhmVYAjf4iR1fDHV3CP/E6AK?=
 =?iso-8859-1?Q?9d/3oL2/f4a0GjtF7xsgEEpzFfglJKu1u8m/FD2tkIS6nTBqVREWkvqEwP?=
 =?iso-8859-1?Q?YWfZ6ZUDwyMcdpe0zQLhaoSvx/7WM0z8v6W1AvLnIwvUsOwotxFMzYiga6?=
 =?iso-8859-1?Q?IOlOoxh0qtlmuZonxEa/j6fcV5E3tbCdIcvOVJDcNiDnhv6514hh+VKQ+t?=
 =?iso-8859-1?Q?9Z23bAKDXx0+Z1fGpdIEcv2qkPr8qgg=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 908ef7cc-7607-4ac9-f1de-08da11ac1fa9
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2022 17:46:59.1343
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6K1NFU4tLC8yIZyUSl5GAmvGLgixUFtnKHUQkl0UBo+eSv1/qK4KjO09PsN3IM5Xpn21VZ+DuWnUGWf/TqCxPdsMUesqp3Z1g2h5m8COri0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5163
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10301 signatures=695566
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 adultscore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203290100
X-Proofpoint-GUID: bQ70FDrmVUL9f2CuGlTcjYSfX3W5Yf8-
X-Proofpoint-ORIG-GUID: bQ70FDrmVUL9f2CuGlTcjYSfX3W5Yf8-
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 29, 2022 at 07:00:49PM +0200, Fabio M. De Francesco wrote:
> On marted? 22 marzo 2022 09:38:58 CEST Fabio M. De Francesco wrote:
> > debugfs_create_dir() returns a pointers to a dentry objects. On failures
> > it returns errors. Currently the values returned to visornic_probe()
> > seem to be tested for being equal to NULL in case of failures.
> > 
> > Properly test with "if (IS_ERR())" and then assign the correct error 
> > value to the "err" variable.
> > 
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> >  drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
> > index 643432458105..58d03f3d3173 100644
> > --- a/drivers/staging/unisys/visornic/visornic_main.c
> > +++ b/drivers/staging/unisys/visornic/visornic_main.c
> > @@ -1922,11 +1922,11 @@ static int visornic_probe(struct visor_device *dev)
> >  	/* create debug/sysfs directories */
> >  	devdata->eth_debugfs_dir = debugfs_create_dir(netdev->name,
> >  						      visornic_debugfs_dir);
> > -	if (!devdata->eth_debugfs_dir) {
> > +	if (IS_ERR(devdata->eth_debugfs_dir)) {
> >  		dev_err(&dev->device,
> >  			"%s debugfs_create_dir %s failed\n",
> >  			__func__, netdev->name);
> > -		err = -ENOMEM;
> > +		err = PTR_ERR(devdata->eth_debugfs_dir);
> >  		goto cleanup_register_netdev;
> >  	}
> >  
> > -- 
> > 2.34.1
> > 
> Hi Greg, Dan,
> 
> Now I have time to rework this patch but, if I'm not misunderstanding, you 
> asked for two contrasting works to do here...
> 
> Dan wrote that "[in] this case you can delete the whole devdata->eth_debugfs_dir 
> and the related code.".
> 
> Greg wrote that "We really shouldn't be checking this value at all.  There's 
> no reason to check the return value of a debugfs_* call. Can you fix up the code to
> do that instead?".
> 
> I'm confused because they look like two incompatible requests. What should I do?

Greg is saying delete the tests and the error handling.  But I am
saying delete the tests, the error handling, the devdata->eth_debugfs_dir
related code and the call to debugfs_create_dir().

There is no conflict.  Delete it all.

regards,
dan carpenter